Uh oh!
There was an error while loading. Please reload this page.
bootstrap: clean up inspector console methods during serialization - #44279
Merged
Conversation
Some console methods are created by the V8 inspector after an inspector client is created, reset them to undefined during sereialization to avoid holding on to invalid references in the snapshot. V8 will take care of the re-initialization when another inspector client is created during deserialization.
nodejs-github-bot
commented
Aug 18, 2022
Collaborator
joyeecheung
commented
Aug 22, 2022
MemberAuthor
cc @nodejs/inspector @nodejs/console @nodejs/startup |
legendecas
approved these changes
Aug 22, 2022
jasnell
approved these changes
Aug 28, 2022
nodejs-github-bot
commented
Aug 29, 2022
Collaborator
benjamingr
approved these changes
Aug 29, 2022
This was referenced Aug 31, 2022
Member
nodejs-github-bot
commented
Sep 7, 2022
Collaborator
nodejs-github-bot
commented
Sep 7, 2022
Collaborator
Landed in f0cf100 |
RafaelGSS pushed a commit
that referenced
this pull request
Sep 26, 2022
Some console methods are created by the V8 inspector after an inspector client is created, reset them to undefined during sereialization to avoid holding on to invalid references in the snapshot. V8 will take care of the re-initialization when another inspector client is created during deserialization. PR-URL: #44279Fixes: nodejs/node-v8#237 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
RafaelGSS pushed a commit
that referenced
this pull request
Sep 26, 2022
Some console methods are created by the V8 inspector after an inspector client is created, reset them to undefined during sereialization to avoid holding on to invalid references in the snapshot. V8 will take care of the re-initialization when another inspector client is created during deserialization. PR-URL: #44279Fixes: nodejs/node-v8#237 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
juanarbol
commented
Oct 3, 2022
Member
The introduced test |
szuend
commented
Oct 18, 2022
Contributor
The |
Member
@suend I think you can open a PR against the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some console methods are created by the V8 inspector after
an inspector client is created, reset them to undefined during
sereialization to avoid holding on to invalid references in
the snapshot. V8 will take care of the re-initialization when
another inspector client is created during deserialization.
Fixes: nodejs/node-v8#237