Uh oh!
There was an error while loading. Please reload this page.
v18.10.0 proposal - #44799
Merged
Merged
Conversation
The upstream merge of e27e709d3c accidentally removed code related to systemtap and dtrace. Signed-off-by: Stephen Gallagher <sgallagh@redhat.com> PR-URL: #44642 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot
commented
Sep 26, 2022
Collaborator
Review requested:
|
This comment was marked as outdated.
This comment was marked as outdated.
This includes: - Fixing `writableStream.abort(reason)`. Passing the reason was missing. - Leaving a TODO to remove the internal abortReason property of WritableStreamDefaultController. Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: #44327 Refs: https://streams.spec.whatwg.org/#writable-stream-abort Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
PR-URL: #44222 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
PR-URL: #44427 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Currently, DebugSymbolsTest.ReqWrapList fails on PPC64LE when Node has been configured with Link Time Optimization (LTO) and using RHEL 8.5 and gcc: ```console $ . /opt/rh/gcc-toolset-11/enable $ export CC='ccache gcc' $ export CXX='ccache g++' $ ./configure --enable-lto $ make -j8 cctest ... 21:52:27 [ RUN ] DebugSymbolsTest.ReqWrapList 21:52:27 ../test/cctest/test_node_postmortem_metadata.cc:203: Failure 21:52:27 Expected equality of these values: 21:52:27 expected 21:52:27 Which is: 140736537072320 21:52:27 calculated 21:52:27 Which is: 1099680328560 21:52:27 [ FAILED ] DebugSymbolsTest.ReqWrapList (43 ms) ``` After looking into this is seems that the compiler is tampering with the `last` variable when compiling with LTO enabled. This commit suggests adding volatile to this variable to prevent the compiler from tampering with it. PR-URL: #44341 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
PR-URL: #44472 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Explicitly document the attribute `Script.cachedDataRejected` in a dedicated section. Removes the documented option `produceCachedData` and the description of `cachedDataRejected` in `vm.runInContext`, `vm.runInNewContext`, and `vm.runInThisContext` as the created `vm.Script` instance is not accessible from userland in these methods. PR-URL: #44451 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Notable changes: - A bug has been fixed in `uvwasi_fd_readdir()` that caused the number of entries to be processed incorrectly. PR-URL: #44524 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
PR-URL: #44499 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
This was referenced Sep 27, 2022
RafaelGSS added a commit
that referenced
this pull request
Sep 27, 2022
Notable changes: doc: * (SEMVER-MINOR) deprecate modp1, modp2, and modp5 groups (Tobias Nießen) <#44588> gyp: * libnode for ios app embedding (chexiongsheng) <#44210> http: * (SEMVER-MINOR) throw error on content-length mismatch (sidwebworks) (<#44378>) stream: * (SEMVER-MINOR) add `ReadableByteStream.tee()` (Daeyeon Jeong) (<#44505>) PR-URL: #44799
RafaelGSSforce-pushed
the
v18.10.0-proposal
branch
from
September 27, 2022 15:18
ddfdae8 to
6c3a5c7Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
RafaelGSS
commented
Sep 27, 2022
MemberAuthor
@nodejs/build looks like our machines are running out of space. Could you help me with that? ref: https://ci.nodejs.org/job/node-test-commit-osx/nodes=osx1015/47624/testReport/junit/(root)/test/pummel_test_fs_largefile/ |
Notable changes: doc: * (SEMVER-MINOR) deprecate modp1, modp2, and modp5 groups (Tobias Nießen) <#44588> gyp: * libnode for ios app embedding (chexiongsheng) <#44210> http: * (SEMVER-MINOR) throw error on content-length mismatch (sidwebworks) (<#44378>) stream: * (SEMVER-MINOR) add `ReadableByteStream.tee()` (Daeyeon Jeong) (<#44505>) PR-URL: #44799
RafaelGSSforce-pushed
the
v18.10.0-proposal
branch
from
September 27, 2022 21:56
6c3a5c7 to
bdf069bCompareRafaelGSS
commented
Sep 27, 2022
MemberAuthor
FYI @nodejs/releasers I'm postponing the release to tomorrow due to #44799 (comment). |
Collaborator
Collaborator
13 tasks
RafaelGSS added a commit
that referenced
this pull request
Sep 28, 2022
Notable changes: doc: * (SEMVER-MINOR) deprecate modp1, modp2, and modp5 groups (Tobias Nießen) <#44588> gyp: * libnode for ios app embedding (chexiongsheng) <#44210> http: * (SEMVER-MINOR) throw error on content-length mismatch (sidwebworks) (<#44378>) stream: * (SEMVER-MINOR) add `ReadableByteStream.tee()` (Daeyeon Jeong) (<#44505>) PR-URL: #44799
RafaelGSS added a commit
to RafaelGSS/nodejs.org
that referenced
this pull request
Sep 28, 2022
RafaelGSS added a commit
to nodejs/nodejs.org
that referenced
this pull request
Sep 28, 2022
This was referenced Sep 29, 2022
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2022-09-27, Version 18.10.0 (Current), @RafaelGSS
Notable changes
doc:
gyp:
http:
stream:
ReadableByteStream.tee()(Daeyeon Jeong) (stream: addReadableByteStream.tee()#44505)Commits
Commits
6a2f1988a2] - benchmark: fix startup benchmark (Evan Lucas) #4472754870ea603] - benchmark: add stream destroy benchmark (SindreXie) #44533143abcb9ac] - bootstrap: clean up inspector console methods during serialization (Joyee Cheung) #442794ce6e2196c] - bootstrap: remove unused global parameter in per-context scripts (Joyee Cheung) #444722799157766] - build: remove redundant entry in crypto (Jiawen Geng) #446045c69813006] - build: rewritten the Android build system (BuShe Pie) #442073b808634a3] - Revert "build: go faster, drop -fno-omit-frame-pointer" (Ben Noordhuis) #445661315a83333] - build: fix bad upstream merge (Stephen Gallagher) #446424700ee5fc0] - (SEMVER-MINOR)cli: add--watch(Moshe Atlow) #443665eb48b66ea] - cluster: use inspector utils (Moshe Atlow) #4459226f25c9c80] - crypto: restrict PBKDF2 args to signed int (Tobias Nießen) #44575934cc9af11] - deps: update to ngtcp2 0.8.1 and nghttp3 0.7.0 (Tobias Nießen) #446227571c3a1a4] - deps: update corepack to 0.14.1 (Node.js GitHub Bot) #44704bc9403f4cd] - deps: update ngtcp2 update instructions (Tobias Nießen) #44619a1ed4fa601] - deps: upgrade npm to 8.19.2 (npm team) #44632f07d095928] - deps: update to uvwasi 0.0.13 (Colin Ihrig) #445247e0b9e150b] - dns: remove unnecessary parameter from validateOneOf (Yagiz Nizipli) #446350f232e9749] - dns: refactor default resolver (Joyee Cheung) #445418247d93b9c] - doc: mention git node backport (RafaelGSS) #447648b5333932d] - doc: ensure to revert node_version changes (Rafael Gonzaga) #44760dc7d90494d] - doc: fix description fornapi_get_cb_info()inn-api.md(Daeyeon Jeong) #447612dab3bd020] - doc: update the deprecation for exit code to clarify its scope (Daeyeon Jeong) #447142f99461152] - doc: update guidance for adding new modules (Michael Dawson) #44576e353bf7116] - doc: add registry number for Electron 22 (Keeley Hammond) #44748d537b61b5e] - doc: include code examples for webstreams consumers (Lucas Santos) #44387faa40c39af] - doc: mention where to push security commits (RafaelGSS) #4469148b1ad4059] - doc: remove extra space on threadpool usage (Connor Burton) #4473451f026a0d0] - doc: make legacy banner slightly less bright (Rich Trott) #4466531c19e3ef5] - doc: improve building doc for Windows Powershell (Brian Muenzenmeyer) #446253777582b64] - doc: maintain only one list of MODP groups (Tobias Nießen) #44644d9cdc392cf] - doc: add legendecas to TSC list (Michael Dawson) #44662fca3ee4eff] - doc: remove comma in README.md (Taha-Chaudhry) #445993214715df0] - doc: use serial comma in report docs (Daeyeon Jeong) #44608073f11eb24] - doc: use serial comma in stream docs (Daeyeon Jeong) #44609054b1d92cf] - doc: remove empty line in YAML block (Claudio Wunder) #4461770ccc5ea1f] - (SEMVER-MINOR)doc: deprecate modp1, modp2, and modp5 groups (Tobias Nießen) #445881c83824b01] - doc: remove old OpenSSL ENGINE constants (Tobias Nießen) #44589c76d182578] - doc: fix heading levels for test runner hooks (Fabian Meyer) #446034d6b46ea80] - doc: fix errors in http.md (Luigi Pinca) #4458710891e637f] - doc: fix vm.Script createCachedData example (Chengzhong Wu) #44487793855702d] - doc: mention how to get commit release (Rafael Gonzaga) #44572f47f1d518a] - doc: fix link inprocess.md(Antoine du Hamel) #44594eaa675d8b5] - doc: do not use weak MODP group in example (Tobias Nießen) #4458584934137ce] - doc: remove ebpf from supported tooling list (Rafael Gonzaga) #445498752854258] - doc: emphasize that createCipher is never secure (Tobias Nießen) #4453807af3f0f43] - doc: document attribute Script.cachedDataRejected (Chengzhong Wu) #4445159e3601ef3] - doc: move policy docs to the permissions scope (Rafael Gonzaga) #44222629324052e] - doc,crypto: cleanup removed pbkdf2 behaviours (Filip Skokan) #447337ffc037d63] - doc,inspector: document changes of inspector.close (Chengzhong Wu) #446288b54f01c52] - esm,loader: tidy ESMLoader internals (Jacob Smith) #44701ce085d753f] - fs: fix typo in mkdir example (SergeyTsukanov) #447910ccc17295e] - fs: remove unused option infs.fstatSync()(Livia Medeiros) #44613bbccebf451] - gyp: libnode for ios app embedding (chexiongsheng) #44210aaee9b1f1d] - (SEMVER-MINOR)http: throw error on content-length mismatch (sidwebworks) #443788b256a303a] - inspector: expose inspector.close on workers (Chengzhong Wu) #4448929e3e2c227] - lib: don't matchsourceMappingURLin strings (Alan Agius) #446581e137c2859] - lib: fix reference leak (falsandtru) #44499687ffcc3ce] - lib: resetRegExpstatics before running user code (Antoine du Hamel) #442479a432148a4] - lib,test: fix bug in InternalSocketAddress (Tobias Nießen) #446182a37f74e34] - meta: update AUTHORS (Node.js GitHub Bot) #44777dffc204959] - meta: add mailmap entry for dnlup (Rich Trott) #4471645b3bf3587] - meta: update AUTHORS (Node.js GitHub Bot) #447058e954fa843] - meta: move dnlup to emeriti (dnlup) #446674b0697e34c] - meta: update test_runner in label-pr-config (Shrujal Shah) #44615c0f5adc1ca] - meta: update AUTHORS (Node.js GitHub Bot) #44591ab5a304c67] - module: open stat/readPackage to mutations (Maël Nison) #44537b63315d140] - module: exports & imports map invalid slash deprecation (Guy Bedford) #44477ed1d634297] - node-api: add deprecation code of uncaught exception (Chengzhong Wu) #446247d9de70f4a] - src: avoid using v8 on Isolate termination (Santiago Gimeno) #4466915be38e98c] - src: remove <unistd.h> from node_os.cc (Tobias Nießen) #446688de484963d] - src: avoid copy when creating Blob (Tobias Nießen) #44616f4b620f83c] - src: make ReqWrap weak (Rafael Gonzaga) #4407499ad732f5b] - src: make NearHeapLimitCallback() more robust (Joyee Cheung) #44581bf77161c48] - src: dump isolate stats when process exits (daomingq) #44534e8101af459] - src: consolidate environment cleanup queue (Chengzhong Wu) #44379ce719290de] - stream: handle a pending pull request from a released reader (Daeyeon Jeong) #44702457673b0ac] - stream: refactor use es2020 statement (SindreXie) #4453300185f170a] - stream: removeabortReasonfromWritableStreamDefaultController(Daeyeon Jeong) #445404a77a11270] - (SEMVER-MINOR)stream: addReadableByteStream.tee()(Daeyeon Jeong) #445059f755e1d88] - stream: fixwritableStream.abort()(Daeyeon Jeong) #443273474cd870f] - test: verify napi_remove_wrap with napi_delete_reference (Chengzhong Wu) #44754fa315b7a5a] - test: change promises to async/await (Madhulika Sharma) #446830f8ce84005] - test: use async/await in test-debugger-invalid-args (Nupur Chauhan) #446781172498a82] - test: update test-debugger-low-level to use await/async (Meghana Ramesh) #4468816f85cc82f] - test: fix watch mode test flake (Moshe Atlow) #447397ed87538c3] - test: check that sysconf returns a positive value (Tobias Nießen) #44666dda556d002] - test: change promise to async/await in debugger-watcher (“Pooja) #446878acb425de1] - test: fix addon tests compilation with OpenSSL 1.1.1 (Adam Majer) #447256606a111bd] - test: deflake watch mode tests (Moshe Atlow) #44621792040269a] - test: fix test-performance-measure (smitley) #44637fcfdb6c31e] - test: improve lib/readline.js coverage (MURAKAMI Masahiko) #426862618ccb8f8] - test: fixtest-replnot validating leaked globals properly (Antoine du Hamel) #44640938751be43] - test: fix test-runner-inspect (Moshe Atlow) #44620353cd846e6] - test: ignore stale process cleanup failures on Windows (Joyee Cheung) #4448035f55ae6bb] - test: use python3 instead of python (Luigi Pinca) #4454590a98a657a] - test: split watch mode inspector tests to sequential (Moshe Atlow) #445511b2b0a318a] - test: fix DebugSymbolsTest.ReqWrapList on PPC64LE (Daniel Bevenius) #44341ed64119ca8] - test: add more cases for parse-encoding (Tony Gorez) #44427a28ae1656f] - test_runner: include stack of uncaught exceptions (Moshe Atlow) #44614603eb54743] - test_runner: support using--inspectwith--test(Moshe Atlow) #4452042225c38a4] - tls: fix out-of-bounds read in ClientHelloParser (Tobias Nießen) #445802dbc1f8b15] - tools: add update-llhttp.sh (Paolo Insogna) #446522ad225787f] - tools: fix typo in update-nghttp2.sh (Luigi Pinca) #446642e77644d6b] - tools: add timezone update workflow (Lenvin Gonsalves) #43988bdea068dc9] - tools: update eslint to 8.23.1 (Node.js GitHub Bot) #44639efbd18a51b] - tools: update lint-md-dependencies to @rollup/plugin-node-resolve@14.1.0 (Node.js GitHub Bot) #44638d31ea02a01] - tools: update gyp-next to v0.13.0 (Jiawen Geng) #44605570b099a83] - tools: update lint-md-dependencies to @rollup/plugin-node-resolve@14.0.1 (Node.js GitHub Bot) #44590730b8ce059] - tools: increase timeout of running WPT (Joyee Cheung) #44574d265bf04f8] - tools: fix shebang to use python3 by default (Himself65) #4453190e8977a2f] - v8: add setHeapSnapshotNearHeapLimit (theanarkh) #444202d87b6ffa0] - win: fix fs.realpath.native for long paths (StefanStojanovic) #44536