Skip to content

test: remove unused variables from net tests - #4430

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:rm-unused-net
Closed

test: remove unused variables from net tests#4430
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:rm-unused-net

Conversation

@Trott

Copy link
Copy Markdown
Member

No description provided.

@TrottTrott added net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests. labels Dec 26, 2015
@Trott

Copy link
Copy Markdown
MemberAuthor

@targos

Copy link
Copy Markdown
Member

LGTM

1 similar comment
@cjihrig

Copy link
Copy Markdown
Contributor

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Dec 29, 2015
Remove a handful of variables that are declared but never used in the
tests for the net module.
PR-URL: nodejs#4430
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott

Copy link
Copy Markdown
MemberAuthor

Landed in 1762db0

@TrottTrott closed this Dec 29, 2015
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Jan 6, 2016
Remove a handful of variables that are declared but never used in the
tests for the net module.
PR-URL: nodejs#4430
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Jan 14, 2016
Remove a handful of variables that are declared but never used in the
tests for the net module.
PR-URL: nodejs#4430
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
Remove a handful of variables that are declared but never used in the
tests for the net module.
PR-URL: #4430
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Jan 19, 2016
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
Remove a handful of variables that are declared but never used in the
tests for the net module.
PR-URL: nodejs#4430
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott
Trott deleted the rm-unused-net branch January 13, 2022 22:31
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

netIssues and PRs related to the net subsystem.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Trott@targos@cjihrig@MylesBorins