LTS: backport no-unused-vars to v4.x-staging by MylesBorins · Pull Request #4688 · nodejs/node

MylesBorins · 2016-01-14T09:32:19Z

replaces: #4683 and #4684

Backport all changes to get LTS v4.x-staging passing the linter with no-unused-vars enabled. This involved backporting commits from 10 different PRs':

MylesBorins · 2016-01-14T09:32:47Z

/cc @Trott @jasnell

MylesBorins · 2016-01-14T09:35:48Z

There was a big combination of weird things going on getting this to backport nicely. Some commits that were part of this large change landed in LTS a week ago. Other commits landed, but with conflicts, others were not tagged for LTS and were just missed.

I'd be very interested to discuss ways we can co-ordinate moving large changes like this to LTS more efficiently. As branches diverge this kind of stuff is going to get more and more difficult.

MylesBorins · 2016-01-14T09:36:34Z

CI: https://ci.nodejs.org/job/node-test-pull-request/1231/

Trott · 2016-01-14T15:52:53Z

Ci failure for test-cluster-disconnect-race is of concern only if #4457 and #4465 have both landed in 4.x-staging. If not, then that issue should be fixed when those land.

In terms of how to prevent this in the future, the obvious things that leap to mind are:

More process. I suspect this is a bad idea as it will probably just make the whole thing more confusing and error-prone. For example, we could add some more tagging to note commits/PRs that depend on other commits/PRs. I don't think that will actually work, to be honest, but there's one possibility.
Bundling of things into mega-commits rather than individual small commits. This is an anti-pattern.
Bundling things into mega-PRs (with lots of small commits) rather than individual small PRs. Makes things harder to review and would probably greatly slow velocity.
More automation. This seems like the best idea but probably by far the hardest to implement. Straw proposal: Everything that lands on master would be tagged semver-patch, semver-minor, or semver-major. The semver-patch stuff would be merged to v4.x-staging automatically and in the same order that it landed on master. We'd need the CI in solid shape so the automated job could depend on it. There'd still be a lot of manual work when stuff didn't land cleanly (because a semver-patch depends on a previous semver-minor, for example) but that's work we do manually today anyway.

If the automation idea is appealing, maybe we can open a discussion over in the nodejs/build repo? Although I imagine getting the node-accept-pull-request job working again would be a necessary pre-requisite. (We're close, I think.)

Trott · 2016-01-14T15:53:24Z

(Also: Nice work, @thealphanerd!)

MylesBorins · 2016-01-14T19:15:44Z

I backported #4457 and rebased against it. #4465 will likely come in next release as it only was just released in v5.4.1

CI: https://ci.nodejs.org/job/node-test-pull-request/1235/

Many tests use require() to import modules that subsequently never gets used. This removes those imports and, in a few cases, removes other unused variables from tests. PR-URL: nodejs#4684 Reviewed-By: Myles Borins <mborins@us.ibm.com>

Some files in `lib` were using `require` to load modules that were subsequently not used in the file. This removes those `require` statements. PR-URL: nodejs#4683 Reviewed-By: Myles Borins <mborins@us.ibm.com>

Remove unused vars in tests PR-URL: nodejs#4536 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

In addition to removing unused vars, this also fixes an instance where booleans were set presumably to check something but then never used. This now confirms that the events that were setting the booleans are fired. PR-URL: nodejs#4425 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Remove a handful of variables that are declared but never used in the tests for the net module. PR-URL: nodejs#4430 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

PR-URL: nodejs#4426 Reviewed-By: Johan Bergström <bugs@bergstroem.nu>

Some of the TLS tests have variables that do not get used. This removes those variables. PR-URL: nodejs#4424 Reviewed-By: Johan Bergström <bugs@bergstroem.nu>

Debug mode slows execution speed. There is work afoot to enable Debug mode runs on the continuous integration infrastructure for the project. Some tests are timing out, such as test-net-nodejsGH-5504.js. This change doubles the timeout returned from `common.platformTimeout()` when running in Debug mode. It also removes an unused variable from the aforementioned test-net-nodejsGH-5504.js. PR-URL: nodejs#4431 Reviewed-By: Johan Bergström <bugs@bergstroem.nu>

The http tests seem especially prone to including unused variables. This change removes them. PR-URL: nodejs#4422 Reviewed-By: Johan Bergström <bugs@bergstroem.nu>

Remove all remaining unused variables from tests in test/parallel. PR-URL: nodejs#4511 Reviewed-By: James M Snell<jasnell@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>

PR-URL: nodejs#4536 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins · 2016-01-14T20:03:09Z

CI against current head
https://ci.nodejs.org/job/node-test-pull-request/1238/

MylesBorins · 2016-01-14T21:21:30Z

CI Failures look unrelated. @jasnell are we good to land this?

jasnell · 2016-01-14T23:28:38Z

LGTM

MylesBorins · 2016-01-14T23:35:34Z

landed

This was referenced Jan 14, 2016
test: remove unused modules #4684
Closed
lib: remove unused modules #4683
Closed

This was referenced Jan 14, 2016
test: remove unused vars from parallel tests #4511
Closed
tools,test: enable eslint no-unused-vars #4536
Closed

mscdex added the test Issues and PRs related to the tests. label Jan 14, 2016

MylesBorins force-pushed the sorry-rich branch from e87190d to 6d34289Compare January 14, 2016 19:13

MylesBorins force-pushed the v4.x-staging branch from 592237f to cf7ebd3Compare January 14, 2016 19:49

MylesBorins force-pushed the sorry-rich branch from 6d34289 to d7e2943Compare January 14, 2016 19:49

Trott added 11 commits January 14, 2016 12:00

test: remove unused modules
dba3dc5
Many tests use require() to import modules that subsequently never gets used. This removes those imports and, in a few cases, removes other unused variables from tests. PR-URL: nodejs#4684 Reviewed-By: Myles Borins <mborins@us.ibm.com>

lib: remove unused modules
46e3fd6
Some files in `lib` were using `require` to load modules that were subsequently not used in the file. This removes those `require` statements. PR-URL: nodejs#4683 Reviewed-By: Myles Borins <mborins@us.ibm.com>

test: remove unused vars
7894f19
Remove unused vars in tests PR-URL: nodejs#4536 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

test: remove unused variables from net tests
8c094be
Remove a handful of variables that are declared but never used in the tests for the net module. PR-URL: nodejs#4430 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

test: remove unused variables from HTTPS tests
ba1847d
PR-URL: nodejs#4426 Reviewed-By: Johan Bergström <bugs@bergstroem.nu>

test: remove unused variables from TLS tests
7c30944
Some of the TLS tests have variables that do not get used. This removes those variables. PR-URL: nodejs#4424 Reviewed-By: Johan Bergström <bugs@bergstroem.nu>

test: remove unused variables form http tests
eb53af2
The http tests seem especially prone to including unused variables. This change removes them. PR-URL: nodejs#4422 Reviewed-By: Johan Bergström <bugs@bergstroem.nu>

test: remove unused vars from parallel tests
b3b150c
Remove all remaining unused variables from tests in test/parallel. PR-URL: nodejs#4511 Reviewed-By: James M Snell<jasnell@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>

tools: implement no-unused-vars for eslint
ef5e9ef
PR-URL: nodejs#4536 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins force-pushed the sorry-rich branch from d7e2943 to ef5e9efCompare January 14, 2016 20:01

MylesBorins merged commit ef5e9ef into nodejs:v4.x-stagingJan 14, 2016

MylesBorins deleted the sorry-rich branch January 21, 2016 22:59

MylesBorins added the lts-landed-on-v4.x label Mar 10, 2016

Navigation Menu

Uh oh!

Uh oh!

LTS: backport no-unused-vars to v4.x-staging - #4688

LTS: backport no-unused-vars to v4.x-staging#4688
MylesBorins merged 11 commits into
nodejs:v4.x-stagingfrom
MylesBorins:sorry-rich

MylesBorins commented Jan 14, 2016

Uh oh!

MylesBorins commented Jan 14, 2016

Uh oh!

MylesBorins commented Jan 14, 2016

Uh oh!

MylesBorins commented Jan 14, 2016

Uh oh!

Trott commented Jan 14, 2016

Uh oh!

Trott commented Jan 14, 2016

Uh oh!

MylesBorins commented Jan 14, 2016

Uh oh!

MylesBorins commented Jan 14, 2016

Uh oh!

MylesBorins commented Jan 14, 2016

Uh oh!

jasnell commented Jan 14, 2016

Uh oh!

MylesBorins commented Jan 14, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

MylesBorins commented Jan 14, 2016

Uh oh!

MylesBorins commented Jan 14, 2016

Uh oh!

MylesBorins commented Jan 14, 2016

Uh oh!

MylesBorins commented Jan 14, 2016

Uh oh!

Trott commented Jan 14, 2016

Uh oh!

Trott commented Jan 14, 2016

Uh oh!

MylesBorins commented Jan 14, 2016

Uh oh!

MylesBorins commented Jan 14, 2016

Uh oh!

MylesBorins commented Jan 14, 2016

Uh oh!

jasnell commented Jan 14, 2016

Uh oh!

MylesBorins commented Jan 14, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants