Skip to content

src: consolidate environment cleanup queue - #44379

Closed
legendecas wants to merge 1 commit into
nodejs:mainfrom
legendecas:shadow-realm/cleanup-callbacks
Closed

src: consolidate environment cleanup queue#44379
legendecas wants to merge 1 commit into
nodejs:mainfrom
legendecas:shadow-realm/cleanup-callbacks

Conversation

@legendecas

@legendecaslegendecas commented Aug 24, 2022

Copy link
Copy Markdown
Member

Each Realm tracks its own cleanup hooks and drains the hooks when it is
going to be destroyed.

Moves the implementations of the cleanup queue to its own class so that
it can be used in node::Realm too.

Refs: #44348
Refs: #42528

@nodejs-github-bot

nodejs-github-bot commented Aug 24, 2022•
edited by legendecas
Loading

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/startup

@legendecas
legendecasforce-pushed the shadow-realm/cleanup-callbacks branch from 885ed6c to d0e5fe4CompareAugust 24, 2022 18:02
@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Aug 24, 2022
@legendecaslegendecas mentioned this pull request Aug 25, 2022
Closed
@legendecas
legendecasforce-pushed the shadow-realm/cleanup-callbacks branch from d0e5fe4 to b712fb6CompareAugust 28, 2022 17:26
@legendecaslegendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 29, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 29, 2022
@nodejs-github-bot

nodejs-github-bot commented Aug 29, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46303/

joyeecheung
joyeecheung reviewed Aug 30, 2022
View reviewed changes
Comment threadsrc/cleanup_queue.h Outdated
Comment threadsrc/cleanup_queue-inl.h Outdated
@github-actionsgithub-actionsBot mentioned this pull request Aug 31, 2022
Open
30 tasks
@legendecas
legendecasforce-pushed the shadow-realm/cleanup-callbacks branch from b712fb6 to 0e48bdfCompareAugust 31, 2022 16:30
This was referenced Sep 1, 2022
Open
Open
@legendecaslegendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 2, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 2, 2022
@nodejs-github-bot

nodejs-github-bot commented Sep 2, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46383/

This was referenced Sep 3, 2022
Open
Open
Open
@nodejs-github-bot

nodejs-github-bot commented Sep 5, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46418/

joyeecheung
joyeecheung reviewed Sep 5, 2022
View reviewed changes
Comment threadsrc/cleanup_queue-inl.h Outdated
@legendecas
src: consolidate environment cleanup queue
60e285a
Each Realm tracks its own cleanup hooks and drains the hooks when it is
going to be destroyed.
Moves the implementations of the cleanup queue to its own class so that
it can be used in `node::Realm` too.
@legendecas
legendecasforce-pushed the shadow-realm/cleanup-callbacks branch from 0e48bdf to 60e285aCompareSeptember 5, 2022 16:06
@github-actionsgithub-actionsBot mentioned this pull request Sep 6, 2022
Open
17 tasks
@legendecaslegendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 6, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 6, 2022
@nodejs-github-bot

nodejs-github-bot commented Sep 6, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46435/

@github-actionsgithub-actionsBot mentioned this pull request Sep 7, 2022
Open
15 tasks
@legendecas

legendecas commented Sep 7, 2022

Copy link
Copy Markdown
MemberAuthor

Landed in 0b5b5ed. Thank you for the review!

legendecas added a commit that referenced this pull request Sep 7, 2022
@legendecas
src: consolidate environment cleanup queue
0b5b5ed
Each Realm tracks its own cleanup hooks and drains the hooks when it is
going to be destroyed.
Moves the implementations of the cleanup queue to its own class so that
it can be used in `node::Realm` too.
PR-URL: #44379
Refs: #44348
Refs: #42528
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@legendecas
legendecas deleted the shadow-realm/cleanup-callbacks branch September 7, 2022 16:07
@legendecaslegendecas mentioned this pull request Sep 7, 2022
Closed
@github-actionsgithub-actionsBot mentioned this pull request Sep 8, 2022
Open
12 tasks
RafaelGSS pushed a commit that referenced this pull request Sep 26, 2022
@legendecas@RafaelGSS
src: consolidate environment cleanup queue
e8101af
Each Realm tracks its own cleanup hooks and drains the hooks when it is
going to be destroyed.
Moves the implementations of the cleanup queue to its own class so that
it can be used in `node::Realm` too.
PR-URL: #44379
Refs: #44348
Refs: #42528
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Sep 26, 2022
Merged
RafaelGSS pushed a commit that referenced this pull request Sep 26, 2022
@legendecas@RafaelGSS
src: consolidate environment cleanup queue
6878448
Each Realm tracks its own cleanup hooks and drains the hooks when it is
going to be destroyed.
Moves the implementations of the cleanup queue to its own class so that
it can be used in `node::Realm` too.
PR-URL: #44379
Refs: #44348
Refs: #42528
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@legendecaslegendecas added the realm Issues and PRs related to the ShadowRealm API and node::Realm label Dec 26, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joyeecheungjoyeecheungjoyeecheung approved these changes

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.lib / srcIssues and PRs related to general changes in the lib or src directory.needs-ciPRs that need a full CI run.realmIssues and PRs related to the ShadowRealm API and node::Realm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@legendecas@nodejs-github-bot@joyeecheung