Uh oh!
There was an error while loading. Please reload this page.
bootstrap: generate bootstrapper arguments in BuiltinLoader - #44488
Merged
Conversation
joyeecheung
marked this pull request as ready for review
September 2, 2022 06:29
nodejs-github-bot
commented
Sep 2, 2022
Collaborator
Review requested:
|
legendecas
left a comment
Member
There was a problem hiding this comment.
The change LGTM, but the linter is complaining...
joyeecheungforce-pushed
the
compile-arg
branch
from
September 6, 2022 12:45
3ad93cc to
a4c8645Comparejoyeecheung
commented
Sep 6, 2022
MemberAuthor
Rebased and fixed the linter error. |
nodejs-github-bot
commented
Sep 6, 2022
Collaborator
joyeecheungforce-pushed
the
compile-arg
branch
from
September 6, 2022 12:46
a4c8645 to
501fee7Comparenodejs-github-bot
commented
Sep 6, 2022
Collaborator
nodejs-github-bot
commented
Sep 6, 2022
Collaborator
legendecas
approved these changes
Sep 6, 2022
15 tasks
This was referenced Sep 8, 2022
nodejs-github-bot
commented
Sep 12, 2022
Collaborator
nodejs-github-bot
commented
Sep 12, 2022
Collaborator
30 tasks
nodejs-github-bot
commented
Sep 13, 2022
Collaborator
Landed in 7850802 |
28 tasks
29 tasks
23 tasks
RafaelGSS
commented
Sep 26, 2022
Member
Hi @joyeecheung. This commit didn't land cleanly on v18.x. Could you please backport? |
juanarbol
commented
Oct 3, 2022
Member
The builtins thing did not land well in the v16.x release line (#44135); marking this as backport-blocked for the v16.x branch. |
targos pushed a commit
that referenced
this pull request
Oct 29, 2023
PR-URL: #44488 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
sercher added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#44488 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
sercher added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#44488 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First commit comes from #44472