src: define per-isolate internal bindings registration callback by legendecas · Pull Request #45547 · nodejs/node

legendecas · 2022-11-20T17:29:47Z

Bindings that need to be loaded in distinct contexts of node::Realm in
the same node::Environment instance needs to share the per-isolate
templates.

Add a new binding registration callback, which is called with
per-IsolateData. This allows bindings to define templates and
share them across realms eagerly, and avoid accidental modification on
the templates when the per-context callback is called multiple times.

This also tracks loaded bindings and built-in modules with node::Realm.

Refs: #42528

nodejs-github-bot · 2022-11-20T17:29:51Z

Review requested:

@nodejs/startup

joyeecheung

LGTM with a nit

legendecas · 2022-12-15T09:35:07Z

@nodejs/realm PTAL, thank you!

Bindings that need to be loaded in distinct contexts of node::Realm in the same node::Environment instance needs to share the per-isolate templates. Add a new binding registration callback, which is called with per-IsolateData. This allows bindings to define templates and share them across realms eagerly, and avoid accidental modification on the templates when the per-context callback is called multiple times. This also tracks loaded bindings and built-in modules with node::Realm.

Create worker binding templates in the per-isolate initialization.

nodejs-github-bot · 2022-12-19T18:07:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/48603/

nodejs-github-bot · 2022-12-20T02:34:01Z

CI: https://ci.nodejs.org/job/node-test-pull-request/48619/

Bindings that need to be loaded in distinct contexts of node::Realm in the same node::Environment instance needs to share the per-isolate templates. Add a new binding registration callback, which is called with per-IsolateData. This allows bindings to define templates and share them across realms eagerly, and avoid accidental modification on the templates when the per-context callback is called multiple times. This also tracks loaded bindings and built-in modules with node::Realm. PR-URL: #45547 Refs: #42528 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Create worker binding templates in the per-isolate initialization. PR-URL: #45547 Refs: #42528 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

legendecas · 2022-12-28T04:20:31Z

Landed in 796c4f9...8dfd905

Bindings that need to be loaded in distinct contexts of node::Realm in the same node::Environment instance needs to share the per-isolate templates. Add a new binding registration callback, which is called with per-IsolateData. This allows bindings to define templates and share them across realms eagerly, and avoid accidental modification on the templates when the per-context callback is called multiple times. This also tracks loaded bindings and built-in modules with node::Realm. PR-URL: #45547 Refs: #42528 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Create worker binding templates in the per-isolate initialization. PR-URL: #45547 Refs: #42528 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Bindings that need to be loaded in distinct contexts of node::Realm in the same node::Environment instance needs to share the per-isolate templates. Add a new binding registration callback, which is called with per-IsolateData. This allows bindings to define templates and share them across realms eagerly, and avoid accidental modification on the templates when the per-context callback is called multiple times. This also tracks loaded bindings and built-in modules with node::Realm. PR-URL: #45547 Refs: #42528 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Create worker binding templates in the per-isolate initialization. PR-URL: #45547 Refs: #42528 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Bindings that need to be loaded in distinct contexts of node::Realm in the same node::Environment instance needs to share the per-isolate templates. Add a new binding registration callback, which is called with per-IsolateData. This allows bindings to define templates and share them across realms eagerly, and avoid accidental modification on the templates when the per-context callback is called multiple times. This also tracks loaded bindings and built-in modules with node::Realm. PR-URL: #45547 Refs: #42528 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Create worker binding templates in the per-isolate initialization. PR-URL: #45547 Refs: #42528 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

juanarbol · 2023-01-24T15:49:37Z

This is not landing cleanly in the v18.x line 💔

legendecas · 2023-01-28T13:57:50Z

Backport to v18.x depends on #46336.

legendecas · 2023-05-23T17:26:45Z

Backport to v18.x depends on #44488.

Bindings that need to be loaded in distinct contexts of node::Realm in the same node::Environment instance needs to share the per-isolate templates. Add a new binding registration callback, which is called with per-IsolateData. This allows bindings to define templates and share them across realms eagerly, and avoid accidental modification on the templates when the per-context callback is called multiple times. This also tracks loaded bindings and built-in modules with node::Realm. PR-URL: #45547 Refs: #42528 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Bindings that need to be loaded in distinct contexts of node::Realm in the same node::Environment instance needs to share the per-isolate templates. Add a new binding registration callback, which is called with per-IsolateData. This allows bindings to define templates and share them across realms eagerly, and avoid accidental modification on the templates when the per-context callback is called multiple times. This also tracks loaded bindings and built-in modules with node::Realm. PR-URL: nodejs/node#45547 Refs: nodejs/node#42528 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Nov 20, 2022

legendecas force-pushed the shadow-realm/per-realm-binding branch from d115a82 to c24d797Compare November 22, 2022 07:43

legendecas changed the title ~~src: define realm-aware internal bindings~~src: define per-isolate internal bindings registration callbackNov 22, 2022

legendecas force-pushed the shadow-realm/per-realm-binding branch 2 times, most recently from 06e2c24 to bbecbcdCompare November 22, 2022 07:52

legendecas marked this pull request as ready for review November 22, 2022 17:26

legendecas force-pushed the shadow-realm/per-realm-binding branch from bbecbcd to 6311182Compare November 22, 2022 17:42

joyeecheung reviewed Nov 24, 2022
View reviewed changes

Comment threadsrc/env-inl.h Outdated
Comment threadsrc/node_binding.cc Outdated
Comment threadsrc/node_builtins.cc Outdated

legendecas force-pushed the shadow-realm/per-realm-binding branch 2 times, most recently from f762397 to e07122bCompare November 29, 2022 18:01

joyeecheung reviewed Dec 2, 2022
View reviewed changes

Comment threadsrc/node_binding.cc Outdated
Comment threadsrc/node_worker.cc Outdated
Comment threadsrc/node_builtins.cc Outdated

legendecas force-pushed the shadow-realm/per-realm-binding branch from e07122b to 0dc40adCompare December 6, 2022 14:52

joyeecheung approved these changes Dec 14, 2022
View reviewed changes

Comment threadsrc/util.cc Outdated

cjihrig approved these changes Dec 15, 2022
View reviewed changes

Comment threadsrc/node_binding.cc Outdated
Comment threadsrc/node_binding.h Outdated

jasnell approved these changes Dec 19, 2022
View reviewed changes

legendecas added 2 commits December 20, 2022 01:50

src: add worker per-isolate binding initialization
f264321
Create worker binding templates in the per-isolate initialization.

legendecas force-pushed the shadow-realm/per-realm-binding branch from 0dc40ad to f264321Compare December 19, 2022 18:02

legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2022

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2022

github-actionsBot mentioned this pull request Dec 20, 2022
CI Reliability 2022-12-20 nodejs/reliability#463
Open
14 tasks

This was referenced Dec 21, 2022
CI Reliability 2022-12-21 nodejs/reliability#464
Open
CI Reliability 2022-12-22 nodejs/reliability#465
Open

legendecas mentioned this pull request Dec 22, 2022
Adding realm label to nodejs/node repo nodejs/admin#760
Closed

legendecas added the realm Issues and PRs related to the ShadowRealm API and node::Realm label Dec 26, 2022

legendecas closed this Dec 28, 2022

legendecas deleted the shadow-realm/per-realm-binding branch December 28, 2022 04:20

RafaelGSS mentioned this pull request Jan 2, 2023
v19.4.0 proposal #46061
Merged

juanarbol added the backport-requested-v18.x label Jan 24, 2023

targos mentioned this pull request Nov 28, 2023
v18.19.0 release proposal #50953
Merged

Uh oh!

Uh oh!

Conversation

legendecas commented Nov 20, 2022

Uh oh!

nodejs-github-bot commented Nov 20, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joyeecheung left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

legendecas commented Dec 15, 2022

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Dec 19, 2022

Uh oh!

nodejs-github-bot commented Dec 20, 2022

Uh oh!

legendecas commented Dec 28, 2022

Uh oh!

juanarbol commented Jan 24, 2023

Uh oh!

legendecas commented Jan 28, 2023

Uh oh!

legendecas commented May 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants