Skip to content

[v18.x backport] cli: add --watch - #44571

Closed
MoLow wants to merge 1 commit into
nodejs:v18.x-stagingfrom
MoLow:backport-watch-mode
Closed

[v18.x backport] cli: add --watch#44571
MoLow wants to merge 1 commit into
nodejs:v18.x-stagingfrom
MoLow:backport-watch-mode

Conversation

@MoLow

@MoLowMoLow commented Sep 8, 2022•
edited
Loading

Copy link
Copy Markdown
Member

backport of #44366 with a fix for tests to skip --import

@nodejs-github-bot

nodejs-github-bot commented Sep 8, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/modules
  • @nodejs/startup

@nodejs-github-botnodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v18.x labels Sep 8, 2022
@joyeecheungjoyeecheung mentioned this pull request Sep 8, 2022
Closed
@aduh95

aduh95 commented Sep 8, 2022

Copy link
Copy Markdown
Contributor

Can you removed the (cherry picked from commit …) in the commit message? It is probably appended because you used the -x flag of git cherry-pick, but we don't want it in the nodejs/node repo (ncu will take care of appending the correct metadata).

@MoLow

MoLow commented Sep 8, 2022

Copy link
Copy Markdown
MemberAuthor

Can you removed the (cherry picked from commit …) in the commit message? It is probably appended because you used the -x flag of git cherry-pick, but we don't want it in the nodejs/node repo (ncu will take care of appending the correct metadata).

done

@MoLow
MoLowforce-pushed the backport-watch-mode branch from 65e2c00 to 3a66d6fCompareSeptember 8, 2022 15:29
@MoLow

MoLow commented Sep 11, 2022

Copy link
Copy Markdown
MemberAuthor

@aduh95 what is the procedure of landing this into v18.x-staging?

@MoLowMoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 11, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 11, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@aduh95

aduh95 commented Sep 11, 2022

Copy link
Copy Markdown
Contributor

@aduh95 what is the procedure of landing this into v18.x-staging?

I know the rule for LTS is to leave it to the appropriate team:

node/doc/contributing/collaborator-guide.md

Lines 768 to 769 in 3ec8876

Only members of @nodejs/backporters should land commits onto LTS staging
branches.

As v18.x is not (yet) LTS, the rule might be different, but I would leave it up to @nodejs/releasers to leave them full control over the release process.

@nodejs-github-bot

nodejs-github-bot commented Sep 11, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46518/

This was referenced Sep 12, 2022
Open
Open
Open
Open
RafaelGSS
RafaelGSS reviewed Sep 15, 2022
View reviewed changes

@RafaelGSSRafaelGSS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MoLow can you include the metadata to your commit according to item 9 of https://github.com/nodejs/node/blob/main/doc/contributing/backporting-to-release-lines.md guideline?

@aduh95

aduh95 commented Sep 15, 2022

Copy link
Copy Markdown
Contributor

can you include the metadata to your commit according to item 9 of https://github.com/nodejs/node/blob/main/doc/contributing/backporting-to-release-lines.md guideline?

@RafaelGSS isn't that done by ncu upon landing?

@MoLow
cli: add --watch
3a6c65b
PR-URL: nodejs#44366
Backport-PR-URL: nodejs#44571Fixes: nodejs#40429
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@MoLow

MoLow commented Sep 15, 2022

Copy link
Copy Markdown
MemberAuthor

@RafaelGSS added metadata and squashed - as discussed in slack

@MoLowMoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 15, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 15, 2022
@nodejs-github-bot

nodejs-github-bot commented Sep 15, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46611/

@github-actionsgithub-actionsBot mentioned this pull request Sep 16, 2022
Open
23 tasks
@nodejs-github-bot

nodejs-github-bot commented Sep 16, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46618/

RafaelGSS
RafaelGSS approved these changes Sep 16, 2022
View reviewed changes

@RafaelGSSRafaelGSS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This was referenced Sep 17, 2022
Open
Open
Open
Open
@RafaelGSS

RafaelGSS commented Sep 23, 2022

Copy link
Copy Markdown
Member

Landed in 4700ee5

RafaelGSS pushed a commit that referenced this pull request Sep 23, 2022
@MoLow@RafaelGSS
cli: add --watch
4700ee5
PR-URL: #44366
Backport-PR-URL: #44571Fixes: #40429
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Sep 26, 2022
Merged
@RafaelGSSRafaelGSS reopened this Sep 27, 2022
@RafaelGSS

RafaelGSS commented Sep 27, 2022

Copy link
Copy Markdown
Member

It didn't land cleanly on the proposal branch. Can you please rebase and run the CI again? See #44799 (comment)

@MoLow

MoLow commented Sep 29, 2022

Copy link
Copy Markdown
MemberAuthor

@RafaelGSS the cause was a merge mess up resulting with both test/parallel/test-watch-mode.mjs and test/sequential/test-watch-mode.mjs in nodejs:v18.x-staging when only one should have existed. I will create a new backport PR with all the relevant commits in a single PR

@MoLowMoLow closed this Sep 29, 2022
@MoLow
MoLow deleted the backport-watch-mode branch September 29, 2022 08:38
@MoLowMoLow added the watch-mode Issues and PRs related to watch mode label Oct 18, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JungMinuJungMinuJungMinu approved these changes
@aduh95aduh95aduh95 approved these changes
@RafaelGSSRafaelGSSRafaelGSS approved these changes

Assignees

No one assigned

Labels

lib / srcIssues and PRs related to general changes in the lib or src directory.needs-ciPRs that need a full CI run.watch-modeIssues and PRs related to watch mode

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MoLow@nodejs-github-bot@aduh95@RafaelGSS@JungMinu