Uh oh!
There was an error while loading. Please reload this page.
deps: update OpenSSL 3.0.8+quic - #46570
Closed
RafaelGSS wants to merge 3 commits into
Closed
Conversation
This updates all sources in deps/openssl/openssl by: $ git clone git@github.com:quictls/openssl.git $ cd openssl $ git checkout openssl-3.0.8+quic $ cd ../node/deps/openssl $ rm -rf openssl $ cp -R ../../../openssl openssl $ rm -rf openssl/.git* openssl/.travis* $ git add --all openssl $ git commit openssl
This comment was marked as outdated.
This comment was marked as outdated.
richardlau
commented
Feb 8, 2023
Member
The Windows on ARM64 failure is an upstream OpenSSL bug on all the new OpenSSL releases. The 32-bit Windows x86 failure is something we hit before -- I think we were floating a patch for it on top of OpenSSL? |
richardlau
commented
Feb 8, 2023
Member
There's a note about 32-bit Windows in https://github.com/nodejs/node/blob/main/doc/contributing/maintaining-openssl.md#2-execute-make-in-depsopensslconfig-directory |
jasnell
approved these changes
Feb 9, 2023
nodejs-github-bot
commented
Feb 10, 2023
Collaborator
RafaelGSSforce-pushed
the
openssl-3.0.8+quic
branch
from
February 11, 2023 22:08
c05532a to
aeeafb7Comparenodejs-github-bot
commented
Feb 11, 2023
Collaborator
richardlau
commented
Feb 12, 2023
Member
@RafaelGSS Looks like something has gone awry with the config generation for this PR. "/Users/runner/work/node/node/deps/openssl/openssl/include/openssl/opensslconf.h:14:11: fatal error: 'openssl/configuration.h' file not found\n" + '# include <openssl/configuration.h>\n' + ' ^~~~~~~~~~~~~~~~~~~~~~~~~\n' + '1 error generated.\n' + |
After an OpenSSL source update, all the config files need to be regenerated and committed by: $ make -C deps/openssl/config $ git add deps/openssl/config/archs $ git add deps/openssl/openssl $ git commit
Original commit message: rsa: add msvc intrinsic for non x64 platforms _umul128() is x86_64 (x64) only, while __umulh() works everywhere, but doesn't generate optimal code on x64 Refs: openssl/openssl#20244
RafaelGSSforce-pushed
the
openssl-3.0.8+quic
branch
from
February 13, 2023 14:18
aeeafb7 to
8dc2d94Comparenodejs-github-bot
commented
Feb 13, 2023
Collaborator
nodejs-github-bot
commented
Feb 13, 2023
Collaborator
richardlau
approved these changes
Feb 13, 2023
nodejs-github-bot
commented
Feb 13, 2023
Collaborator
RafaelGSS
commented
Feb 16, 2023
MemberAuthor
Landed in f369c0a...9f468cc |
MylesBorins
commented
Feb 20, 2023
Contributor
This doesn't land cleanly on v19.x, If this is supposed to land can someone please backport |
richardlau
commented
Feb 20, 2023
Member
This landed in v19.x via #46573 as part of the recent security releases. |
targos
commented
Mar 13, 2023
Member
MayaLekova pushed a commit
to MayaLekova/node
that referenced
this pull request
May 22, 2026
After an OpenSSL source update, all the config files need to be regenerated and committed by: $ make -C deps/openssl/config $ git add deps/openssl/config/archs $ git add deps/openssl/openssl $ git commit PR-URL: nodejs#46570 Refs: https://mta.openssl.org/pipermail/openssl-announce/2023-February/000251.html Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
MayaLekova pushed a commit
to MayaLekova/node
that referenced
this pull request
May 22, 2026
Original commit message: rsa: add msvc intrinsic for non x64 platforms _umul128() is x86_64 (x64) only, while __umulh() works everywhere, but doesn't generate optimal code on x64 Refs: openssl/openssl#20244 PR-URL: nodejs#46570 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated openssl dep to openssl-3.0.8 using the maintenance guide.
Refs: https://mta.openssl.org/pipermail/openssl-announce/2023-February/000251.html