Uh oh!
There was an error while loading. Please reload this page.
[v19.x] deps: update Openssl 3.0.8+quic - #46573
Closed
RafaelGSS wants to merge 3 commits into
Closed
Conversation
This updates all sources in deps/openssl/openssl by: $ git clone git@github.com:quictls/openssl.git $ cd openssl $ git checkout openssl-3.0.8+quic $ cd ../node/deps/openssl $ rm -rf openssl $ cp -R ../../../openssl openssl $ rm -rf openssl/.git* openssl/.travis* $ git add --all openssl $ git commit openssl
This comment was marked as outdated.
This comment was marked as outdated.
nodejs-github-bot
commented
Feb 11, 2023
Collaborator
nodejs-github-bot
commented
Feb 12, 2023
Collaborator
After an OpenSSL source update, all the config files need to be regenerated and committed by: $ make -C deps/openssl/config $ git add deps/openssl/config/archs $ git add deps/openssl/openssl $ git commit
Original commit message: rsa: add msvc intrinsic for non x64 platforms _umul128() is x86_64 (x64) only, while __umulh() works everywhere, but doesn't generate optimal code on x64 Refs: openssl/openssl#20244
RafaelGSSforce-pushed
the
openssl-3.0.8+quic-v19
branch
from
February 12, 2023 18:44
9fc1929 to
19bfe1dComparenodejs-github-bot
commented
Feb 12, 2023
Collaborator
nodejs-github-bot
commented
Feb 13, 2023
Collaborator
nodejs-github-bot
commented
Feb 13, 2023
Collaborator
richardlau
approved these changes
Feb 13, 2023
RafaelGSS
commented
Feb 16, 2023
MemberAuthor
Landed in 8ac90e6...66a24ce |
Pranay180420 pushed a commit
to Pranay180420/Node.jsforme
that referenced
this pull request
Feb 17, 2025
This updates all sources in deps/openssl/openssl by: $ git clone git@github.com:quictls/openssl.git $ cd openssl $ git checkout openssl-3.0.8+quic $ cd ../node/deps/openssl $ rm -rf openssl $ cp -R ../../../openssl openssl $ rm -rf openssl/.git* openssl/.travis* $ git add --all openssl $ git commit openssl PR-URL: nodejs/node#46573 Refs: https://mta.openssl.org/pipermail/openssl-announce/2023-February/000251.html Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Richard Lau <rlau@redhat.com>
Pranay180420 pushed a commit
to Pranay180420/Node.jsforme
that referenced
this pull request
Feb 17, 2025
After an OpenSSL source update, all the config files need to be regenerated and committed by: $ make -C deps/openssl/config $ git add deps/openssl/config/archs $ git add deps/openssl/openssl $ git commit PR-URL: nodejs/node#46573 Refs: https://mta.openssl.org/pipermail/openssl-announce/2023-February/000251.html Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Richard Lau <rlau@redhat.com>
Pranay180420 pushed a commit
to Pranay180420/Node.jsforme
that referenced
this pull request
Feb 17, 2025
Original commit message: rsa: add msvc intrinsic for non x64 platforms _umul128() is x86_64 (x64) only, while __umulh() works everywhere, but doesn't generate optimal code on x64 PR-URL: nodejs/node#46573 Refs: openssl/openssl#20244 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Richard Lau <rlau@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated openssl dep to openssl-3.0.8 using the maintenance guide.
Refs: https://mta.openssl.org/pipermail/openssl-announce/2023-February/000251.html