Uh oh!
There was an error while loading. Please reload this page.
src: use string_view for report and related code - #46723
Merged
Merged
Conversation
Use `std::string_view` for process.report code and related code, drop a few unnecessary `std::to_string` calls, and use `MaybeStackBuffer` instead of `MallocedBuffer`, all in order to avoid unnecessary heap allocations.
nodejs-github-bot
commented
Feb 18, 2023
Collaborator
Review requested:
|
nodejs-github-bot
commented
Feb 18, 2023
Collaborator
nodejs-github-bot
commented
Feb 18, 2023
Collaborator
anonrig
reviewed
Feb 18, 2023
Uh oh!
There was an error while loading. Please reload this page.
21 tasks
tniessen
approved these changes
Feb 19, 2023
nodejs-github-bot
commented
Feb 19, 2023
Collaborator
anonrig
approved these changes
Feb 19, 2023
24 tasks
nodejs-github-bot
commented
Feb 20, 2023
Collaborator
jasnell
approved these changes
Feb 20, 2023
RaisinTen
approved these changes
Feb 20, 2023
nodejs-github-bot
commented
Feb 20, 2023
Collaborator
legendecas
approved these changes
Feb 20, 2023
nodejs-github-bot
commented
Feb 20, 2023
Collaborator
Landed in b85b5ba |
26 tasks
juanarbol
commented
Mar 1, 2023
Member
This depends on #46410 |
targos pushed a commit
that referenced
this pull request
Mar 13, 2023
Use `std::string_view` for process.report code and related code, drop a few unnecessary `std::to_string` calls, and use `MaybeStackBuffer` instead of `MallocedBuffer`, all in order to avoid unnecessary heap allocations. PR-URL: #46723 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
anonrig
commented
Apr 5, 2023
Member
I tried backporting but it didn't land cleanly on my pull request for Ada. #47435 |
anonrig
commented
Apr 6, 2023
Member
@juanarbol I removed the |
anonrig pushed a commit
to anonrig/node
that referenced
this pull request
Apr 11, 2023
Use `std::string_view` for process.report code and related code, drop a few unnecessary `std::to_string` calls, and use `MaybeStackBuffer` instead of `MallocedBuffer`, all in order to avoid unnecessary heap allocations. PR-URL: nodejs#46723 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Apr 12, 2023
Use `std::string_view` for process.report code and related code, drop a few unnecessary `std::to_string` calls, and use `MaybeStackBuffer` instead of `MallocedBuffer`, all in order to avoid unnecessary heap allocations. PR-URL: #46723 Backport-PR-URL: #47435 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
std::string_viewfor process.report code and related code, drop a few unnecessarystd::to_stringcalls, and useMaybeStackBufferinstead ofMallocedBuffer, all in order to avoid unnecessary heap allocations.