url: simplify and improve url formatting by anonrig · Pull Request #46736 · nodejs/node

anonrig · 2023-02-19T19:10:01Z

This pull request separates the logic of kFormat and URL and moves the logic to C++.

Quick summary:

Move Url.format implementation to C++ where it directly calls Ada. This is done to avoid having any URL logic inside Node.js
Call search setter whenever searchParams is changed, instead of calculating href on the JS layer. This was done to remove any URL logic inside Node.js.
Remove kFormat since it isn't used anymore after step 1 and 2.
Remove hasOpaquePath and hasHost from URL, since it was only needed for kFormat and searchParams setter.
Ise ToStringView() and ToString() methods that @addaleax recommended.

cc @nodejs/url @nodejs/cpp-reviewers

nodejs-github-bot · 2023-02-19T19:44:08Z

CI: https://ci.nodejs.org/job/node-test-pull-request/49740/

nodejs-github-bot · 2023-02-19T22:26:55Z

CI: https://ci.nodejs.org/job/node-test-pull-request/49749/

nodejs-github-bot · 2023-02-19T23:56:31Z

CI: https://ci.nodejs.org/job/node-test-pull-request/49752/

nodejs-github-bot · 2023-02-20T02:21:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/49755/

nodejs-github-bot · 2023-02-20T03:55:46Z

CI: https://ci.nodejs.org/job/node-test-pull-request/49765/

RaisinTen · 2023-02-20T04:41:58Z

Is this for better performance?

anonrig · 2023-02-20T13:50:33Z

Is this for better performance?

Not for this specifically, but I'm preparing for the new Ada changes where we will focus on enabling node.js-specific APIs to improve the performance. This is mainly for removing the URL parsing logic from Node.js core, and moving it to C++/Ada.

nodejs-github-bot · 2023-02-20T18:50:40Z

CI: https://ci.nodejs.org/job/node-test-pull-request/49799/

nodejs-github-bot · 2023-02-20T23:20:10Z

CI: https://ci.nodejs.org/job/node-test-pull-request/49808/

nodejs-github-bot · 2023-02-21T01:03:28Z

CI: https://ci.nodejs.org/job/node-test-pull-request/49811/

nodejs-github-bot · 2023-02-24T22:35:07Z

Landed in 8073392

PR-URL: #46736 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

danielleadams · 2023-04-03T04:46:51Z

@anonrig this broke the build when landing in v18.x. Do you mind creating a backport PR?

anonrig · 2023-04-05T21:49:16Z

This depends on #46723

PR-URL: nodejs#46736 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #46736 Backport-PR-URL: #47435 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. url Issues and PRs related to the legacy built-in url module. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Feb 19, 2023

anonrig force-pushed the improve-url-parsing branch from 2e032a0 to 4c6bdffCompare February 19, 2023 19:13

anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 19, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 19, 2023

addaleax reviewed Feb 19, 2023
View reviewed changes

Comment threadsrc/node_url.cc Outdated

github-actionsBot mentioned this pull request Feb 20, 2023
CI Reliability 2023-02-20 nodejs/reliability#501
Open
24 tasks

joyeecheung mentioned this pull request Feb 20, 2023
parallel/test-runner-reporters is flaking #46747
Closed

anonrig added the review wanted PRs that need reviews. label Feb 20, 2023

anonrig requested review from TimothyGu and jasnell February 20, 2023 17:16

anonrig requested a review from addaleax February 20, 2023 18:52

anonrig force-pushed the improve-url-parsing branch from 4c6bdff to c8f6c5aCompare February 20, 2023 23:03

anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 20, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 20, 2023

github-actionsBot mentioned this pull request Feb 21, 2023
CI Reliability 2023-02-21 nodejs/reliability#502
Open
26 tasks

addaleax reviewed Feb 21, 2023
View reviewed changes

Comment threadlib/url.js Outdated

TimothyGu reviewed Feb 21, 2023
View reviewed changes

Comment threadlib/internal/url.js Outdated

anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 24, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 24, 2023

nodejs-github-bot merged commit 8073392 into nodejs:mainFeb 24, 2023

anonrig deleted the improve-url-parsing branch February 24, 2023 22:35

github-actionsBot mentioned this pull request Feb 25, 2023
CI Reliability 2023-02-25 nodejs/reliability#506
Open
28 tasks

tniessen mentioned this pull request Mar 2, 2023
src: fix array overrun in node::url::SetArgs() #46541
Closed

targos pushed a commit that referenced this pull request Mar 13, 2023
url: simplify and improve url formatting
5a3ad87
PR-URL: #46736 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

targos mentioned this pull request Mar 14, 2023
v19.8.0 release proposal #47087
Merged

danielleadams added the backport-requested-v18.x label Apr 3, 2023

This was referenced Apr 3, 2023
url: set formatUrl method as no side effect #46884
Merged
url: fix array overrun in node:url::SetArgs() #47001
Merged
src: use std::array for passing argv in node::url #47035
Merged

anonrig mentioned this pull request Apr 5, 2023
[v18.x backport] replace url parser with ada #47435
Closed

anonrig added backport-open-v18.x and removed backport-requested-v18.x labels Apr 5, 2023

anonrig added backport-requested-v18.x and removed backport-open-v18.x labels Apr 5, 2023

anonrig added backport-open-v18.x and removed backport-requested-v18.x labels Apr 6, 2023

anonrig added a commit to anonrig/node that referenced this pull request Apr 11, 2023
url: simplify and improve url formatting
aae4141
PR-URL: nodejs#46736 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

danielleadams pushed a commit that referenced this pull request Apr 12, 2023
url: simplify and improve url formatting
a39dd37
PR-URL: #46736 Backport-PR-URL: #47435 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

danielleadams added backported-to-v18.x and removed backport-open-v18.x labels Apr 12, 2023

danielleadams mentioned this pull request Apr 12, 2023
v18.16.0 release proposal #47502
Merged

Uh oh!

Uh oh!

Conversation

anonrig commented Feb 19, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Feb 19, 2023

Uh oh!

Uh oh!

nodejs-github-bot commented Feb 19, 2023

Uh oh!

nodejs-github-bot commented Feb 19, 2023

Uh oh!

nodejs-github-bot commented Feb 20, 2023

Uh oh!

nodejs-github-bot commented Feb 20, 2023

Uh oh!

RaisinTen commented Feb 20, 2023

Uh oh!

anonrig commented Feb 20, 2023

Uh oh!

nodejs-github-bot commented Feb 20, 2023

Uh oh!

nodejs-github-bot commented Feb 20, 2023

Uh oh!

nodejs-github-bot commented Feb 21, 2023

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Feb 24, 2023

Uh oh!

danielleadams commented Apr 3, 2023

Uh oh!

anonrig commented Apr 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

anonrig commented Feb 19, 2023•
edited
Loading