Skip to content

deps: update ada to 1.0.4 - #46853

Merged
nodejs-github-bot merged 1 commit into
mainfrom
actions/tools-update-ada
Feb 28, 2023
Merged

deps: update ada to 1.0.4#46853
nodejs-github-bot merged 1 commit into
mainfrom
actions/tools-update-ada

Conversation

@nodejs-github-bot

@nodejs-github-botnodejs-github-bot commented Feb 26, 2023•
edited by aduh95
Loading

Copy link
Copy Markdown
Collaborator

This is an automated update of ada to 1.0.4.

Fixes: #46850

@nodejs-github-botnodejs-github-bot added the dependencies Pull requests that update a dependency file. label Feb 26, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 26, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Review requested:

  • @nodejs/url

@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Feb 26, 2023
@anonriganonrig added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Feb 26, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 26, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 26, 2023

Copy link
Copy Markdown
CollaboratorAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/50039/

@nodejs-github-bot

nodejs-github-bot commented Feb 26, 2023

Copy link
Copy Markdown
CollaboratorAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/50041/

@github-actionsgithub-actionsBot mentioned this pull request Feb 27, 2023
Open
13 tasks
@meixg

meixg commented Feb 27, 2023

Copy link
Copy Markdown
Member

fix: #46850

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 27, 2023
@meixgmeixg mentioned this pull request Feb 27, 2023
Merged
@github-actionsgithub-actionsBot mentioned this pull request Feb 28, 2023
Open
16 tasks
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 28, 2023
@nodejs-github-bot
nodejs-github-bot merged commit d5eb3d4 into mainFeb 28, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 28, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Landed in d5eb3d4

@nodejs-github-bot
nodejs-github-bot deleted the actions/tools-update-ada branch February 28, 2023 20:44
targos pushed a commit that referenced this pull request Mar 13, 2023
@nodejs-github-bot@targos
deps: update ada to 1.0.4
18d0d36
PR-URL: #46853Fixes: #46850
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
targos pushed a commit that referenced this pull request Mar 14, 2023
@nodejs-github-bot@targos
deps: update ada to 1.0.4
b825e2d
PR-URL: #46853Fixes: #46850
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
@targostargos mentioned this pull request Mar 14, 2023
Merged
@danielleadams

danielleadams commented Apr 3, 2023

Copy link
Copy Markdown
Contributor

Blocked by #46410

@anonriganonrig mentioned this pull request Apr 5, 2023
Closed
anonrig pushed a commit to anonrig/node that referenced this pull request Apr 11, 2023
@nodejs-github-bot@anonrig
deps: update ada to 1.0.4
7df525b
PR-URL: nodejs#46853Fixes: nodejs#46850
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
danielleadams pushed a commit that referenced this pull request Apr 12, 2023
@nodejs-github-bot@danielleadams
deps: update ada to 1.0.4
e5c4d69
PR-URL: #46853
Backport-PR-URL: #47435Fixes: #46850
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Apr 12, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lemirelemirelemire approved these changes
@anonriganonriganonrig approved these changes
@meixgmeixgmeixg approved these changes
+1 more reviewer
@VoltrexKeyvaVoltrexKeyvaVoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.dependenciesPull requests that update a dependency file.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Quotes in the URL are not percent encoded

7 participants

@nodejs-github-bot@meixg@danielleadams@lemire@anonrig@VoltrexKeyva@aduh95