Skip to content

test: update web-platform tests for url - #46860

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
meixg:url-quote-escape
Mar 1, 2023
Merged

test: update web-platform tests for url#46860
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
meixg:url-quote-escape

Conversation

@meixg

@meixgmeixg commented Feb 27, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Update wpt url test. Added case for #46850 by web-platform-tests/wpt#38711.

Rely on #46853

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 27, 2023
@meixgmeixg mentioned this pull request Feb 27, 2023
Closed
@anonrig

anonrig commented Mar 1, 2023

Copy link
Copy Markdown
Member

Can you update the pull request @meixg? The tests are failing of it.

@meixg
meixgforce-pushed the url-quote-escape branch from 94c4683 to 10d8755CompareMarch 1, 2023 01:49
@anonriganonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 1, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 1, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 1, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50117/

@nodejs-github-bot

nodejs-github-bot commented Mar 1, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50120/

@nodejs-github-bot

nodejs-github-bot commented Mar 1, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50128/

@panvapanva added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 1, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 1, 2023
@nodejs-github-bot
nodejs-github-bot merged commit f652f7b into nodejs:mainMar 1, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 1, 2023

Copy link
Copy Markdown
Collaborator

Landed in f652f7b

This was referenced Mar 2, 2023
Open
Open
@meixg
meixg deleted the url-quote-escape branch March 3, 2023 03:24
This was referenced Mar 4, 2023
Open
Open
Open
targos pushed a commit that referenced this pull request Mar 13, 2023
@meixg@targos
test: update web-platform tests for url
001c8b4
PR-URL: #46860
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
targos pushed a commit that referenced this pull request Mar 14, 2023
@meixg@targos
test: update web-platform tests for url
0e45470
PR-URL: #46860
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
@targostargos mentioned this pull request Mar 14, 2023
Merged
@anonriganonrig mentioned this pull request Jun 26, 2023
Closed
19 tasks
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@meixg@danielleadams
test: update web-platform tests for url
b3b7dbc
PR-URL: #46860
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panvapanvapanva approved these changes
@anonriganonriganonrig approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@meixg@anonrig@nodejs-github-bot@panva