Skip to content

url: set formatUrl method as no side effect - #46884

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:url-no-side-effect
Mar 2, 2023
Merged

url: set formatUrl method as no side effect#46884
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:url-no-side-effect

Conversation

@anonrig

@anonriganonrig commented Feb 28, 2023•
edited
Loading

Copy link
Copy Markdown
Member

formatUrl does not have any side effects.

@nodejs-github-bot

nodejs-github-bot commented Feb 28, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/url

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Feb 28, 2023
@anonriganonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 28, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 28, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 28, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50100/

@anonriganonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 28, 2023
BridgeAR
BridgeAR approved these changes Feb 28, 2023
View reviewed changes
Comment threadsrc/node_url.cc
@nodejs-github-bot

nodejs-github-bot commented Feb 28, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50112/

@anonriganonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 28, 2023
@github-actionsgithub-actionsBot mentioned this pull request Mar 1, 2023
Open
15 tasks
@github-actionsgithub-actionsBot mentioned this pull request Mar 2, 2023
Open
15 tasks
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 2, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 7bd909b into nodejs:mainMar 2, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 2, 2023

Copy link
Copy Markdown
Collaborator

Landed in 7bd909b

This was referenced Mar 3, 2023
Open
Open
targos pushed a commit that referenced this pull request Mar 13, 2023
@anonrig@targos
url: set formatUrl method as no side effect
02c907d
PR-URL: #46884
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos pushed a commit that referenced this pull request Mar 14, 2023
@anonrig@targos
url: set formatUrl method as no side effect
b1747fe
PR-URL: #46884
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@targostargos mentioned this pull request Mar 14, 2023
Merged
@danielleadams

danielleadams commented Apr 3, 2023

Copy link
Copy Markdown
Contributor

blocked by #46736

@anonriganonrig mentioned this pull request Jun 5, 2023
Closed
19 tasks
anonrig added a commit to anonrig/node that referenced this pull request Jul 9, 2023
@anonrig
url: set formatUrl method as no side effect
17e3fd0
PR-URL: nodejs#46884
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams pushed a commit that referenced this pull request Jul 12, 2023
@anonrig@danielleadams
url: set formatUrl method as no side effect
aa4f485
PR-URL: #46884
Backport-PR-URL: #48345
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@danielleadamsdanielleadams mentioned this pull request Jul 12, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BridgeARBridgeARBridgeAR approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@cjihrigcjihrigcjihrig approved these changes
@tniessentniessentniessen approved these changes
+1 more reviewer
@TimothyGuTimothyGuTimothyGu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.whatwg-urlIssues and PRs related to the WHATWG URL implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@anonrig@nodejs-github-bot@danielleadams@addaleax@TimothyGu@cjihrig@tniessen@BridgeAR