Skip to content

url: allow extension of user provided URL objects - #46989

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
aduh95:urlToHttpOptions
Mar 19, 2023
Merged

url: allow extension of user provided URL objects#46989
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
aduh95:urlToHttpOptions

Conversation

@aduh95

@aduh95aduh95 commented Mar 7, 2023

Copy link
Copy Markdown
Contributor

Fixes: #46981

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Mar 7, 2023
@aduh95aduh95 mentioned this pull request Mar 7, 2023
Closed
anonrig
anonrig reviewed Mar 7, 2023
View reviewed changes
Comment threadlib/internal/url.js
Comment threadlib/internal/url.js
anonrig
anonrig reviewed Mar 7, 2023
View reviewed changes
Comment threadlib/internal/url.js
@anonriganonrig mentioned this pull request Mar 7, 2023
Closed
trentm
trentm reviewed Mar 9, 2023
View reviewed changes

@trentmtrentm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (caveat: I'm not a nodejs reviewer)

@aduh95
aduh95 requested a review from anonrigMarch 18, 2023 11:19
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 18, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 18, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50443/

@nodejs-github-bot

nodejs-github-bot commented Mar 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50452/

@github-actionsgithub-actionsBot mentioned this pull request Mar 19, 2023
Open
19 tasks
@anonriganonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 19, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 19, 2023
@nodejs-github-bot
nodejs-github-bot merged commit ad2c3c0 into nodejs:mainMar 19, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 19, 2023

Copy link
Copy Markdown
Collaborator

Landed in ad2c3c0

This was referenced Mar 20, 2023
Open
Open
Open
@trentmtrentm mentioned this pull request Mar 30, 2023
Closed
@RafaelGSSRafaelGSS mentioned this pull request Apr 3, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@aduh95@RafaelGSS
url: allow extension of user provided URL objects
306d230
PR-URL: #46989Fixes: #46981
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@RafaelGSSRafaelGSS mentioned this pull request Apr 6, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
@aduh95@RafaelGSS
url: allow extension of user provided URL objects
0b565e8
PR-URL: #46989Fixes: #46981
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@anonriganonrig mentioned this pull request Jun 24, 2023
Closed
19 tasks
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@aduh95@danielleadams
url: allow extension of user provided URL objects
b04ea5a
PR-URL: #46989Fixes: #46981
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
anonrig pushed a commit to anonrig/node that referenced this pull request Jul 9, 2023
@aduh95@anonrig
url: allow extension of user provided URL objects
353bab0
PR-URL: nodejs#46989Fixes: nodejs#46981
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@danielleadamsdanielleadams mentioned this pull request Jul 10, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 12, 2023
@aduh95@danielleadams
url: allow extension of user provided URL objects
4784e64
PR-URL: #46989
Backport-PR-URL: #48345Fixes: #46981
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonriganonriganonrig approved these changes
+2 more reviewers
@trentmtrentmtrentm left review comments
@TimothyGuTimothyGuTimothyGu left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.whatwg-urlIssues and PRs related to the WHATWG URL implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

new internal isURL check can result in http.request() option fields being ignored

6 participants

@aduh95@nodejs-github-bot@trentm@TimothyGu@anonrig@danielleadams