Uh oh!
There was an error while loading. Please reload this page.
test: remove unnecessary urlToHttpOptions test - #47002
Closed
anonrig wants to merge 1 commit into
Closed
Conversation
aduh95
requested changes
Mar 7, 2023
aduh95
left a comment
Contributor
There was a problem hiding this comment.
I don’t think it’s a good reason to remove the test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following test is not needed anymore. We removed the symbol in URL, and the following test is unnecessary. Reference: #46904
We don't even check for isURL on urlToHttpOptions, but the parameter of urlToHttpOptions is expected to be
URL.Referencing the discussion with @aduh95 on #46989
cc @nodejs/url