Uh oh!
There was an error while loading. Please reload this page.
Fix test-child-process-exec-cwd for Windows on ARM64 - #47235
Merged
Conversation
lpinca
approved these changes
Mar 23, 2023
nodejs-github-bot
commented
Mar 23, 2023
Collaborator
debadree25
approved these changes
Mar 24, 2023
StefanStojanovic
commented
Mar 27, 2023
ContributorAuthor
Is there something else I can do to help move this forward? |
nodejs-github-bot
commented
Mar 27, 2023
Collaborator
Landed in 13767a4 |
richardlau pushed a commit
that referenced
this pull request
Mar 28, 2023
Refs: #47020 Refs: nodejs/build#3046 PR-URL: #47235 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
This was referenced Apr 3, 2023
Merged
RafaelGSS pushed a commit
that referenced
this pull request
Apr 7, 2023
Refs: #47020 Refs: nodejs/build#3046 PR-URL: #47235 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Jul 6, 2023
Refs: #47020 Refs: nodejs/build#3046 PR-URL: #47235 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the previously skipped
test-child-process-exec-cwdon Windows on ARM64. The issue was the casing of stdout for that platform.cc: @targos (#47020 (comment)) @nodejs/platform-windows-arm
Refs: #47020
Refs: nodejs/build#3046