[v19.x] deps: V8: cherry-pick f09dde9fbb54 by richardlau · Pull Request #47239 · nodejs/node

richardlau · 2023-03-23T19:27:28Z

Original commit message:

Revert "[resultdb] Add ResultDB indicator"
This reverts commit 237de893e1c0a0628a57d0f5797483d3add7f005.
Reason for revert: breaks flake bisect:
https://ci.chromium.org/ui/p/v8/builders/try.triggered/v8_flako/b8800423657665797553/overview
The change added the implicit requirement to run testing with
vpython3, which is not given everywhere.
Original change's description:
> [resultdb] Add ResultDB indicator
>
> Adds a new indicator that will send every result to ResultDB (and ultimately in a bq table; to be configured later).
>
> If we are not running in a ResultDB context we introduce only a minimal overhead by exiting early from indicator.
>
> To test these changes in a luci context with ResultDB we activated resultdb feature flag via V8-Recipe-Flags. This feature got implemented in https://crrev.com/c/3925576 .
>
>
> V8-Recipe-Flags: resultdb
> Bug: v8:13316
> Change-Id: I5d98e8f27531b536686a8d63b993313b9d6f62c5
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3905385
> Commit-Queue: Liviu Rau <liviurau@google.com>
> Reviewed-by: Alexander Schulze <alexschulze@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#83672}
Bug: v8:13316
Change-Id: I7e55668e365475298ed46d2fc8ee0fe1282c3e8e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3952131
Auto-Submit: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#83677}

Refs: v8/v8@f09dde9
Fixes: nodejs/build#3221

cc @nodejs/v8-update

nodejs-github-bot · 2023-03-23T19:27:33Z

Review requested:

@nodejs/gyp
@nodejs/v8-update

nodejs-github-bot · 2023-03-23T19:35:53Z

CI: https://ci.nodejs.org/job/node-test-pull-request/50578/

nodejs-github-bot · 2023-03-23T19:37:03Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5245/

nodejs-github-bot · 2023-03-23T19:37:44Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5245/

nodejs-github-bot · 2023-03-23T21:59:02Z

CI: https://ci.nodejs.org/job/node-test-pull-request/50579/

StefanStojanovic · 2023-03-24T14:22:47Z

@richardlau I've noticed Windows CI failed for this PR. This happened because this commit is missing from your branch. Please cherry-pick it and rerun the CI. The commit from my other PR fixes the test at hand, so once it lands, those changes will be sufficient on their own.

Additionally, by going through 2 builds started on this PR, I've seen that test-crypto-dh-odd-key failed on ARM64 in the second run. I reran it and the test passed. Since it failed with timeout and I didn't see it do so before, I'd not go so far as to mark it flaky, but I'll keep my eye on it.

nodejs-github-bot · 2023-04-07T17:11:15Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5282/

nodejs-github-bot · 2023-04-07T18:32:56Z

CI: https://ci.nodejs.org/job/node-test-pull-request/51055/

gengjiawen

rebase is wrong (currently 50 commits in this PR)

richardlau · 2023-04-10T10:16:04Z

rebase is wrong (currently 50 commits in this PR)

This PR was correct until v19.x-staging was rebased 😞. I won't be able to fix this up until tonight or tomorrow.

targos · 2023-04-10T10:18:16Z

There's no need to fix up. Last CI was green so we can land it

Original commit message: Revert "[resultdb] Add ResultDB indicator" This reverts commit 237de893e1c0a0628a57d0f5797483d3add7f005. Reason for revert: breaks flake bisect: https://ci.chromium.org/ui/p/v8/builders/try.triggered/v8_flako/b8800423657665797553/overview The change added the implicit requirement to run testing with vpython3, which is not given everywhere. Original change's description: > [resultdb] Add ResultDB indicator > > Adds a new indicator that will send every result to ResultDB (and ultimately in a bq table; to be configured later). > > If we are not running in a ResultDB context we introduce only a minimal overhead by exiting early from indicator. > > To test these changes in a luci context with ResultDB we activated resultdb feature flag via V8-Recipe-Flags. This feature got implemented in https://crrev.com/c/3925576 . > > > V8-Recipe-Flags: resultdb > Bug: v8:13316 > Change-Id: I5d98e8f27531b536686a8d63b993313b9d6f62c5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3905385 > Commit-Queue: Liviu Rau <liviurau@google.com> > Reviewed-by: Alexander Schulze <alexschulze@chromium.org> > Cr-Commit-Position: refs/heads/main@{#83672} Bug: v8:13316 Change-Id: I7e55668e365475298ed46d2fc8ee0fe1282c3e8e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3952131 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#83677} Refs: v8/v8@f09dde9

nodejs-github-bot · 2023-04-12T17:37:46Z

CI: https://ci.nodejs.org/job/node-test-pull-request/51167/

nodejs-github-bot · 2023-04-12T17:40:13Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5296/

nodejs-github-bot · 2023-04-12T17:40:43Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5296/

nodejs-github-bot · 2023-04-12T17:47:08Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5296/

nodejs-github-bot · 2023-04-12T18:41:18Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5297/

nodejs-github-bot · 2023-04-12T18:42:33Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5297/

nodejs-github-bot · 2023-04-12T18:42:33Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5297/

nodejs-github-bot · 2023-04-12T21:00:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/51174/

Original commit message: Revert "[resultdb] Add ResultDB indicator" This reverts commit 237de893e1c0a0628a57d0f5797483d3add7f005. Reason for revert: breaks flake bisect: https://ci.chromium.org/ui/p/v8/builders/try.triggered/v8_flako/b8800423657665797553/overview The change added the implicit requirement to run testing with vpython3, which is not given everywhere. Original change's description: > [resultdb] Add ResultDB indicator > > Adds a new indicator that will send every result to ResultDB (and ultimately in a bq table; to be configured later). > > If we are not running in a ResultDB context we introduce only a minimal overhead by exiting early from indicator. > > To test these changes in a luci context with ResultDB we activated resultdb feature flag via V8-Recipe-Flags. This feature got implemented in https://crrev.com/c/3925576 . > > > V8-Recipe-Flags: resultdb > Bug: v8:13316 > Change-Id: I5d98e8f27531b536686a8d63b993313b9d6f62c5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3905385 > Commit-Queue: Liviu Rau <liviurau@google.com> > Reviewed-by: Alexander Schulze <alexschulze@chromium.org> > Cr-Commit-Position: refs/heads/main@{#83672} Bug: v8:13316 Change-Id: I7e55668e365475298ed46d2fc8ee0fe1282c3e8e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3952131 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#83677} Refs: v8/v8@f09dde9 PR-URL: #47239Fixes: nodejs/build#3221 Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

richardlau · 2023-04-13T12:03:18Z

Landed in a978ca6.

@gengjiawen FWIW commit-queueAdd this label to land a pull request using GitHub Actions. only works on main.

richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 23, 2023

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v19.x v8 engine Issues and PRs related to the V8 dependency. labels Mar 23, 2023

richardlau mentioned this pull request Mar 23, 2023
V8 CI broken on v19.x nodejs/build#3221
Closed

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 23, 2023

richardlau added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Mar 28, 2023

richardlau force-pushed the norequests-v19.x branch from 32385b4 to f5c68a3Compare March 28, 2023 14:58

richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 28, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 28, 2023

This comment was marked as outdated.
Sign in to view

github-actionsBot mentioned this pull request Mar 30, 2023
CI Reliability 2023-03-30 nodejs/reliability#534
Open
18 tasks

This comment was marked as outdated.
Sign in to view

github-actionsBot mentioned this pull request Mar 31, 2023
CI Reliability 2023-03-31 nodejs/reliability#535
Open
34 tasks

This comment was marked as outdated.
Sign in to view

github-actionsBot mentioned this pull request Apr 1, 2023
CI Reliability 2023-04-01 nodejs/reliability#536
Open
38 tasks

RafaelGSS force-pushed the v19.x-staging branch from 9ffffca to 8e1e9edCompare April 8, 2023 18:21

gengjiawen requested changes Apr 10, 2023
View reviewed changes

richardlau force-pushed the norequests-v19.x branch from 74f6b63 to 48fc442Compare April 11, 2023 11:34

gengjiawen approved these changes Apr 11, 2023
View reviewed changes

github-actionsBot mentioned this pull request Apr 12, 2023
CI Reliability 2023-04-12 nodejs/reliability#541
Open
31 tasks

gengjiawen added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 12, 2023

richardlau added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 12, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 12, 2023

github-actionsBot mentioned this pull request Apr 13, 2023
CI Reliability 2023-04-13 nodejs/reliability#542
Open
36 tasks

gengjiawen added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 13, 2023

richardlau closed this Apr 13, 2023

richardlau deleted the norequests-v19.x branch April 13, 2023 12:03

richardlau mentioned this pull request Apr 13, 2023
[v19.x] deps: V8: cherry-pick 9ec4e9095a25 #47535
Closed

Uh oh!

Uh oh!

Conversation

richardlau commented Mar 23, 2023

Uh oh!

nodejs-github-bot commented Mar 23, 2023

Uh oh!

nodejs-github-bot commented Mar 23, 2023

Uh oh!

nodejs-github-bot commented Mar 23, 2023

Uh oh!

nodejs-github-bot commented Mar 23, 2023

Uh oh!

nodejs-github-bot commented Mar 23, 2023

Uh oh!

StefanStojanovic commented Mar 24, 2023

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Apr 7, 2023

Uh oh!

nodejs-github-bot commented Apr 7, 2023

Uh oh!

gengjiawen left a comment

Choose a reason for hiding this comment

Uh oh!

richardlau commented Apr 10, 2023

Uh oh!

targos commented Apr 10, 2023

Uh oh!

nodejs-github-bot commented Apr 12, 2023

Uh oh!

nodejs-github-bot commented Apr 12, 2023

Uh oh!

nodejs-github-bot commented Apr 12, 2023

Uh oh!

nodejs-github-bot commented Apr 12, 2023

Uh oh!

nodejs-github-bot commented Apr 12, 2023

Uh oh!

nodejs-github-bot commented Apr 12, 2023

Uh oh!

nodejs-github-bot commented Apr 12, 2023

Uh oh!

nodejs-github-bot commented Apr 12, 2023

Uh oh!

richardlau commented Apr 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants