Skip to content

test: run WPT files in parallel again - #47283

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:try-wpt-files-parallel
Mar 31, 2023
Merged

test: run WPT files in parallel again#47283
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:try-wpt-files-parallel

Conversation

@panva

@panvapanva commented Mar 28, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Allows WPT suites as well as individual WPT files in them to run in parallel.

Refs: #47146
Refs: #47273 (review)

@panvapanva mentioned this pull request Mar 28, 2023
Closed
@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 28, 2023
@panva

This comment was marked as outdated.

Sign in to view
@panvapanva added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 28, 2023
targos
targos reviewed Mar 28, 2023
View reviewed changes
Comment threadtest/common/wpt.js Outdated
Comment on lines 418 to 413

@targostargosMar 28, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not returned or awaited. Is there a risk of unhandled rejection?

@panvapanvaMar 28, 2023•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It behaves as expected even with the WPT suite updated (like the daily WPT job does).

This is the await in the queue.

awaitevents.once(worker,'exit').catch(()=>{});

That being said, I am aware it's just a basic concurrency limit function implementation...

@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 28, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@panva

This comment was marked as resolved.

Sign in to view
@targos

This comment was marked as resolved.

Sign in to view
@github-actionsgithub-actionsBot mentioned this pull request Mar 30, 2023
Open
18 tasks
@panvapanva added the blocked PRs that are blocked by other issues or PRs. label Mar 30, 2023
@panva

This comment was marked as resolved.

Sign in to view
@panva
panvaforce-pushed the try-wpt-files-parallel branch from 77fed52 to 313c51eCompareMarch 30, 2023 15:37
@panvapanva added request-ci Add this label to start a Jenkins CI on a PR. and removed blocked PRs that are blocked by other issues or PRs. labels Mar 30, 2023
@panva

panva commented Mar 30, 2023•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Before:

make test-wpt 74.66s user 2.29s system 88% cpu 1:27.07 total

After:

make test-wpt 75.50s user 3.28s system 428% cpu 18.368 total

Ran on an M1 Macbook Pro

> os.availableParallelism()
10

https://ci.nodejs.org/job/node-stress-single-test/391/console

@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 30, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Mar 30, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50721/

@github-actionsgithub-actionsBot mentioned this pull request Mar 31, 2023
Open
34 tasks
@panvapanva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 31, 2023
@anonriganonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 31, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 31, 2023
@nodejs-github-bot
nodejs-github-bot merged commit c05689e into nodejs:mainMar 31, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 31, 2023

Copy link
Copy Markdown
Collaborator

Landed in c05689e

@panva
panva deleted the try-wpt-files-parallel branch March 31, 2023 17:57
This was referenced Apr 1, 2023
Open
Open
@panva

panva commented Apr 2, 2023

Copy link
Copy Markdown
MemberAuthor

not landing yet because tonight's daily WPT did not generate a report for current-nightly where this was included, will investigate.

@panvapanva mentioned this pull request Apr 2, 2023
Closed
@RafaelGSSRafaelGSS mentioned this pull request Apr 3, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@panva@RafaelGSS
test: run WPT files in parallel again
f756906
PR-URL: #47283
Refs: #47146
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@RafaelGSSRafaelGSS mentioned this pull request Apr 6, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
@panva@RafaelGSS
test: run WPT files in parallel again
ae3c753
PR-URL: #47283
Refs: #47146
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
@panva@RafaelGSS
test: run WPT files in parallel again
b422467
PR-URL: #47283
Refs: #47146
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
RafaelGSS pushed a commit that referenced this pull request Apr 8, 2023
@panva@RafaelGSS
test: run WPT files in parallel again
54261f3
PR-URL: #47283
Refs: #47146
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@panvapanva mentioned this pull request Apr 19, 2023
Closed
This was referenced Apr 19, 2023
Closed
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonriganonriganonrig approved these changes
@targostargostargos approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@panva@nodejs-github-bot@targos@anonrig