Skip to content

test: revert parallel wpt commits - #47627

Closed
panva wants to merge 2 commits into
nodejs:mainfrom
panva:wpt-reverts
Closed

test: revert parallel wpt commits#47627
panva wants to merge 2 commits into
nodejs:mainfrom
panva:wpt-reverts

Conversation

@panva

@panvapanva commented Apr 19, 2023•
edited
Loading

Copy link
Copy Markdown
Member

This reverts #47283 and #47376 because the changes in the former allow multi-variant test file workers to be terminated before finishing, not reporting the results at all, see e.g. here in 19.x, 20.x, and nightly columns, those are the ones where #47283 has landed.

I will refactor the WPT Runner instead of constantly fixing the untestable.

@panvapanva added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Apr 19, 2023
@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Apr 19, 2023
@panvapanva mentioned this pull request Apr 19, 2023
Closed
@panva

panva commented Apr 19, 2023

Copy link
Copy Markdown
MemberAuthor

fast-trackPRs that do not need to wait for 48 hours to land. because while these commits are in place we're not actually reporting on WPT failures in workers that get randomly terminated.

@panvapanva added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 19, 2023
@github-actions

github-actionsBot commented Apr 19, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @panva. Please 👍 to approve.

@panvapanva added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 19, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 19, 2023
@nodejs-github-bot

nodejs-github-bot commented Apr 19, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51364/

@nodejs-github-bot

nodejs-github-bot commented Apr 20, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51373/

@nodejs-github-bot

nodejs-github-bot commented Apr 20, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51375/

@panvapanva added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 20, 2023
@nodejs-github-botnodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 20, 2023
@nodejs-github-bot

nodejs-github-bot commented Apr 20, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/47627
✔ Done loading data for nodejs/node/pull/47627
----------------------------------- PR info ------------------------------------
Title test: revert parallel wpt commits (#47627)
Author Filip Skokan (@panva)
Branch panva:wpt-reverts -> nodejs:main
Labels build, tools, fast-track, needs-ci, dont-land-on-v14.x, dont-land-on-v16.x, commit-queue-rebase, dont-land-on-v18.x
Commits 2
- Revert "tools: ensure failed daily wpt run still generates a report"
- Revert "test: run WPT files in parallel again"
Committers 1
- Filip Skokan PR-URL: https://github.com/nodejs/node/pull/47627
Reviewed-By: Richard Lau Reviewed-By: Yagiz Nizipli Reviewed-By: Matthew Aitken ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/47627
Reviewed-By: Richard Lau Reviewed-By: Yagiz Nizipli Reviewed-By: Matthew Aitken --------------------------------------------------------------------------------
⚠ Commits were pushed since the last review:
⚠ - Revert "tools: ensure failed daily wpt run still generates a report"
⚠ - Revert "test: run WPT files in parallel again"
ℹ This PR was created on Wed, 19 Apr 2023 20:57:57 GMT
✔ Approvals: 3
✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/47627#pullrequestreview-1393002791
✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/47627#pullrequestreview-1393073980
✔ - Matthew Aitken (@KhafraDev): https://github.com/nodejs/node/pull/47627#pullrequestreview-1393228084
ℹ This PR is being fast-tracked
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2023-04-20T06:35:12Z: https://ci.nodejs.org/job/node-test-pull-request/51375/
- Querying data for job/node-test-pull-request/51375/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/4752023065

@panva

panva commented Apr 20, 2023

Copy link
Copy Markdown
MemberAuthor

Landed in 12094bc...607715e

@panvapanva closed this Apr 20, 2023
panva added a commit that referenced this pull request Apr 20, 2023
@panva
Revert "tools: ensure failed daily wpt run still generates a report"
a49e93e
This reverts commit b17227b.
PR-URL: #47627
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
panva added a commit that referenced this pull request Apr 20, 2023
@panva
Revert "test: run WPT files in parallel again"
607715e
This reverts commit c05689e.
PR-URL: #47627
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
@panva
panva deleted the wpt-reverts branch April 20, 2023 08:36
@panvapanva mentioned this pull request Apr 20, 2023
Merged
@panva

panva commented Apr 20, 2023

Copy link
Copy Markdown
MemberAuthor

See #47635 for the fix.

This was referenced Apr 24, 2023
Open
Open
Open
targos pushed a commit that referenced this pull request May 2, 2023
@panva@targos
Revert "tools: ensure failed daily wpt run still generates a report"
c17f268
This reverts commit b17227b.
PR-URL: #47627
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
targos pushed a commit that referenced this pull request May 2, 2023
@panva@targos
Revert "test: run WPT files in parallel again"
9d3768e
This reverts commit c05689e.
PR-URL: #47627
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
@targostargos mentioned this pull request May 2, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonriganonriganonrig approved these changes
@richardlaurichardlaurichardlau approved these changes
@KhafraDevKhafraDevKhafraDev approved these changes

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.commit-queue-failedAn error occurred while landing this pull request using GitHub Actions.commit-queue-rebaseAdd this label to allow the Commit Queue to land a PR in several commits.fast-trackPRs that do not need to wait for 48 hours to land.needs-ciPRs that need a full CI run.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@panva@nodejs-github-bot@anonrig@richardlau@KhafraDev