Uh oh!
There was an error while loading. Please reload this page.
[v16.x backport] crypto: use WebIDL converters in WebCryptoAPI - #47383
Closed
panva wants to merge 12 commits into
Closed
[v16.x backport] crypto: use WebIDL converters in WebCryptoAPI#47383panva wants to merge 12 commits into
panva wants to merge 12 commits into
Conversation
closesnodejs#45987 PR-URL: nodejs#46042Fixes: nodejs#45987 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Backport-PR-URL: nodejs#47336
PR-URL: nodejs#46043 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Backport-PR-URL: nodejs#47336
PR-URL: nodejs#45320 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Backport-PR-URL: nodejs#47336
PR-URL: nodejs#44917 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Backport-PR-URL: nodejs#47336
PR-URL: nodejs#45569 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Backport-PR-URL: nodejs#47336
PR-URL: nodejs#45569 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Backport-PR-URL: nodejs#47336
PR-URL: nodejs#45569 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Backport-PR-URL: nodejs#47336
PR-URL: nodejs#45569 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Backport-PR-URL: nodejs#47336
PR-URL: nodejs#45569 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Backport-PR-URL: nodejs#47336
nodejs-github-bot
commented
Apr 3, 2023
Collaborator
Review requested:
|
panvaforce-pushed
the
backport-46067-to-v16.x
branch
from
April 3, 2023 12:48
9d0fdf7 to
15c3756CompareWebCryptoAPI functions' arguments are now coersed and validated as per their WebIDL definitions like in other Web Crypto API implementations. This further improves interoperability with other implementations of Web Crypto API. PR-URL: nodejs#46067 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Backport-PR-URL: nodejs#47383
PR-URL: nodejs#46563 Reviewed-By: James M Snell <jasnell@gmail.com> Backport-PR-URL: nodejs#47383
panvaforce-pushed
the
backport-46067-to-v16.x
branch
from
April 18, 2023 12:34
15c3756 to
203e269Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like #46252 but for v16.x
Backports #46067 (and its followup #46563), which is semver-majorPRs that contain breaking changes and should be released in the next major version.
chilling in Issues and PRs related to experimental features.
.
mainuntil the 20.0.0 release in April, to v16.x where WebCryptoAPI is still experimentalnotable-changePRs with changes that should be highlighted in changelogs.
summary
Web Crypto API functions' arguments are now coerced and validated as per their WebIDL definitions like in other Web Crypto API implementations.
This further improves interoperability with other implementations of Web Crypto API.
blockedPRs that are blocked by other issues or PRs.
, waiting with the backport until the changes land on a v20.x and v18.x release