wasi: make returnOnExit true by default by mhdawson · Pull Request #47390 · nodejs/node

mhdawson · 2023-04-03T19:43:06Z

nodejs-github-bot · 2023-04-03T19:43:11Z

Review requested:

@nodejs/wasi

mhdawson · 2023-04-03T19:43:47Z

We agreed in #46923 that even though this is breaking, since wasi is still experimental we will mark it as SemVer minor but not backport to LTS versions earlier that 20.x

richardlau · 2023-04-03T19:47:52Z

This shouldn't be titled with "doc" subsystem -- it's an actual functional change.

mhdawson · 2023-04-03T22:04:05Z

@richardlau fixed.

cjihrig · 2023-04-04T14:17:13Z

Should we be setting this to 'true' as well if it is specified? It might be enough to do this since the environment variables will be strings in the child process:
if('returnOnExit'inoptions){opts.env.RETURN_ON_EXIT=options.returnOnExit;}
Note - if for whatever reason that doesn't work, we can do String(options.returnOnExit) on the right hand side of the assignment.

I did not do that originally since true is the default, but it would be more complete. Will update.

pushed commit to do that.

nodejs-github-bot · 2023-04-05T15:16:07Z

CI: https://ci.nodejs.org/job/node-test-pull-request/50973/

nodejs-github-bot · 2023-04-05T19:45:36Z

CI: https://ci.nodejs.org/job/node-test-pull-request/50985/

nodejs-github-bot · 2023-04-06T15:14:14Z

CI: https://ci.nodejs.org/job/node-test-pull-request/51015/

mhdawson · 2023-04-06T20:49:16Z

Please don't land this until after #47391 lands as we want 47391 to make it into Node.js 20 and I'm not sure if there will be conflicts betwen the 2. If there are I'd prefer to get 47391 landed and then rebase this PR

mhdawson · 2023-04-06T22:06:02Z

Rebased, will start new CI

nodejs-github-bot · 2023-04-06T23:17:44Z

CI: https://ci.nodejs.org/job/node-test-pull-request/51027/

Refs: nodejs#46923 Signed-off-by: Michael Dawson <mdawson@devrus.com>

Co-authored-by: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>

Co-authored-by: Colin Ihrig <cjihrig@gmail.com>

Co-authored-by: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>

Signed-off-by: Michael Dawson <mdawson@devrus.com>

mhdawson · 2023-04-06T23:51:41Z

guessing using the UI did not work, will fix then force push

nodejs-github-bot · 2023-04-07T00:46:59Z

CI: https://ci.nodejs.org/job/node-test-pull-request/51030/

nodejs-github-bot · 2023-04-11T17:32:42Z

CI: https://ci.nodejs.org/job/node-test-pull-request/51138/

Refs: #46923 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #47390 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>

mhdawson · 2023-04-11T20:36:38Z

Landed in 56ccd59

Refs: #46923 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #47390 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>

Notable changes: assert: * deprecate `CallTracker` (Moshe Atlow) #47740 crypto: * update root certificates to NSS 3.89 (Node.js GitHub Bot) #47659 dns: * (SEMVER-MINOR) expose `getDefaultResultOrder` (btea) #46973 doc: * add KhafraDev to collaborators (Matthew Aitken) #47510 fs: * (SEMVER-MINOR) add `recursive` option to `readdir` and `opendir` (Ethan Arrowood) #41439 * (SEMVER-MINOR) add support for `mode` flag to specify the copy behavior of the `cp` methods (Tetsuharu Ohzeki) #47084 http: * (SEMVER-MINOR) add `highWaterMark` option `http.createServer` (HinataKah0) #47405 stream: * (SEMVER-MINOR) preserve object mode in `compose` (Raz Luvaton) #47413 test_runner: * (SEMVER-MINOR) add `testNamePatterns` to `run` API (Chemi Atlow) #47648 * (SEMVER-MINOR) execute `before` hook on test (Chemi Atlow) #47586 * (SEMVER-MINOR) support combining coverage reports (Colin Ihrig) #47686 wasi: * (SEMVER-MINOR) make `returnOnExit` true by default (Michael Dawson) #47390 PR-URL: #47820

Notable changes: assert: * deprecate `CallTracker` (Moshe Atlow) #47740 crypto: * update root certificates to NSS 3.89 (Node.js GitHub Bot) #47659 dns: * (SEMVER-MINOR) expose `getDefaultResultOrder` (btea) #46973 doc: * add KhafraDev to collaborators (Matthew Aitken) #47510 fs: * (SEMVER-MINOR) add `recursive` option to `readdir` and `opendir` (Ethan Arrowood) #41439 * (SEMVER-MINOR) add support for `mode` flag to specify the copy behavior of the `cp` methods (Tetsuharu Ohzeki) #47084 http: * (SEMVER-MINOR) add `highWaterMark` option `http.createServer` (HinataKah0) #47405 stream: * (SEMVER-MINOR) preserve object mode in `compose` (Raz Luvaton) #47413 test_runner: * (SEMVER-MINOR) add `testNamePatterns` to `run` API (Chemi Atlow) #47628 * (SEMVER-MINOR) execute `before` hook on test (Chemi Atlow) #47586 * (SEMVER-MINOR) support combining coverage reports (Colin Ihrig) #47686 wasi: * (SEMVER-MINOR) make `returnOnExit` true by default (Michael Dawson) #47390 PR-URL: #47820

nodejs-github-bot added needs-ci PRs that need a full CI run. wasi Issues and PRs related to the WebAssembly System Interface. labels Apr 3, 2023

mhdawson added semver-minor PRs that contain new features and should be released in the next minor version. dont-land-on-v19.x labels Apr 3, 2023

mhdawson mentioned this pull request Apr 3, 2023
wasi: make version non-optional #47391
Closed

mhdawson force-pushed the uvwasi-exit-default branch from 78475e5 to d8ce188Compare April 3, 2023 22:03

mhdawson changed the title ~~doc: make returnOnExit true by default~~wasi: make returnOnExit true by defaultApr 3, 2023

richardlau approved these changes Apr 3, 2023
View reviewed changes

VoltrexKeyva reviewed Apr 4, 2023
View reviewed changes

Comment threaddoc/api/wasi.md Outdated
Comment threaddoc/api/wasi.md Outdated
Comment threadlib/wasi.js Outdated
Comment threadlib/wasi.js Outdated

guybedford approved these changes Apr 4, 2023
View reviewed changes

cjihrig approved these changes Apr 4, 2023
View reviewed changes

tniessen approved these changes Apr 4, 2023
View reviewed changes

mhdawson added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 5, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 5, 2023

mhdawson added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 6, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 6, 2023

wasi: make returnOnExit true by default
5583c30
Refs: nodejs#46923 Signed-off-by: Michael Dawson <mdawson@devrus.com>

mhdawsonand others added 6 commits April 6, 2023 19:44

Update doc/api/wasi.md
35eb47b
Co-authored-by: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>

Update doc/api/wasi.md
ba8fc08
Co-authored-by: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>

Update test/wasi/test-wasi.js
76470ca
Co-authored-by: Colin Ihrig <cjihrig@gmail.com>

Update lib/wasi.js
99d8a2f
Co-authored-by: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>

Update lib/wasi.js
1437def
Co-authored-by: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>

squash: address comments
773abe5
Signed-off-by: Michael Dawson <mdawson@devrus.com>

mhdawson force-pushed the uvwasi-exit-default branch from e4fb68c to 773abe5Compare April 7, 2023 00:08

mhdawson added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 7, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 7, 2023

jasnell approved these changes Apr 10, 2023
View reviewed changes

mhdawson closed this Apr 11, 2023

targos mentioned this pull request May 2, 2023
v20.1.0 release proposal #47820
Merged

Uh oh!

Uh oh!

Conversation

mhdawson commented Apr 3, 2023

Uh oh!

nodejs-github-bot commented Apr 3, 2023

Uh oh!

mhdawson commented Apr 3, 2023

Uh oh!

richardlau commented Apr 3, 2023

Uh oh!

mhdawson commented Apr 3, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cjihrigApr 4, 2023

Choose a reason for hiding this comment

Uh oh!

mhdawsonApr 4, 2023

Choose a reason for hiding this comment

Uh oh!

mhdawsonApr 4, 2023

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Apr 5, 2023

Uh oh!

nodejs-github-bot commented Apr 5, 2023

Uh oh!

nodejs-github-bot commented Apr 6, 2023

Uh oh!

mhdawson commented Apr 6, 2023

Uh oh!

mhdawson commented Apr 6, 2023

Uh oh!

nodejs-github-bot commented Apr 6, 2023

Uh oh!

mhdawson commented Apr 6, 2023

Uh oh!

nodejs-github-bot commented Apr 7, 2023

Uh oh!

nodejs-github-bot commented Apr 11, 2023

Uh oh!

mhdawson commented Apr 11, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants