test_runner: add testNamePatterns to run api by atlowChemi · Pull Request #47628 · nodejs/node

atlowChemi · 2023-04-19T22:29:54Z

Accept a testNamePatterns value in the run fn, and drill those patterns to the spawned processes.
Fixes: #46045

nodejs-github-bot · 2023-04-19T22:29:58Z

Review requested:

@nodejs/test_runner

Accept a `testNamePatterns` value in the `run` fn, and drill those patterns to the spawned processes. Fixes: nodejs#46045

nodejs-github-bot · 2023-04-21T10:20:54Z

CI: https://ci.nodejs.org/job/node-test-pull-request/51392/

nodejs-github-bot · 2023-04-22T21:06:11Z

CI: https://ci.nodejs.org/job/node-test-pull-request/51413/

nodejs-github-bot · 2023-04-23T05:55:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/51425/

nodejs-github-bot · 2023-04-23T06:53:39Z

CI: https://ci.nodejs.org/job/node-test-pull-request/51426/

nodejs-github-bot · 2023-04-23T10:07:42Z

Commit Queue failed

- Loading data for nodejs/node/pull/47628
✔ Done loading data for nodejs/node/pull/47628
----------------------------------- PR info ------------------------------------
Title test_runner: add testNamePatterns to run api (#47628)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch atlowChemi:test_runner--add-name-patterns-to-run-api -> nodejs:main
Labels author ready, needs-ci, dont-land-on-v14.x, test_runner
Commits 1
- test_runner: add testNamePatterns to run api
Committers 1
- atlowChemi PR-URL: https://github.com/nodejs/node/pull/47628
Fixes: https://github.com/nodejs/node/issues/46045
Reviewed-By: Moshe Atlow Reviewed-By: Benjamin Gruenbaum ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/47628
Fixes: https://github.com/nodejs/node/issues/46045
Reviewed-By: Moshe Atlow Reviewed-By: Benjamin Gruenbaum --------------------------------------------------------------------------------
ℹ This PR was created on Wed, 19 Apr 2023 22:29:54 GMT
✔ Approvals: 2
✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/47628#pullrequestreview-1394841197
✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/47628#pullrequestreview-1396865473
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2023-04-23T06:53:39Z: https://ci.nodejs.org/job/node-test-pull-request/51426/
- Querying data for job/node-test-pull-request/51426/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ No git cherry-pick in progress
✔ No git am in progress
✔ No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
* branch main -> FETCH_HEAD
✔ origin/main is now up-to-date
- Downloading patch for 47628
From https://github.com/nodejs/node
* branch refs/pull/47628/merge -> FETCH_HEAD
✔ Fetched commits as dbf71e509c72..dea691403b25
--------------------------------------------------------------------------------
[main 1735ca6b7d] test_runner: add testNamePatterns to run api
Author: atlowChemi Date: Thu Apr 20 00:16:57 2023 +0200
4 files changed, 63 insertions(+), 7 deletions(-)
create mode 100644 test/fixtures/test-runner/test/skip_by_name.cjs
✔ Patches applied
--------------------------------------------------------------------------------
✘ Git found no trailers in the original commit message, but 'Fixes: https://github.com/nodejs/node/issues/46045' is present and should be a trailer.

https://github.com/nodejs/node/actions/runs/4777711253

MoLow · 2023-04-23T12:31:35Z

Landed in c627969

benjamingr · 2023-04-23T15:37:49Z

Looks like this has the wrong PR-URL @MoLow - either force-push a fix and let people know or go over releases it's in later and fix references?

MoLow · 2023-04-23T15:42:04Z

@benjamingr it seems like there as been a commit pushed already

Accept a `testNamePatterns` value in the `run` fn, and drill those patterns to the spawned processes. PR-URL: #47648 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

atlowChemi · 2023-04-23T16:20:45Z

@MoLow The issue was not auto-closed FYI

Notable changes: assert: * deprecate `CallTracker` (Moshe Atlow) #47740 crypto: * update root certificates to NSS 3.89 (Node.js GitHub Bot) #47659 dns: * (SEMVER-MINOR) expose `getDefaultResultOrder` (btea) #46973 doc: * add KhafraDev to collaborators (Matthew Aitken) #47510 fs: * (SEMVER-MINOR) add `recursive` option to `readdir` and `opendir` (Ethan Arrowood) #41439 * (SEMVER-MINOR) add support for `mode` flag to specify the copy behavior of the `cp` methods (Tetsuharu Ohzeki) #47084 http: * (SEMVER-MINOR) add `highWaterMark` option `http.createServer` (HinataKah0) #47405 stream: * (SEMVER-MINOR) preserve object mode in `compose` (Raz Luvaton) #47413 test_runner: * (SEMVER-MINOR) add `testNamePatterns` to `run` API (Chemi Atlow) #47628 * (SEMVER-MINOR) execute `before` hook on test (Chemi Atlow) #47586 * (SEMVER-MINOR) support combining coverage reports (Colin Ihrig) #47686 wasi: * (SEMVER-MINOR) make `returnOnExit` true by default (Michael Dawson) #47390 PR-URL: #47820

nodejs-github-bot added dont-land-on-v14.x needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Apr 19, 2023

atlowChemi force-pushed the test_runner--add-name-patterns-to-run-api branch from 3fb7c7e to c7c46e2Compare April 19, 2023 22:34

ljharb reviewed Apr 19, 2023
View reviewed changes

Comment threadlib/internal/test_runner/runner.js Outdated
Comment threadlib/internal/test_runner/runner.js Outdated

atlowChemi force-pushed the test_runner--add-name-patterns-to-run-api branch from c7c46e2 to fa9f118Compare April 20, 2023 05:06

atlowChemi marked this pull request as ready for review April 20, 2023 05:06

atlowChemi force-pushed the test_runner--add-name-patterns-to-run-api branch from fa9f118 to 72137fdCompare April 20, 2023 08:36

MoLow reviewed Apr 20, 2023
View reviewed changes

Comment threadtest/parallel/test-runner-run.mjs Outdated
Comment threadlib/internal/test_runner/runner.js Outdated

test_runner: add testNamePatterns to run api
dea6914
Accept a `testNamePatterns` value in the `run` fn, and drill those patterns to the spawned processes. Fixes: nodejs#46045

atlowChemi force-pushed the test_runner--add-name-patterns-to-run-api branch from 72137fd to dea6914Compare April 20, 2023 15:59

MoLow approved these changes Apr 20, 2023
View reviewed changes

MoLow requested a review from benjamingr April 21, 2023 10:11

MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 21, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 21, 2023

benjamingr approved these changes Apr 23, 2023
View reviewed changes

MoLow added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 23, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 23, 2023

MoLow added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 23, 2023

MoLow closed this Apr 23, 2023

atlowChemi deleted the test_runner--add-name-patterns-to-run-api branch April 23, 2023 14:06

This was referenced Apr 24, 2023
CI Reliability 2023-04-24 nodejs/reliability#545
Open
CI Reliability 2023-04-25 nodejs/reliability#546
Open
CI Reliability 2023-04-26 nodejs/reliability#547
Open
CI Reliability 2023-04-27 nodejs/reliability#548
Open

targos added the semver-minor PRs that contain new features and should be released in the next minor version. label May 2, 2023

targos mentioned this pull request May 3, 2023
v20.1.0 release proposal #47820
Merged

Navigation Menu

Uh oh!

Uh oh!

test_runner: add testNamePatterns to run api - #47628

test_runner: add testNamePatterns to run api#47628
atlowChemi wants to merge 1 commit into
nodejs:mainfrom
atlowChemi:test_runner--add-name-patterns-to-run-api

atlowChemi commented Apr 19, 2023

Uh oh!

nodejs-github-bot commented Apr 19, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Apr 21, 2023

Uh oh!

nodejs-github-bot commented Apr 22, 2023

Uh oh!

nodejs-github-bot commented Apr 23, 2023

Uh oh!

nodejs-github-bot commented Apr 23, 2023

Uh oh!

nodejs-github-bot commented Apr 23, 2023

Uh oh!

MoLow commented Apr 23, 2023

Uh oh!

benjamingr commented Apr 23, 2023

Uh oh!

MoLow commented Apr 23, 2023

Uh oh!

atlowChemi commented Apr 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Uh oh!

Conversation

atlowChemi commented Apr 19, 2023

Uh oh!

nodejs-github-bot commented Apr 19, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Apr 21, 2023

Uh oh!

nodejs-github-bot commented Apr 22, 2023

Uh oh!

nodejs-github-bot commented Apr 23, 2023

Uh oh!

nodejs-github-bot commented Apr 23, 2023

Uh oh!

nodejs-github-bot commented Apr 23, 2023

Uh oh!

MoLow commented Apr 23, 2023

Uh oh!

benjamingr commented Apr 23, 2023

Uh oh!

MoLow commented Apr 23, 2023

Uh oh!

atlowChemi commented Apr 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants