tools: add node-pty as a dependency

[MoLow]

this is another followup for #47498 enabling running pseudo-tty snapshot tests using https://github.com/microsoft/node-pty
see #47793 (comment) for the reasoning behind this change

[nodejs-github-bot]

Review requested:

• @nodejs/actions
• @nodejs/gyp
• @nodejs/test_runner

[anonrig]

@MoLow Can you add an eslint rule to inhibit requiring/using node-pty inside lib folder?

[anonrig]

License file is missing

[anonrig]

Can you add a comment to this line and explain what it does?

[anonrig]

Why did we have to change the ordering of this transform? Would it be helpful to document this with a comment?

[mscdex]

To avoid confusion with actual deps/ directory changes, I think tools: would be a more appropriate commit message prefix.

[MoLow]

License file is missing

I think that is relevant for deps, not for tools, see #47793 (comment)
(the license file itself exists but is not exposed, which is ok)

[tniessen]

Could you explain what problem node-pty solves here, and how it worked before?

[tniessen]

Should probably be updated.

[MoLow]

why? it still returns Promise<void>

[tniessen]

Huh, either GitHub or myself messed up the reference. I meant to select the entire doc comment, not just the @returns line. Specifically, shouldn't a @param be added?

[MoLow]

Could you explain what problem node-pty solves here, and how it worked before?

Sure. the current pseudo-tty test suite uses an equivilent implementation for this from python:

node/test/pseudo-tty/pty_helper.py

Line 3 in d225d95

importpty

as part of the effort of migrating the message tests to use common.assertSnapshot this will allow running as any other test under tests/parallel.

common.assertSnapshot has a few advantages over the current python snapshot tests (it is faster, the producing snapshots is not doen maually so it is both easier and deterministic)

[MoLow]

@nodejs/node-api any idea why the build is failing on mac? https://github.com/nodejs/node/actions/runs/4846084398/jobs/8635397424

[benjamingr]

 ^
../src/unix/pty.cc:669:10: error: use of undeclared identifier 'openpty'
return openpty(amaster, aslave, name, (termios *)termp, (winsize *)winp);
^
../src/unix/pty.cc:717:10: error: use of undeclared identifier 'forkpty'
return forkpty(amaster, name, (termios *)termp, (winsize *)winp);
^

[MoLow]

closing in favor of #47803, wich is much simpler