Skip to content

test: migrate a pseudo_tty test to use assertSnapshot - #47803

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
MoLow:migrate-psuedo-tty
May 4, 2023
Merged

test: migrate a pseudo_tty test to use assertSnapshot#47803
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
MoLow:migrate-psuedo-tty

Conversation

@MoLow

@MoLowMoLow commented May 1, 2023

Copy link
Copy Markdown
Member

this is another followup for #47498 enabling running pseudo-tty snapshot tests

@nodejs-github-bot

nodejs-github-bot commented May 1, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

@MoLow
MoLow marked this pull request as draft May 1, 2023 18:01
@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels May 1, 2023
@MoLowMoLow mentioned this pull request May 1, 2023
Closed
@MoLow
MoLowforce-pushed the migrate-psuedo-tty branch from 5580260 to d086cf1CompareMay 1, 2023 20:05
@MoLow
MoLow marked this pull request as ready for review May 1, 2023 20:06
ljharb
ljharb reviewed May 1, 2023
View reviewed changes
Comment threadtest/common/assertSnapshot.js Outdated
@MoLow
MoLowforce-pushed the migrate-psuedo-tty branch from d086cf1 to e64ee0eCompareMay 1, 2023 20:30
GeoffreyBooth
GeoffreyBooth approved these changes May 1, 2023
View reviewed changes
Comment threadtest/common/assertSnapshot.js Outdated
Comment threadtest/fixtures/test-runner/output/default_output.snapshot Outdated

@GeoffreyBoothGeoffreyBoothMay 1, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we run these with ANSI colors support disabled to make easier-to-read snapshots?

@MoLowMoLowMay 2, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the entire purpose of this test is to test the colors and the reporter

Comment threadtest/parallel/test-runner-output.mjs Outdated
@MoLow
MoLowforce-pushed the migrate-psuedo-tty branch 2 times, most recently from b6f9dfd to 12913f5CompareMay 2, 2023 05:21
@MoLowMoLow changed the title test: migrate pseudo_tty tests to use assertSnapshottest: migrate a pseudo_tty test to use assertSnapshotMay 2, 2023
@MoLow
MoLowforce-pushed the migrate-psuedo-tty branch from 12913f5 to db53913CompareMay 2, 2023 05:36
@MoLowMoLow added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 2, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 2, 2023
@nodejs-github-bot

nodejs-github-bot commented May 2, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51569/

@github-actionsgithub-actionsBot mentioned this pull request May 3, 2023
Open
33 tasks
@MoLow

MoLow commented May 3, 2023

Copy link
Copy Markdown
MemberAuthor

I spend hours to get a working Windows environment to figure out why tests were failing when it turns out this is the original behavior 😂 :

node/test/pseudo-tty/testcfg.py

Lines 143 to 145 in 76ae7be

ifutils.IsWindows():
print ("Skipping pseudo-tty tests, as pseudo terminals are not available"
" on Windows.")

@MoLowMoLow added the request-ci Add this label to start a Jenkins CI on a PR. label May 3, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 3, 2023
@nodejs-github-bot

nodejs-github-bot commented May 3, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51616/

@github-actionsgithub-actionsBot mentioned this pull request May 4, 2023
Open
28 tasks
@benjamingrbenjamingr added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels May 4, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 4, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 9e5e2f1 into nodejs:mainMay 4, 2023
@nodejs-github-bot

nodejs-github-bot commented May 4, 2023

Copy link
Copy Markdown
Collaborator

Landed in 9e5e2f1

@MoLow
MoLow deleted the migrate-psuedo-tty branch May 4, 2023 08:57
@github-actionsgithub-actionsBot mentioned this pull request May 5, 2023
Open
22 tasks
targos pushed a commit that referenced this pull request May 12, 2023
@MoLow@targos
test: migrate a pseudo_tty test to use assertSnapshot
17945a2
PR-URL: #47803
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@targostargos mentioned this pull request May 15, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@MoLow@danielleadams
test: migrate a pseudo_tty test to use assertSnapshot
afb85df
PR-URL: #47803
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MoLow added a commit to MoLow/node that referenced this pull request Jul 6, 2023
@MoLow
test: migrate a pseudo_tty test to use assertSnapshot
95972aa
PR-URL: nodejs#47803
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharbljharbljharb left review comments
@GeoffreyBoothGeoffreyBoothGeoffreyBooth approved these changes
@benjamingrbenjamingrbenjamingr approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.needs-ciPRs that need a full CI run.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MoLow@nodejs-github-bot@ljharb@GeoffreyBooth@benjamingr