Uh oh!
There was an error while loading. Please reload this page.
[v18.x backport] net: fix address iteration with autoSelectFamily - #48275
Closed
juanarbol wants to merge 3 commits into
Closed
[v18.x backport] net: fix address iteration with autoSelectFamily#48275juanarbol wants to merge 3 commits into
juanarbol wants to merge 3 commits into
Conversation
nodejs-github-bot
commented
May 31, 2023
Collaborator
Review requested:
|
juanarbolforce-pushed
the
backport-48258-to-v18
branch
from
May 31, 2023 22:02
8132828 to
d8f15d5Comparejuanarbol
marked this pull request as ready for review
May 31, 2023 22:03
nodejs-github-bot
commented
May 31, 2023
Collaborator
juanarbol
commented
May 31, 2023
MemberAuthor
Hey @indutny@ShogunPanda, I believe the introduced test for #48258 is covered by this, https://github.com/nodejs/node/pull/48275/files#diff-c97855fe951a3d9c4319418be09b97f6c2700565dbc65c47adfb3f520e8759e6R175 right? |
ShogunPanda
commented
Jun 2, 2023
Contributor
@juanarbol Nope, it's not. That test only included those addresses already in order, so there was no verification the attempt order was correct. In #48258 a test has been specifically included to verify the behavior. |
juanarbolforce-pushed
the
backport-48258-to-v18
branch
from
June 7, 2023 01:24
d8f15d5 to
4a90fbdComparejuanarbolforce-pushed
the
backport-48258-to-v18
branch
from
June 7, 2023 01:26
4a90fbd to
2d6a8c6Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
juanarbol
commented
Jun 7, 2023
MemberAuthor
@ShogunPanda PTAL :-) |
This comment was marked as outdated.
This comment was marked as outdated.
juanarbol
commented
Jun 7, 2023
MemberAuthor
This is hitting known flakes, see: #48300 |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
ShogunPanda
approved these changes
Jun 8, 2023
This comment was marked as outdated.
This comment was marked as outdated.
juanarbol
commented
Jun 8, 2023
MemberAuthor
I don't think CI will be happy until the windows issue is solved; most jobs fail at this point. I prefer to wait for a bit more to kick a CI again. Or feel free to retry if needed. |
This was referenced Jun 9, 2023
This was referenced Jul 9, 2023
juanarbol
commented
Jul 11, 2023
MemberAuthor
juanarbolforce-pushed
the
backport-48258-to-v18
branch
from
July 13, 2023 15:48
e4e363e to
f1f6b38Comparenodejs-github-bot
commented
Jul 13, 2023
Collaborator
This was referenced Jul 16, 2023
PR-URL: nodejs#45777 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
PR-URL: nodejs#47860 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
When `autoSelectFamily` is set to `true`, `net.connect` is supposed to try connecting to both IPv4 and IPv6, interleaving the address types. Instead, it appears that the array that holds the addresses in the order they should be attempted was never used after being populated. PR-URL: nodejs#48258 Backport-PR-URL: nodejs#48275 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
juanarbolforce-pushed
the
backport-48258-to-v18
branch
from
July 17, 2023 01:45
f1f6b38 to
f0d848aComparenodejs-github-bot
commented
Jul 17, 2023
Collaborator
nodejs-github-bot
commented
Jul 17, 2023
Collaborator
nodejs-github-bot
commented
Jul 17, 2023
Collaborator
This was referenced Jul 18, 2023
mhdawson pushed a commit
to mhdawson/io.js
that referenced
this pull request
Jul 26, 2023
When `autoSelectFamily` is set to `true`, `net.connect` is supposed to try connecting to both IPv4 and IPv6, interleaving the address types. Instead, it appears that the array that holds the addresses in the order they should be attempted was never used after being populated. PR-URL: nodejs#48258 Backport-PR-URL: nodejs#48275 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
mhdawson pushed a commit
to mhdawson/io.js
that referenced
this pull request
Aug 4, 2023
When `autoSelectFamily` is set to `true`, `net.connect` is supposed to try connecting to both IPv4 and IPv6, interleaving the address types. Instead, it appears that the array that holds the addresses in the order they should be attempted was never used after being populated. PR-URL: nodejs#48258 Backport-PR-URL: nodejs#48275 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
ruyadorno
commented
Aug 14, 2023
Member
Thanks @juanarbol for the work here! @mhdawson helped get a few more commits in and it landed as part of the follow backport #49016 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
autoSelectFamilyis set totrue,net.connectis supposed totry connecting to both IPv4 and IPv6, interleaving the address types.
Instead, it appears that the array that holds the addresses in the order
they should be attempted was never used after being populated.
PR-URL: #48258
Backport-PR-URL: #48275
Reviewed-By: Paolo Insogna paolo@cowtech.it
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: Tobias Nießen tniessen@tnie.de
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Juan José Arboleda soyjuanarbol@gmail.com
This also includes the backport of #45777 which is required for this :)