Skip to content

net: add autoSelectFamily global getter and setter - #45777

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
ShogunPanda:autoselectfamily-improvements
Dec 24, 2022
Merged

net: add autoSelectFamily global getter and setter#45777
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
ShogunPanda:autoselectfamily-improvements

Conversation

@ShogunPanda

@ShogunPandaShogunPanda commented Dec 7, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

This PR continues #44731 by adding the following new APIs:

  • net.Socket.autoSelectFamilyAttemptedAddresses: It contains a list of all the addresses that were attempted when using the Happy Eyeballs algorithm.
  • net.setDefaultAutoSelectFamily and net.getDefaultAutoSelectFamily: Sets or gets the default for autoSelectFamily for net.connect. This can also be enabled by the command line option --enable-network-family-autoselection.

@nodejs-github-bot

nodejs-github-bot commented Dec 7, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/net

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem. labels Dec 7, 2022
@ShogunPanda
ShogunPandaforce-pushed the autoselectfamily-improvements branch 3 times, most recently from 58f423b to 9fdf538CompareDecember 7, 2022 20:39
@addaleax

addaleax commented Dec 7, 2022

Copy link
Copy Markdown
Member

Should this be a command line flag? Those are inherited by Workers by default, for example.

@mcollina

mcollina commented Dec 7, 2022

Copy link
Copy Markdown
Member

I think adding a command line flag for this would be useful too.

@ShogunPanda
ShogunPandaforce-pushed the autoselectfamily-improvements branch from 9fdf538 to 2efd797CompareDecember 8, 2022 11:10
@ShogunPanda

ShogunPanda commented Dec 8, 2022

Copy link
Copy Markdown
ContributorAuthor

@mcollina@addaleax CLI option added!

mcollina
mcollina approved these changes Dec 13, 2022
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollinamcollina added notable-change PRs with changes that should be highlighted in changelogs. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 13, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 13, 2022
@nodejs-github-bot

nodejs-github-bot commented Dec 13, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48443/

@nodejs-github-bot

nodejs-github-bot commented Dec 14, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48467/

@nodejs-github-bot

nodejs-github-bot commented Dec 14, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48475/

This was referenced Dec 15, 2022
Open
Open
Open
Open
@ShogunPanda
ShogunPandaforce-pushed the autoselectfamily-improvements branch from 2efd797 to 0cc09d7CompareDecember 23, 2022 08:38
@ShogunPandaShogunPanda added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 23, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 23, 2022
@nodejs-github-bot

nodejs-github-bot commented Dec 23, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48708/

@nodejs-github-bot

nodejs-github-bot commented Dec 23, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48711/

@deokjinkimdeokjinkim mentioned this pull request Apr 11, 2023
Merged
@juanarboljuanarbol mentioned this pull request May 31, 2023
Closed
@treysis

treysis commented Jun 7, 2023

Copy link
Copy Markdown
Contributor

This depends on #45057 to land cleanly in v18.x

Sooo, since #45057 and its 18.x backport #45994 (via 0d5e324) have made it into 18, can also this PR make it into 18.x?

juanarbol pushed a commit to juanarbol/node that referenced this pull request Jul 17, 2023
@ShogunPanda@juanarbol
net: add autoSelectFamily global getter and setter
b209f20
PR-URL: nodejs#45777
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
mhdawson pushed a commit to mhdawson/io.js that referenced this pull request Jul 26, 2023
@ShogunPanda@mhdawson
net: add autoSelectFamily global getter and setter
62266db
PR-URL: nodejs#45777
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
mhdawson pushed a commit to mhdawson/io.js that referenced this pull request Aug 4, 2023
@ShogunPanda@mhdawson
net: add autoSelectFamily global getter and setter
00cb23a
PR-URL: nodejs#45777
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
ruyadorno pushed a commit that referenced this pull request Aug 14, 2023
@ShogunPanda@ruyadorno
net: add autoSelectFamily global getter and setter
863bdb7
PR-URL: #45777
Backport-PR-URL: #49016
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
ruyadorno added a commit that referenced this pull request Aug 17, 2023
@ruyadorno
2023-08-29, Version 18.18.0 'Hydrogen' (LTS)
7c0d61f
Notable changes:
net:
* add autoSelectFamily global getter and setter (Paolo Insogna) #45777
PR-URL: TODO
@ruyadornoruyadorno mentioned this pull request Aug 17, 2023
Merged
ruyadorno added a commit that referenced this pull request Aug 29, 2023
@ruyadorno
2023-09-12, Version 18.18.0 'Hydrogen' (LTS)
5970012
Notable changes:
net:
* add autoSelectFamily global getter and setter (Paolo Insogna) #45777
PR-URL: #49220
ruyadorno added a commit that referenced this pull request Sep 1, 2023
@ruyadorno
2023-09-14, Version 18.18.0 'Hydrogen' (LTS)
00648b2
Notable changes:
net:
* add autoSelectFamily global getter and setter (Paolo Insogna) #45777
PR-URL: TODO
ruyadorno added a commit that referenced this pull request Sep 6, 2023
@ruyadorno
2023-09-14, Version 18.18.0 'Hydrogen' (LTS)
3e10b5e
Notable changes:
net:
* add autoSelectFamily global getter and setter (Paolo Insogna) #45777
url:
* (SEMVER-MINOR) add value argument to has and delete methods (Sankalp Shubham) #47885
PR-URL: #49220
ruyadorno added a commit that referenced this pull request Sep 8, 2023
@ruyadorno
2023-09-14, Version 18.18.0 'Hydrogen' (LTS)
9f6929d
Notable changes:
crypto:
* update root certificates to NSS 3.90 (Node.js GitHub Bot) #48416
doc:
* add kvakil to collaborators (Keyhan Vakil) #48449
esm:
* (SEMVER-MINOR) add `--import` flag (Moshe Atlow) #43942
net:
* add autoSelectFamily global getter and setter (Paolo Insogna) #45777
url:
* (SEMVER-MINOR) add value argument to has and delete methods (Sankalp Shubham) #47885
PR-URL: #49220
ruyadorno added a commit that referenced this pull request Sep 10, 2023
@ruyadorno
2023-09-14, Version 18.18.0 'Hydrogen' (LTS)
6ddb80c
Notable changes:
crypto:
* update root certificates to NSS 3.90 (Node.js GitHub Bot) #48416
doc:
* add vmoroz to collaborators (Vladimir Morozov) #48527
* add kvakil to collaborators (Keyhan Vakil) #48449
esm:
* (SEMVER-MINOR) add `--import` flag (Moshe Atlow) #43942
net:
* add autoSelectFamily global getter and setter (Paolo Insogna) #45777
url:
* (SEMVER-MINOR) add value argument to has and delete methods (Sankalp Shubham) #47885
PR-URL: #49220
ruyadorno added a commit that referenced this pull request Sep 11, 2023
@ruyadorno
2023-09-14, Version 18.18.0 'Hydrogen' (LTS)
1186fdb
Notable changes:
crypto:
* update root certificates to NSS 3.90 (Node.js GitHub Bot) #48416
doc:
* add vmoroz to collaborators (Vladimir Morozov) #48527
* add kvakil to collaborators (Keyhan Vakil) #48449
esm:
* (SEMVER-MINOR) add `--import` flag (Moshe Atlow) #43942
events:
* (SEMVER-MINOR) allow safely adding listener to abortSignal (Chemi Atlow) #48596
net:
* add autoSelectFamily global getter and setter (Paolo Insogna) #45777
url:
* (SEMVER-MINOR) add value argument to has and delete methods (Sankalp Shubham) #47885
PR-URL: #49220
ruyadorno added a commit that referenced this pull request Sep 11, 2023
@ruyadorno
2023-09-14, Version 18.18.0 'Hydrogen' (LTS)
7c96325
Notable changes:
build:
* sync libuv header change (Jiawen Geng) #48078
crypto:
* update root certificates to NSS 3.90 (Node.js GitHub Bot) #48416
deps:
* add missing thread-common.c in uv.gyp (Santiago Gimeno) #48078
* upgrade to libuv 1.46.0 (Santiago Gimeno) #48078
* upgrade to libuv 1.45.0 (Santiago Gimeno) #48078
doc:
* add vmoroz to collaborators (Vladimir Morozov) #48527
* add kvakil to collaborators (Keyhan Vakil) #48449
esm:
* (SEMVER-MINOR) add `--import` flag (Moshe Atlow) #43942
events:
* (SEMVER-MINOR) allow safely adding listener to abortSignal (Chemi Atlow) #48596
fs, stream:
* initial `Symbol.dispose` and `Symbol.asyncDispose` support (Moshe Atlow) #48518
net:
* add autoSelectFamily global getter and setter (Paolo Insogna) #45777
url:
* (SEMVER-MINOR) add value argument to has and delete methods (Sankalp Shubham) #47885
PR-URL: #49220
ruyadorno added a commit that referenced this pull request Sep 12, 2023
@ruyadorno
2023-09-14, Version 18.18.0 'Hydrogen' (LTS)
89e7fd1
Notable changes:
build:
* sync libuv header change (Jiawen Geng) #48078
crypto:
* update root certificates to NSS 3.93 (Node.js GitHub Bot) #49341
* update root certificates to NSS 3.90 (Node.js GitHub Bot) #48416
deps:
* add missing thread-common.c in uv.gyp (Santiago Gimeno) #48078
* upgrade to libuv 1.46.0 (Santiago Gimeno) #48078
* upgrade to libuv 1.45.0 (Santiago Gimeno) #48078
doc:
* add atlowChemi to collaborators (atlowChemi) #48757
* add vmoroz to collaborators (Vladimir Morozov) #48527
* add kvakil to collaborators (Keyhan Vakil) #48449
esm:
* (SEMVER-MINOR) add `--import` flag (Moshe Atlow) #43942
events:
* (SEMVER-MINOR) allow safely adding listener to abortSignal (Chemi Atlow) #48596
fs, stream:
* initial `Symbol.dispose` and `Symbol.asyncDispose` support (Moshe Atlow) #48518
net:
* add autoSelectFamily global getter and setter (Paolo Insogna) #45777
url:
* (SEMVER-MINOR) add value argument to has and delete methods (Sankalp Shubham) #47885
PR-URL: #49220
ruyadorno added a commit that referenced this pull request Sep 13, 2023
@ruyadorno
2023-09-14, Version 18.18.0 'Hydrogen' (LTS)
e873eef
Notable changes:
build:
* sync libuv header change (Jiawen Geng) #48078
crypto:
* update root certificates to NSS 3.93 (Node.js GitHub Bot) #49341
* update root certificates to NSS 3.90 (Node.js GitHub Bot) #48416
deps:
* add missing thread-common.c in uv.gyp (Santiago Gimeno) #48078
* upgrade to libuv 1.46.0 (Santiago Gimeno) #48078
* upgrade to libuv 1.45.0 (Santiago Gimeno) #48078
doc:
* add atlowChemi to collaborators (atlowChemi) #48757
* add vmoroz to collaborators (Vladimir Morozov) #48527
* add kvakil to collaborators (Keyhan Vakil) #48449
esm:
* (SEMVER-MINOR) add `--import` flag (Moshe Atlow) #43942
events:
* (SEMVER-MINOR) allow safely adding listener to abortSignal (Chemi Atlow) #48596
fs, stream:
* initial `Symbol.dispose` and `Symbol.asyncDispose` support (Moshe Atlow) #48518
net:
* add autoSelectFamily global getter and setter (Paolo Insogna) #45777
url:
* (SEMVER-MINOR) add value argument to has and delete methods (Sankalp Shubham) #47885
PR-URL: #49220
ruyadorno added a commit that referenced this pull request Sep 17, 2023
@ruyadorno
2023-09-18, Version 18.18.0 'Hydrogen' (LTS)
ab5fa2a
Notable changes:
build:
* sync libuv header change (Jiawen Geng) #48078
crypto:
* update root certificates to NSS 3.93 (Node.js GitHub Bot) #49341
* update root certificates to NSS 3.90 (Node.js GitHub Bot) #48416
deps:
* add missing thread-common.c in uv.gyp (Santiago Gimeno) #48078
* upgrade to libuv 1.46.0 (Santiago Gimeno) #48078
* upgrade to libuv 1.45.0 (Santiago Gimeno) #48078
doc:
* add atlowChemi to collaborators (atlowChemi) #48757
* add vmoroz to collaborators (Vladimir Morozov) #48527
* add kvakil to collaborators (Keyhan Vakil) #48449
esm:
* (SEMVER-MINOR) add `--import` flag (Moshe Atlow) #43942
events:
* (SEMVER-MINOR) allow safely adding listener to abortSignal (Chemi Atlow) #48596
fs, stream:
* initial `Symbol.dispose` and `Symbol.asyncDispose` support (Moshe Atlow) #48518
net:
* add autoSelectFamily global getter and setter (Paolo Insogna) #45777
url:
* (SEMVER-MINOR) add value argument to has and delete methods (Sankalp Shubham) #47885
PR-URL: #49220
ruyadorno added a commit that referenced this pull request Sep 18, 2023
@ruyadorno
2023-09-18, Version 18.18.0 'Hydrogen' (LTS)
78ab0ee
Notable changes:
build:
* sync libuv header change (Jiawen Geng) #48078
crypto:
* update root certificates to NSS 3.93 (Node.js GitHub Bot) #49341
* update root certificates to NSS 3.90 (Node.js GitHub Bot) #48416
deps:
* add missing thread-common.c in uv.gyp (Santiago Gimeno) #48078
* upgrade to libuv 1.46.0 (Santiago Gimeno) #48078
* upgrade to libuv 1.45.0 (Santiago Gimeno) #48078
doc:
* add atlowChemi to collaborators (atlowChemi) #48757
* add vmoroz to collaborators (Vladimir Morozov) #48527
* add kvakil to collaborators (Keyhan Vakil) #48449
esm:
* (SEMVER-MINOR) add `--import` flag (Moshe Atlow) #43942
events:
* (SEMVER-MINOR) allow safely adding listener to abortSignal (Chemi Atlow) #48596
fs, stream:
* initial `Symbol.dispose` and `Symbol.asyncDispose` support (Moshe Atlow) #48518
net:
* add autoSelectFamily global getter and setter (Paolo Insogna) #45777
url:
* (SEMVER-MINOR) add value argument to has and delete methods (Sankalp Shubham) #47885
PR-URL: #49220
@lukekarryslukekarrys mentioned this pull request Oct 2, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@jasnelljasnellAwaiting requested review from jasnell
@ronagronagAwaiting requested review from ronag

Assignees

No one assigned

Labels

commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.netIssues and PRs related to the net subsystem.notable-changePRs with changes that should be highlighted in changelogs.semver-minorPRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@ShogunPanda@nodejs-github-bot@addaleax@mcollina@juanarbol@treysis@cjihrig@ruyadorno@RafaelGSS