Skip to content

doc: add kvakil to collaborators - #48449

Closed
kvakil wants to merge 1 commit into
nodejs:mainfrom
kvakil:add-kv-collab
Closed

doc: add kvakil to collaborators#48449
kvakil wants to merge 1 commit into
nodejs:mainfrom
kvakil:add-kv-collab

Conversation

@kvakil

@kvakilkvakil commented Jun 13, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

...and remove them triagers

Fixes: #48155

@kvakil
kvakil requested a review from joyeecheungJune 13, 2023 15:04
@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 13, 2023
@joyeecheungjoyeecheung added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 13, 2023
@kvakilkvakil added the notable-change PRs with changes that should be highlighted in changelogs. label Jun 13, 2023
@github-actions

github-actionsBot commented Jun 13, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @joyeecheung. Please 👍 to approve.

@github-actions

github-actionsBot commented Jun 13, 2023

Copy link
Copy Markdown
Contributor

The notable-changePRs with changes that should be highlighted in changelogs. label has been added by @kvakil.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment.

@nodejs-github-bot

nodejs-github-bot commented Jun 13, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52239/

aduh95
aduh95 approved these changes Jun 13, 2023
View reviewed changes

@aduh95aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we amend the commit message to doc: add kvakil to collaborators and remove them from triagers?

@kvakil
doc: add kvakil to collaborators
223df54
...and remove them triagers
Fixes: nodejs#48155
@joyeecheung

joyeecheung commented Jun 13, 2023

Copy link
Copy Markdown
Member

@aduh95 Can you give a thumbs up to the fast track request too? Thanks

kvakil added a commit that referenced this pull request Jun 13, 2023
@kvakil
doc: add kvakil to collaborators
3ce303c
...and remove them triagers
Fixes: #48155
PR-URL: #48449
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@kvakil

kvakil commented Jun 13, 2023

Copy link
Copy Markdown
ContributorAuthor

Landed in 3ce303c

@kvakilkvakil closed this Jun 13, 2023
joyeecheung pushed a commit to joyeecheung/node that referenced this pull request Jun 13, 2023
@kvakil@joyeecheung
doc: add kvakil to collaborators
7f0b268
...and remove them triagers
Fixes: nodejs#48155
PR-URL: nodejs#48449
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@kvakil@RafaelGSS
doc: add kvakil to collaborators
5cacdf9
...and remove them triagers
Fixes: #48155
PR-URL: #48449
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS added a commit that referenced this pull request Jul 3, 2023
@RafaelGSS
2023-07-04, Version 20.4.0 (Current)
e4e9f09
Notable changes:
crypto:
* update root certificates to NSS 3.90 (Node.js GitHub Bot) #48416
doc:
* add vmoroz to collaborators (Vladimir Morozov) #48527
* add kvakil to collaborators (Keyhan Vakil) #48449
fs, stream:
* initial `Symbol.dispose` and `Symbol.asyncDispose` support (Moshe Atlow) #48518
test_runner:
* (SEMVER-MINOR) add initial draft for fakeTimers (Erick Wendel) #47775
tls:
* (SEMVER-MINOR) add ALPNCallback server option for dynamic ALPN negotiation (Tim Perry) #45190
PR-URL: TODO
@RafaelGSSRafaelGSS mentioned this pull request Jul 3, 2023
Merged
RafaelGSS added a commit to RafaelGSS/node that referenced this pull request Jul 3, 2023
@RafaelGSS
2023-07-04, Version 20.4.0 (Current)
8bd825d
Notable changes:
crypto:
* update root certificates to NSS 3.90 (Node.js GitHub Bot) nodejs#48416
doc:
* add vmoroz to collaborators (Vladimir Morozov) nodejs#48527
* add kvakil to collaborators (Keyhan Vakil) nodejs#48449
fs, stream:
* initial `Symbol.dispose` and `Symbol.asyncDispose` support (Moshe Atlow) nodejs#48518
test_runner:
* (SEMVER-MINOR) add initial draft for fakeTimers (Erick Wendel) nodejs#47775
tls:
* (SEMVER-MINOR) add ALPNCallback server option for dynamic ALPN negotiation (Tim Perry) nodejs#45190
PR-URL: nodejs#48643
RafaelGSS added a commit that referenced this pull request Jul 3, 2023
@RafaelGSS
2023-07-04, Version 20.4.0 (Current)
51174cd
Notable changes:
crypto:
* update root certificates to NSS 3.90 (Node.js GitHub Bot) #48416
doc:
* add vmoroz to collaborators (Vladimir Morozov) #48527
* add kvakil to collaborators (Keyhan Vakil) #48449
fs, stream:
* initial `Symbol.dispose` and `Symbol.asyncDispose` support (Moshe Atlow) #48518
test_runner:
* (SEMVER-MINOR) add initial draft for fakeTimers (Erick Wendel) #47775
tls:
* (SEMVER-MINOR) add ALPNCallback server option for dynamic ALPN negotiation (Tim Perry) #45190
PR-URL: #48643
RafaelGSS added a commit to RafaelGSS/node that referenced this pull request Jul 4, 2023
@RafaelGSS
2023-07-05, Version 20.4.0 (Current)
73c632e
Notable changes:
crypto:
* update root certificates to NSS 3.90 (Node.js GitHub Bot) nodejs#48416
doc:
* add vmoroz to collaborators (Vladimir Morozov) nodejs#48527
* add kvakil to collaborators (Keyhan Vakil) nodejs#48449
fs, stream:
* initial `Symbol.dispose` and `Symbol.asyncDispose` support (Moshe Atlow) nodejs#48518
test_runner:
* (SEMVER-MINOR) add initial draft for fakeTimers (Erick Wendel) nodejs#47775
tls:
* (SEMVER-MINOR) add ALPNCallback server option for dynamic ALPN negotiation (Tim Perry) nodejs#45190
PR-URL: nodejs#48643
RafaelGSS added a commit that referenced this pull request Jul 5, 2023
@RafaelGSS
2023-07-05, Version 20.4.0 (Current)
8fc3851
Notable changes:
crypto:
* update root certificates to NSS 3.90 (Node.js GitHub Bot) #48416
doc:
* add vmoroz to collaborators (Vladimir Morozov) #48527
* add kvakil to collaborators (Keyhan Vakil) #48449
fs, stream:
* initial `Symbol.dispose` and `Symbol.asyncDispose` support (Moshe Atlow) #48518
test_runner:
* (SEMVER-MINOR) add initial draft for fakeTimers (Erick Wendel) #47775
tls:
* (SEMVER-MINOR) add ALPNCallback server option for dynamic ALPN negotiation (Tim Perry) #45190
PR-URL: #48643
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@kvakil@Ceres6
doc: add kvakil to collaborators
b6ec81e
...and remove them triagers
Fixes: nodejs#48155
PR-URL: nodejs#48449
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@RafaelGSS@Ceres6
2023-07-05, Version 20.4.0 (Current)
7fa148c
Notable changes:
crypto:
* update root certificates to NSS 3.90 (Node.js GitHub Bot) nodejs#48416
doc:
* add vmoroz to collaborators (Vladimir Morozov) nodejs#48527
* add kvakil to collaborators (Keyhan Vakil) nodejs#48449
fs, stream:
* initial `Symbol.dispose` and `Symbol.asyncDispose` support (Moshe Atlow) nodejs#48518
test_runner:
* (SEMVER-MINOR) add initial draft for fakeTimers (Erick Wendel) nodejs#47775
tls:
* (SEMVER-MINOR) add ALPNCallback server option for dynamic ALPN negotiation (Tim Perry) nodejs#45190
PR-URL: nodejs#48643
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@kvakil@Ceres6
doc: add kvakil to collaborators
76a5d03
...and remove them triagers
Fixes: nodejs#48155
PR-URL: nodejs#48449
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@RafaelGSS@Ceres6
2023-07-05, Version 20.4.0 (Current)
574f438
Notable changes:
crypto:
* update root certificates to NSS 3.90 (Node.js GitHub Bot) nodejs#48416
doc:
* add vmoroz to collaborators (Vladimir Morozov) nodejs#48527
* add kvakil to collaborators (Keyhan Vakil) nodejs#48449
fs, stream:
* initial `Symbol.dispose` and `Symbol.asyncDispose` support (Moshe Atlow) nodejs#48518
test_runner:
* (SEMVER-MINOR) add initial draft for fakeTimers (Erick Wendel) nodejs#47775
tls:
* (SEMVER-MINOR) add ALPNCallback server option for dynamic ALPN negotiation (Tim Perry) nodejs#45190
PR-URL: nodejs#48643
ruyadorno pushed a commit that referenced this pull request Sep 8, 2023
@kvakil@ruyadorno
doc: add kvakil to collaborators
d9ab855
...and remove them triagers
Fixes: #48155
PR-URL: #48449
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
ruyadorno added a commit that referenced this pull request Sep 8, 2023
@ruyadorno
2023-09-14, Version 18.18.0 'Hydrogen' (LTS)
9f6929d
Notable changes:
crypto:
* update root certificates to NSS 3.90 (Node.js GitHub Bot) #48416
doc:
* add kvakil to collaborators (Keyhan Vakil) #48449
esm:
* (SEMVER-MINOR) add `--import` flag (Moshe Atlow) #43942
net:
* add autoSelectFamily global getter and setter (Paolo Insogna) #45777
url:
* (SEMVER-MINOR) add value argument to has and delete methods (Sankalp Shubham) #47885
PR-URL: #49220
@ruyadornoruyadorno mentioned this pull request Sep 8, 2023
Merged
ruyadorno added a commit that referenced this pull request Sep 10, 2023
@ruyadorno
2023-09-14, Version 18.18.0 'Hydrogen' (LTS)
6ddb80c
Notable changes:
crypto:
* update root certificates to NSS 3.90 (Node.js GitHub Bot) #48416
doc:
* add vmoroz to collaborators (Vladimir Morozov) #48527
* add kvakil to collaborators (Keyhan Vakil) #48449
esm:
* (SEMVER-MINOR) add `--import` flag (Moshe Atlow) #43942
net:
* add autoSelectFamily global getter and setter (Paolo Insogna) #45777
url:
* (SEMVER-MINOR) add value argument to has and delete methods (Sankalp Shubham) #47885
PR-URL: #49220
ruyadorno added a commit that referenced this pull request Sep 11, 2023
@ruyadorno
2023-09-14, Version 18.18.0 'Hydrogen' (LTS)
1186fdb
Notable changes:
crypto:
* update root certificates to NSS 3.90 (Node.js GitHub Bot) #48416
doc:
* add vmoroz to collaborators (Vladimir Morozov) #48527
* add kvakil to collaborators (Keyhan Vakil) #48449
esm:
* (SEMVER-MINOR) add `--import` flag (Moshe Atlow) #43942
events:
* (SEMVER-MINOR) allow safely adding listener to abortSignal (Chemi Atlow) #48596
net:
* add autoSelectFamily global getter and setter (Paolo Insogna) #45777
url:
* (SEMVER-MINOR) add value argument to has and delete methods (Sankalp Shubham) #47885
PR-URL: #49220
ruyadorno added a commit that referenced this pull request Sep 11, 2023
@ruyadorno
2023-09-14, Version 18.18.0 'Hydrogen' (LTS)
7c96325
Notable changes:
build:
* sync libuv header change (Jiawen Geng) #48078
crypto:
* update root certificates to NSS 3.90 (Node.js GitHub Bot) #48416
deps:
* add missing thread-common.c in uv.gyp (Santiago Gimeno) #48078
* upgrade to libuv 1.46.0 (Santiago Gimeno) #48078
* upgrade to libuv 1.45.0 (Santiago Gimeno) #48078
doc:
* add vmoroz to collaborators (Vladimir Morozov) #48527
* add kvakil to collaborators (Keyhan Vakil) #48449
esm:
* (SEMVER-MINOR) add `--import` flag (Moshe Atlow) #43942
events:
* (SEMVER-MINOR) allow safely adding listener to abortSignal (Chemi Atlow) #48596
fs, stream:
* initial `Symbol.dispose` and `Symbol.asyncDispose` support (Moshe Atlow) #48518
net:
* add autoSelectFamily global getter and setter (Paolo Insogna) #45777
url:
* (SEMVER-MINOR) add value argument to has and delete methods (Sankalp Shubham) #47885
PR-URL: #49220
ruyadorno added a commit that referenced this pull request Sep 12, 2023
@ruyadorno
2023-09-14, Version 18.18.0 'Hydrogen' (LTS)
89e7fd1
Notable changes:
build:
* sync libuv header change (Jiawen Geng) #48078
crypto:
* update root certificates to NSS 3.93 (Node.js GitHub Bot) #49341
* update root certificates to NSS 3.90 (Node.js GitHub Bot) #48416
deps:
* add missing thread-common.c in uv.gyp (Santiago Gimeno) #48078
* upgrade to libuv 1.46.0 (Santiago Gimeno) #48078
* upgrade to libuv 1.45.0 (Santiago Gimeno) #48078
doc:
* add atlowChemi to collaborators (atlowChemi) #48757
* add vmoroz to collaborators (Vladimir Morozov) #48527
* add kvakil to collaborators (Keyhan Vakil) #48449
esm:
* (SEMVER-MINOR) add `--import` flag (Moshe Atlow) #43942
events:
* (SEMVER-MINOR) allow safely adding listener to abortSignal (Chemi Atlow) #48596
fs, stream:
* initial `Symbol.dispose` and `Symbol.asyncDispose` support (Moshe Atlow) #48518
net:
* add autoSelectFamily global getter and setter (Paolo Insogna) #45777
url:
* (SEMVER-MINOR) add value argument to has and delete methods (Sankalp Shubham) #47885
PR-URL: #49220
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
@kvakil@ruyadorno
doc: add kvakil to collaborators
a30f2fb
...and remove them triagers
Fixes: #48155
PR-URL: #48449
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
ruyadorno added a commit that referenced this pull request Sep 13, 2023
@ruyadorno
2023-09-14, Version 18.18.0 'Hydrogen' (LTS)
e873eef
Notable changes:
build:
* sync libuv header change (Jiawen Geng) #48078
crypto:
* update root certificates to NSS 3.93 (Node.js GitHub Bot) #49341
* update root certificates to NSS 3.90 (Node.js GitHub Bot) #48416
deps:
* add missing thread-common.c in uv.gyp (Santiago Gimeno) #48078
* upgrade to libuv 1.46.0 (Santiago Gimeno) #48078
* upgrade to libuv 1.45.0 (Santiago Gimeno) #48078
doc:
* add atlowChemi to collaborators (atlowChemi) #48757
* add vmoroz to collaborators (Vladimir Morozov) #48527
* add kvakil to collaborators (Keyhan Vakil) #48449
esm:
* (SEMVER-MINOR) add `--import` flag (Moshe Atlow) #43942
events:
* (SEMVER-MINOR) allow safely adding listener to abortSignal (Chemi Atlow) #48596
fs, stream:
* initial `Symbol.dispose` and `Symbol.asyncDispose` support (Moshe Atlow) #48518
net:
* add autoSelectFamily global getter and setter (Paolo Insogna) #45777
url:
* (SEMVER-MINOR) add value argument to has and delete methods (Sankalp Shubham) #47885
PR-URL: #49220
ruyadorno added a commit that referenced this pull request Sep 17, 2023
@ruyadorno
2023-09-18, Version 18.18.0 'Hydrogen' (LTS)
ab5fa2a
Notable changes:
build:
* sync libuv header change (Jiawen Geng) #48078
crypto:
* update root certificates to NSS 3.93 (Node.js GitHub Bot) #49341
* update root certificates to NSS 3.90 (Node.js GitHub Bot) #48416
deps:
* add missing thread-common.c in uv.gyp (Santiago Gimeno) #48078
* upgrade to libuv 1.46.0 (Santiago Gimeno) #48078
* upgrade to libuv 1.45.0 (Santiago Gimeno) #48078
doc:
* add atlowChemi to collaborators (atlowChemi) #48757
* add vmoroz to collaborators (Vladimir Morozov) #48527
* add kvakil to collaborators (Keyhan Vakil) #48449
esm:
* (SEMVER-MINOR) add `--import` flag (Moshe Atlow) #43942
events:
* (SEMVER-MINOR) allow safely adding listener to abortSignal (Chemi Atlow) #48596
fs, stream:
* initial `Symbol.dispose` and `Symbol.asyncDispose` support (Moshe Atlow) #48518
net:
* add autoSelectFamily global getter and setter (Paolo Insogna) #45777
url:
* (SEMVER-MINOR) add value argument to has and delete methods (Sankalp Shubham) #47885
PR-URL: #49220
ruyadorno added a commit that referenced this pull request Sep 18, 2023
@ruyadorno
2023-09-18, Version 18.18.0 'Hydrogen' (LTS)
78ab0ee
Notable changes:
build:
* sync libuv header change (Jiawen Geng) #48078
crypto:
* update root certificates to NSS 3.93 (Node.js GitHub Bot) #49341
* update root certificates to NSS 3.90 (Node.js GitHub Bot) #48416
deps:
* add missing thread-common.c in uv.gyp (Santiago Gimeno) #48078
* upgrade to libuv 1.46.0 (Santiago Gimeno) #48078
* upgrade to libuv 1.45.0 (Santiago Gimeno) #48078
doc:
* add atlowChemi to collaborators (atlowChemi) #48757
* add vmoroz to collaborators (Vladimir Morozov) #48527
* add kvakil to collaborators (Keyhan Vakil) #48449
esm:
* (SEMVER-MINOR) add `--import` flag (Moshe Atlow) #43942
events:
* (SEMVER-MINOR) allow safely adding listener to abortSignal (Chemi Atlow) #48596
fs, stream:
* initial `Symbol.dispose` and `Symbol.asyncDispose` support (Moshe Atlow) #48518
net:
* add autoSelectFamily global getter and setter (Paolo Insogna) #45777
url:
* (SEMVER-MINOR) add value argument to has and delete methods (Sankalp Shubham) #47885
PR-URL: #49220
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@joyeecheungjoyeecheungjoyeecheung approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.notable-changePRs with changes that should be highlighted in changelogs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Nominating @kvakil as a collaborator

5 participants

@kvakil@nodejs-github-bot@joyeecheung@lpinca@aduh95