Uh oh!
There was an error while loading. Please reload this page.
test: add tmpdir.resolve() - #49079
Merged
nodejs-github-bot merged 1 commit intoAug 13, 2023
Merged
Conversation
LiviaMedeirosforce-pushed
the
test-ft-tmpdir-resolve
branch
from
August 10, 2023 12:30
550ddaf to
8d0bc39Compareaduh95
commented
Aug 11, 2023
Contributor
It's a lot of files to review, and you are going to end up in a conflict hell. Maybe we can split this into several PRs? |
LiviaMedeirosforce-pushed
the
test-ft-tmpdir-resolve
branch
from
August 11, 2023 15:14
8d0bc39 to
3d3cc33CompareLiviaMedeiros
commented
Aug 11, 2023
MemberAuthor
Sure, I'll try to split test changes by subsystems after landing this one. |
This comment was marked as outdated.
This comment was marked as outdated.
aduh95
approved these changes
Aug 11, 2023
This comment was marked as outdated.
This comment was marked as outdated.
LiviaMedeirosforce-pushed
the
test-ft-tmpdir-resolve
branch
from
August 12, 2023 06:49
3d3cc33 to
c59cc3eCompare
This comment was marked as outdated.
This comment was marked as outdated.
nodejs-github-bot
commented
Aug 12, 2023
Collaborator
joyeecheung
approved these changes
Aug 12, 2023
29 tasks
nodejs-github-bot
commented
Aug 13, 2023
Collaborator
Landed in a4928b0 |
This was referenced Aug 13, 2023
25 tasks
Ceres6 pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#49079 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
22 tasks
RafaelGSS pushed a commit
that referenced
this pull request
Aug 15, 2023
PR-URL: #49079 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Merged
RafaelGSS pushed a commit
to RafaelGSS/node
that referenced
this pull request
Aug 15, 2023
PR-URL: nodejs#49079 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
RafaelGSS pushed a commit
that referenced
this pull request
Aug 16, 2023
PR-URL: #49079 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
RafaelGSS pushed a commit
that referenced
this pull request
Aug 17, 2023
PR-URL: #49079 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
richardlau pushed a commit
that referenced
this pull request
Sep 28, 2023
PR-URL: #49079 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a simple method to make the usual routine of
path.join(tmpdir.path, ...)more concise and avoid unnecessary import fromnode:pathalmost every timetmpdiris used.