Uh oh!
There was an error while loading. Please reload this page.
v18.18.1 proposal - #50066
Merged
Merged
Conversation
PR-URL: #49079 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
fs.write(v) is not guaranteed to write everything in a single call. Make sure we don't assume so. PR-URL: #49211 Co-authored-by: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
Notable changes: This release addresses some regressions that appeared in Node.js 18.18.0: - (Windows) FS can not handle certain characters in file name #48673 - 18 and 20 node images give error - Text file busy (after re-build images) nodejs/docker-node#1968 - libuv update in 18.18.0 breaks webpack's thread-loader #49911 The libuv 1.45.0 and 1.46.0 updates that were released in Node.js 18.18.0 have been temporarily reverted. PR-URL: #50066
Closed
Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/54589/ CITGM (v18.18.0): https://ci.nodejs.org/job/citgm-smoker/3309/ ncu-ci citgm 3309 3310$ ncu-ci citgm 3309 3310--------------------------------------------------------------------------------[1/1] Running CITGM: 3309--------------------------------------------------------------------------------✔ Summary data downloaded✔ Results data downloaded✔ Summary data downloaded✔ Results data downloaded----------------------------------- Summary ------------------------------------Result FAILUREURL https://ci.nodejs.org/job/citgm-smoker/3309/Source https://api.github.com/repos/nodejs/node/git/refs/tags/v18.18.0Commit [ab5fa2a22104] 2023-09-18, Version 18.18.0 'Hydrogen' (LTS)Date 2023-09-16 22:51:56 -0400Author Ruy Adorno <ruyadorno@google.com>----------------------------------- Summary ------------------------------------Result FAILUREURL https://ci.nodejs.org/job/citgm-smoker/3310/Source https://api.github.com/repos/nodejs/node/git/refs/heads/v18.18.1-proposalCommit [7615798b633f] 2023-10-10, Version 18.18.1 'Hydrogen' (LTS)Date 2023-10-06 13:14:11 -0400Author Richard Lau <rlau@redhat.com>----------------------------------- Results ------------------------------------FAILURE: 4 failures in 3310 not present in 3309┌───────────────────┬─────────────────────────┬────────────────┬─────────────────┐│ (index) │ 0 │ 1 │ 2 │├───────────────────┼─────────────────────────┼────────────────┼─────────────────┤│ rhel8-s390x │ 'torrent-stream-v1.2.1' │ │ ││ osx1015 │ │ │ ││ fedora-latest-x64 │ │ │ ││ rhel8-x64 │ │ │ ││ win-vs2019 │ │ │ ││ aix72-ppc64 │ │ │ ││ rhel8-ppc64le │ 'multer-v1.4.5-lts.1' │ 'pino-v8.15.6' │ 'semver-v7.5.4' │└───────────────────┴─────────────────────────┴────────────────┴─────────────────┘ |
targos
approved these changes
Oct 7, 2023
RafaelGSS
approved these changes
Oct 7, 2023
richardlau
commented
Oct 10, 2023
MemberAuthor
Release build for 7615798: https://ci-release.nodejs.org/job/iojs+release/9689/ |
richardlau added a commit
that referenced
this pull request
Oct 10, 2023
Notable changes: This release addresses some regressions that appeared in Node.js 18.18.0: - (Windows) FS can not handle certain characters in file name #48673 - 18 and 20 node images give error - Text file busy (after re-build images) nodejs/docker-node#1968 - libuv update in 18.18.0 breaks webpack's thread-loader #49911 The libuv 1.45.0 and 1.46.0 updates that were released in Node.js 18.18.0 have been temporarily reverted. PR-URL: #50066
richardlau added a commit
to nodejs/nodejs.org
that referenced
this pull request
Oct 10, 2023
5 tasks
github-merge-queueBot
pushed a commit
to nodejs/nodejs.org
that referenced
this pull request
Oct 10, 2023
debadree25 pushed a commit
to debadree25/node
that referenced
this pull request
Apr 15, 2024
Notable changes: This release addresses some regressions that appeared in Node.js 18.18.0: - (Windows) FS can not handle certain characters in file name nodejs#48673 - 18 and 20 node images give error - Text file busy (after re-build images) nodejs/docker-node#1968 - libuv update in 18.18.0 breaks webpack's thread-loader nodejs#49911 The libuv 1.45.0 and 1.46.0 updates that were released in Node.js 18.18.0 have been temporarily reverted. PR-URL: nodejs#50066
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2023-10-10, Version 18.18.1 'Hydrogen' (LTS), @richardlau
Notable Changes
This release addresses some regressions that appeared in Node.js 18.18.0:
The libuv 1.45.0 and 1.46.0 updates that were released in Node.js 18.18.0 have been temporarily reverted.
Commits
3e3a75cc46] - Revert "build: sync libuv header change" (Richard Lau) #5003614ece2c479] - Revert "deps: upgrade to libuv 1.45.0" (Richard Lau) #50036022352acbe] - Revert "deps: upgrade to libuv 1.46.0" (Richard Lau) #50036d9f138189c] - Revert "deps: add missing thread-common.c in uv.gyp" (Richard Lau) #500367a3e1ffbb8] - fs: make sure to write entire buffer (Robert Nagy) #4921104cba95a67] - test: addtmpdir.resolve()(Livia Medeiros) #49079cc @nodejs/lts
Note that this is not a "full" Node.js 18 release -- it is a "quick" release to fix the regressions noted above that were introduced in Node.js 18.18.0. I will not have time to do a full Node.js release this month, so any requests for additions to this release will likely be denied unless a very strong case can be made.