Skip to content

esm: remove return value for Module.register - #49529

Merged
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
aduh95:register-return-value
Sep 9, 2023
Merged

esm: remove return value for Module.register#49529
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
aduh95:register-return-value

Conversation

@aduh95

@aduh95aduh95 commented Sep 7, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

The current API shape is not great because it's too limited and redundant with the use of MessagePort.

@aduh95
esm: remove return value for Module.register
19cbaf1
The current API shape si not great because it's too limited and
redundant with the use of `MessagePort`.
@nodejs-github-bot

nodejs-github-bot commented Sep 7, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-botnodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Sep 7, 2023
aduh95
aduh95 commented Sep 7, 2023
View reviewed changes
Comment threaddoc/api/module.md Outdated
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 7, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 7, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 7, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53782/

@GeoffreyBoothGeoffreyBooth mentioned this pull request Sep 7, 2023
Merged
@github-actionsgithub-actionsBot mentioned this pull request Sep 8, 2023
Open
26 tasks
@nodejs-github-bot

nodejs-github-bot commented Sep 8, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53808/

@aduh95aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Sep 8, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 9, 2023
@nodejs-github-bot
nodejs-github-bot merged commit b64c3ee into nodejs:mainSep 9, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 9, 2023

Copy link
Copy Markdown
Collaborator

Landed in b64c3ee

@aduh95
aduh95 deleted the register-return-value branch September 9, 2023 21:58
@github-actionsgithub-actionsBot mentioned this pull request Sep 11, 2023
Open
18 tasks
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@aduh95@ruyadorno
esm: remove return value for Module.register
be48267
The current API shape si not great because it's too limited and
redundant with the use of `MessagePort`.
PR-URL: #49529
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
This was referenced Sep 28, 2023
Closed
Merged
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
@aduh95@targos
esm: remove return value for Module.register
fbc7c3e
The current API shape si not great because it's too limited and
redundant with the use of `MessagePort`.
PR-URL: nodejs#49529
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
@targostargos mentioned this pull request Nov 11, 2023
Closed
targos pushed a commit that referenced this pull request Nov 23, 2023
@aduh95@targos
esm: remove return value for Module.register
4be5612
The current API shape si not great because it's too limited and
redundant with the use of `MessagePort`.
PR-URL: #49529
Backport-PR-URL: #50669
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
@targostargos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
esm: remove return value for Module.register
3a289bf
The current API shape si not great because it's too limited and
redundant with the use of `MessagePort`.
PR-URL: nodejs/node#49529
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
esm: remove return value for Module.register
c8b196a
The current API shape si not great because it's too limited and
redundant with the use of `MessagePort`.
PR-URL: nodejs/node#49529
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GeoffreyBoothGeoffreyBoothGeoffreyBooth approved these changes
@JakobJingleheimerJakobJingleheimerJakobJingleheimer approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.esmIssues and PRs related to the ECMAScript Modules implementation.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aduh95@nodejs-github-bot@GeoffreyBooth@JakobJingleheimer@targos