Skip to content

test: increase coverage of Module.register and initialize hook - #49532

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:test-initialize
Sep 10, 2023
Merged

test: increase coverage of Module.register and initialize hook#49532
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:test-initialize

Conversation

@aduh95

@aduh95aduh95 commented Sep 7, 2023

Copy link
Copy Markdown
Contributor

I recommend reviewing with whitespaces turned off.

@nodejs-github-botnodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 7, 2023
@aduh95

aduh95 commented Sep 7, 2023

Copy link
Copy Markdown
ContributorAuthor

/cc @nodejs/loaders

@GeoffreyBooth

GeoffreyBooth commented Sep 7, 2023

Copy link
Copy Markdown
Member

How does this relate to #49529?

@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 7, 2023
@aduh95

aduh95 commented Sep 7, 2023

Copy link
Copy Markdown
ContributorAuthor

How does this relate to #49529?

Hum both PRs are dealing with the same Module.register API, but apart from that they are hardly related.

@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 7, 2023
@GeoffreyBooth

GeoffreyBooth commented Sep 7, 2023

Copy link
Copy Markdown
Member

apart from that they are hardly related.

As in, none of these tests involve the initialize return value.

That’s fine, I was just hoping that they weren’t in conflict, and it sounds like they aren’t.

@nodejs-github-bot

nodejs-github-bot commented Sep 7, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53791/

@aduh95

aduh95 commented Sep 7, 2023

Copy link
Copy Markdown
ContributorAuthor

I was just hoping that they weren’t in conflict, and it sounds like they aren’t.

They probably are in conflict, they are modifying the same lines in the test, for unrelated reasons.

@aduh95aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 9, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 9, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 9, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53847/

@github-actionsgithub-actionsBot mentioned this pull request Sep 10, 2023
Open
19 tasks
@aduh95aduh95 mentioned this pull request Sep 10, 2023
Closed
@nodejs-github-bot

nodejs-github-bot commented Sep 10, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53851/

@nodejs-github-bot

nodejs-github-bot commented Sep 10, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53852/

@GeoffreyBoothGeoffreyBooth added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Sep 10, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 10, 2023
@nodejs-github-bot
nodejs-github-bot merged commit c159b90 into nodejs:mainSep 10, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 10, 2023

Copy link
Copy Markdown
Collaborator

Landed in c159b90

This was referenced Sep 11, 2023
Open
Open
@joyeecheungjoyeecheung mentioned this pull request Sep 12, 2023
Closed
This was referenced Sep 13, 2023
Open
Open
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@aduh95@ruyadorno
test: increase coverage of Module.register and initialize hook
ced25a9
PR-URL: #49532
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
This was referenced Sep 28, 2023
Closed
Merged
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
@aduh95@targos
test: increase coverage of Module.register and initialize hook
89dce06
PR-URL: nodejs#49532
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@targostargos mentioned this pull request Nov 11, 2023
Closed
targos pushed a commit that referenced this pull request Nov 23, 2023
@aduh95@targos
test: increase coverage of Module.register and initialize hook
866d646
PR-URL: #49532
Backport-PR-URL: #50669
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@targostargos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: increase coverage of Module.register and initialize
6ddeff5
PR-URL: nodejs/node#49532
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: increase coverage of Module.register and initialize
2311dc2
PR-URL: nodejs/node#49532
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GeoffreyBoothGeoffreyBoothGeoffreyBooth approved these changes
@anonriganonriganonrig approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.esmIssues and PRs related to the ECMAScript Modules implementation.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aduh95@GeoffreyBooth@nodejs-github-bot@anonrig@targos