console: treat non-strings as separate argument in console.assert() by jcbhmr · Pull Request #49722 · nodejs/node

jcbhmr · 2023-09-19T18:04:11Z

unsure if i should add more desc text here

BridgeAR

Good start, it just needs a test as well. There are a couple of console tests already - some in message tests (they need the output to be identical as outlined in the file next to them) or in a regular test in the parallel folder.

BridgeAR · 2023-09-19T21:47:40Z

+ // https://console.spec.whatwg.org/#assert step 4.2:
+ if (typeof args[0] === "string") {
+ args[0] = `Assertion failed: ${args[0]}`
+ } else {
+ ArrayPrototypeUnshift(args, "Assertion failed")
+ }


Suggested change
// https://console.spec.whatwg.org/#assert step 4.2:
if(typeofargs[0]==="string"){
args[0]=`Assertion failed: ${args[0]}`
}else{
ArrayPrototypeUnshift(args,"Assertion failed")
}
letbaseMessage='Assertion failed';
if(args.length>0){
baseMessage+=':';
}
ArrayPrototypeUnshift(args,"Assertion failed");
That way it's always consistent and I would not add the documentation reference as it might change it's location without the comment being updated.

aduh95 · 2023-09-29T10:42:53Z

@nodejs/tsc for reviews since this is semver-majorPRs that contain breaking changes and should be released in the next major version.

nodejs-github-bot · 2023-09-29T10:49:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54360/

jcbhmr · 2023-11-01T15:11:23Z

its been a month lol 😅 what would be the best way to move forward with this pr? do i need to make any changes? does this need to "tsc for reviews since semver major" still? what do i need to do and/or can i do to help get this merged?

mcollina

lgtm

nodejs-github-bot · 2023-11-01T17:54:08Z

Landed in 60e8364

Notable Changes: TBD Semver-Major Commits: build: * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #51362 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #50115 console: * (SEMVER-MAJOR) treat non-strings as separate argument in console.assert() (Jacob Hummer) #49722 crypto: * (SEMVER-MAJOR) runtime deprecate hmac constructor (Marco Ippolito) #52071 * (SEMVER-MAJOR) runtime deprecate Hash constructor (Marco Ippolito) #51880 * (SEMVER-MAJOR) move createCipher and createDecipher to eol (Marco Ippolito) #50973 deps: * (SEMVER-MAJOR) V8: backport c4be0a97f981 (Richard Lau) #51362 * (SEMVER-MAJOR) V8: cherry-pick f8d5e576b814 (Richard Lau) #51362 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #51362 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #51362 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #51362 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #51362 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #51362 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #51362 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 to 12.2.281.27 (Michaël Zasso) #51362 * (SEMVER-MAJOR) V8: cherry-pick de611e69ad51 (Keyhan Vakil) #50115 * (SEMVER-MAJOR) V8: cherry-pick 0fd478bcdabd (Joyee Cheung) #50115 * (SEMVER-MAJOR) V8: cherry-pick 0f9ebbc672c7 (Chengzhong Wu) #50115 * (SEMVER-MAJOR) V8: cherry-pick 8f0b94671ddb (Lu Yahan) #50115 * (SEMVER-MAJOR) V8: cherry-pick f7d000a7ae7b (Luke Albao) #50115 * (SEMVER-MAJOR) V8: cherry-pick 25902244ad1a (Joyee Cheung) #50115 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #50115 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #50115 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #50115 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #50115 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #50115 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #50115 * (SEMVER-MAJOR) update V8 to 11.9.169.7 (Michaël Zasso) #50115 doc: * (SEMVER-MAJOR) runtime deprecate flag --trace-atomics-wait (marco-ippolito) #51179 * (SEMVER-MAJOR) bump FreeBSD experimental support to 13.2 (Michaël Zasso) #51231 * (SEMVER-MAJOR) add migration paths for deprecated utils (Marco Ippolito) #50488 fs: * (SEMVER-MAJOR) runtime deprecate fs.Stats constructor (Marco Ippolito) #52067 * (SEMVER-MAJOR) use private fields instead of symbols for `Dir` (Jungku Lee) #51037 * (SEMVER-MAJOR) make stats date fields lazy (Yagiz Nizipli) #50908 http: * (SEMVER-MAJOR) preserve raw header duplicates in writeHead after setHeader calls (Tim Perry) #50394 lib: * (SEMVER-MAJOR) enable WebSocket by default (Aras Abbasi) #51594 lib,test: * (SEMVER-MAJOR) handle new Iterator global (Michaël Zasso) #51362 process: * (SEMVER-MAJOR) wait for `'exit'` before printing result (Antoine du Hamel) #52172 src: * (SEMVER-MAJOR) use supported API to get stalled TLA messages (Michaël Zasso) #51362 * (SEMVER-MAJOR) update default V8 platform to override functions with location (Etienne Pierre-Doray) #51362 * (SEMVER-MAJOR) add missing TryCatch (Michaël Zasso) #51362 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 124 (Michaël Zasso) #51362 * (SEMVER-MAJOR) use non-deprecated v8::Uint8Array::kMaxLength (Michaël Zasso) #50115 * (SEMVER-MAJOR) adapt to v8::Exception API change (Michaël Zasso) #50115 * (SEMVER-MAJOR) use non-deprecated version of CreateSyntheticModule (Michaël Zasso) #50115 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 122 (Michaël Zasso) #50115 stream: * (SEMVER-MAJOR) bump default highWaterMark (Robert Nagy) #52037 test: * (SEMVER-MAJOR) mark test-worker-arraybuffer-zerofill as flaky (Michaël Zasso) #51362 * (SEMVER-MAJOR) mark some GC-related tests as flaky (Michaël Zasso) #51362 * (SEMVER-MAJOR) allow slightly more diff in memory leak test (Michaël Zasso) #51362 * (SEMVER-MAJOR) replace always-opt flag with alway-turbofan (Michaël Zasso) #50115 * (SEMVER-MAJOR) remove tests that create very large buffers (Michaël Zasso) #50115 * (SEMVER-MAJOR) adapt to new V8 trusted memory spaces (Michaël Zasso) #50115 test_runner: * (SEMVER-MAJOR) omit filtered test from output (Colin Ihrig) #52221 * (SEMVER-MAJOR) improve `--test-name-pattern` to allow matching single test (Michał Drobniak) #51577 tools: * (SEMVER-MAJOR) roughly port v8_abseil to gyp (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.2 (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.1 (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.0 (Michaël Zasso) #51362 trace_events: * (SEMVER-MAJOR) use private fields instead of symbols for `Tracing` (Jungku Lee) #51180 util: * (SEMVER-MAJOR) runtime deprecate util.log (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isUndefined (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isSymbol (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isString (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isRegExp (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isPrimitive (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isObject (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isNumber (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isNullOrUndefined (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isNull (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isFunction (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isError (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isDate (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecation util.isBuffer (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecation util.isBoolean (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isArray (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecation util._extend (Marco Ippolito) #50488 v8: * (SEMVER-MAJOR) enable maglev on supported architectures (Keyhan Vakil) #51360 PR-URL: TBD Co-Authored-By: Marco Ippolito <marcoippolito54@gmail.com>

Notable Changes: TBD Semver-Major Commits: build: * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #51362 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #50115 console: * (SEMVER-MAJOR) treat non-strings as separate argument in console.assert() (Jacob Hummer) #49722 crypto: * (SEMVER-MAJOR) runtime deprecate hmac constructor (Marco Ippolito) #52071 * (SEMVER-MAJOR) runtime deprecate Hash constructor (Marco Ippolito) #51880 * (SEMVER-MAJOR) move createCipher and createDecipher to eol (Marco Ippolito) #50973 deps: * (SEMVER-MAJOR) V8: backport c4be0a97f981 (Richard Lau) #51362 * (SEMVER-MAJOR) V8: cherry-pick f8d5e576b814 (Richard Lau) #51362 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #51362 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #51362 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #51362 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #51362 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #51362 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #51362 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 to 12.2.281.27 (Michaël Zasso) #51362 * (SEMVER-MAJOR) V8: cherry-pick de611e69ad51 (Keyhan Vakil) #50115 * (SEMVER-MAJOR) V8: cherry-pick 0fd478bcdabd (Joyee Cheung) #50115 * (SEMVER-MAJOR) V8: cherry-pick 0f9ebbc672c7 (Chengzhong Wu) #50115 * (SEMVER-MAJOR) V8: cherry-pick 8f0b94671ddb (Lu Yahan) #50115 * (SEMVER-MAJOR) V8: cherry-pick f7d000a7ae7b (Luke Albao) #50115 * (SEMVER-MAJOR) V8: cherry-pick 25902244ad1a (Joyee Cheung) #50115 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #50115 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #50115 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #50115 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #50115 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #50115 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #50115 * (SEMVER-MAJOR) update V8 to 11.9.169.7 (Michaël Zasso) #50115 doc: * (SEMVER-MAJOR) runtime deprecate flag --trace-atomics-wait (marco-ippolito) #51179 * (SEMVER-MAJOR) bump FreeBSD experimental support to 13.2 (Michaël Zasso) #51231 * (SEMVER-MAJOR) add migration paths for deprecated utils (Marco Ippolito) #50488 fs: * (SEMVER-MAJOR) runtime deprecate fs.Stats constructor (Marco Ippolito) #52067 * (SEMVER-MAJOR) use private fields instead of symbols for `Dir` (Jungku Lee) #51037 * (SEMVER-MAJOR) make stats date fields lazy (Yagiz Nizipli) #50908 http: * (SEMVER-MAJOR) preserve raw header duplicates in writeHead after setHeader calls (Tim Perry) #50394 lib: * (SEMVER-MAJOR) enable WebSocket by default (Aras Abbasi) #51594 lib,test: * (SEMVER-MAJOR) handle new Iterator global (Michaël Zasso) #51362 process: * (SEMVER-MAJOR) wait for `'exit'` before printing result (Antoine du Hamel) #52172 src: * (SEMVER-MAJOR) use supported API to get stalled TLA messages (Michaël Zasso) #51362 * (SEMVER-MAJOR) update default V8 platform to override functions with location (Etienne Pierre-Doray) #51362 * (SEMVER-MAJOR) add missing TryCatch (Michaël Zasso) #51362 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 124 (Michaël Zasso) #51362 * (SEMVER-MAJOR) use non-deprecated v8::Uint8Array::kMaxLength (Michaël Zasso) #50115 * (SEMVER-MAJOR) adapt to v8::Exception API change (Michaël Zasso) #50115 * (SEMVER-MAJOR) use non-deprecated version of CreateSyntheticModule (Michaël Zasso) #50115 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 122 (Michaël Zasso) #50115 stream: * (SEMVER-MAJOR) bump default highWaterMark (Robert Nagy) #52037 test: * (SEMVER-MAJOR) mark test-worker-arraybuffer-zerofill as flaky (Michaël Zasso) #51362 * (SEMVER-MAJOR) mark some GC-related tests as flaky (Michaël Zasso) #51362 * (SEMVER-MAJOR) allow slightly more diff in memory leak test (Michaël Zasso) #51362 * (SEMVER-MAJOR) replace always-opt flag with alway-turbofan (Michaël Zasso) #50115 * (SEMVER-MAJOR) remove tests that create very large buffers (Michaël Zasso) #50115 * (SEMVER-MAJOR) adapt to new V8 trusted memory spaces (Michaël Zasso) #50115 test_runner: * (SEMVER-MAJOR) omit filtered test from output (Colin Ihrig) #52221 * (SEMVER-MAJOR) improve `--test-name-pattern` to allow matching single test (Michał Drobniak) #51577 tools: * (SEMVER-MAJOR) roughly port v8_abseil to gyp (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.2 (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.1 (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.0 (Michaël Zasso) #51362 trace_events: * (SEMVER-MAJOR) use private fields instead of symbols for `Tracing` (Jungku Lee) #51180 util: * (SEMVER-MAJOR) runtime deprecate util.log (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isUndefined (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isSymbol (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isString (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isRegExp (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isPrimitive (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isObject (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isNumber (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isNullOrUndefined (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isNull (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isFunction (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isError (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isDate (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecation util.isBuffer (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecation util.isBoolean (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isArray (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecation util._extend (Marco Ippolito) #50488 v8: * (SEMVER-MAJOR) enable maglev on supported architectures (Keyhan Vakil) #51360 PR-URL: #52505 Co-Authored-By: Marco Ippolito <marcoippolito54@gmail.com>

Semver-Major Commits: build: * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #51362 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #50115 console: * (SEMVER-MAJOR) treat non-strings as separate argument in console.assert() (Jacob Hummer) #49722 crypto: * (SEMVER-MAJOR) runtime deprecate hmac constructor (Marco Ippolito) #52071 * (SEMVER-MAJOR) runtime deprecate Hash constructor (Marco Ippolito) #51880 * (SEMVER-MAJOR) move createCipher and createDecipher to eol (Marco Ippolito) #50973 deps: * (SEMVER-MAJOR) V8: backport c4be0a97f981 (Richard Lau) #51362 * (SEMVER-MAJOR) V8: cherry-pick f8d5e576b814 (Richard Lau) #51362 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #51362 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #51362 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #51362 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #51362 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #51362 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #51362 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 to 12.2.281.27 (Michaël Zasso) #51362 * (SEMVER-MAJOR) V8: cherry-pick de611e69ad51 (Keyhan Vakil) #50115 * (SEMVER-MAJOR) V8: cherry-pick 0fd478bcdabd (Joyee Cheung) #50115 * (SEMVER-MAJOR) V8: cherry-pick 0f9ebbc672c7 (Chengzhong Wu) #50115 * (SEMVER-MAJOR) V8: cherry-pick 8f0b94671ddb (Lu Yahan) #50115 * (SEMVER-MAJOR) V8: cherry-pick f7d000a7ae7b (Luke Albao) #50115 * (SEMVER-MAJOR) V8: cherry-pick 25902244ad1a (Joyee Cheung) #50115 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #50115 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #50115 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #50115 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #50115 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #50115 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #50115 * (SEMVER-MAJOR) update V8 to 11.9.169.7 (Michaël Zasso) #50115 doc: * (SEMVER-MAJOR) runtime deprecate flag --trace-atomics-wait (marco-ippolito) #51179 * (SEMVER-MAJOR) bump FreeBSD experimental support to 13.2 (Michaël Zasso) #51231 * (SEMVER-MAJOR) add migration paths for deprecated utils (Marco Ippolito) #50488 fs: * (SEMVER-MAJOR) runtime deprecate fs.Stats constructor (Marco Ippolito) #52067 * (SEMVER-MAJOR) use private fields instead of symbols for `Dir` (Jungku Lee) #51037 * (SEMVER-MAJOR) make stats date fields lazy (Yagiz Nizipli) #50908 http: * (SEMVER-MAJOR) preserve raw header duplicates in writeHead after setHeader calls (Tim Perry) #50394 lib: * (SEMVER-MAJOR) enable WebSocket by default (Aras Abbasi) #51594 lib,test: * (SEMVER-MAJOR) handle new Iterator global (Michaël Zasso) #51362 process: * (SEMVER-MAJOR) wait for `'exit'` before printing result (Antoine du Hamel) #52172 src: * (SEMVER-MAJOR) use supported API to get stalled TLA messages (Michaël Zasso) #51362 * (SEMVER-MAJOR) update default V8 platform to override functions with location (Etienne Pierre-Doray) #51362 * (SEMVER-MAJOR) add missing TryCatch (Michaël Zasso) #51362 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 124 (Michaël Zasso) #51362 * (SEMVER-MAJOR) use non-deprecated v8::Uint8Array::kMaxLength (Michaël Zasso) #50115 * (SEMVER-MAJOR) adapt to v8::Exception API change (Michaël Zasso) #50115 * (SEMVER-MAJOR) use non-deprecated version of CreateSyntheticModule (Michaël Zasso) #50115 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 122 (Michaël Zasso) #50115 stream: * (SEMVER-MAJOR) bump default highWaterMark (Robert Nagy) #52037 test: * (SEMVER-MAJOR) mark test-worker-arraybuffer-zerofill as flaky (Michaël Zasso) #51362 * (SEMVER-MAJOR) mark some GC-related tests as flaky (Michaël Zasso) #51362 * (SEMVER-MAJOR) allow slightly more diff in memory leak test (Michaël Zasso) #51362 * (SEMVER-MAJOR) replace always-opt flag with alway-turbofan (Michaël Zasso) #50115 * (SEMVER-MAJOR) remove tests that create very large buffers (Michaël Zasso) #50115 * (SEMVER-MAJOR) adapt to new V8 trusted memory spaces (Michaël Zasso) #50115 test_runner: * (SEMVER-MAJOR) omit filtered test from output (Colin Ihrig) #52221 * (SEMVER-MAJOR) improve `--test-name-pattern` to allow matching single test (Michał Drobniak) #51577 tools: * (SEMVER-MAJOR) roughly port v8_abseil to gyp (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.2 (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.1 (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.0 (Michaël Zasso) #51362 trace_events: * (SEMVER-MAJOR) use private fields instead of symbols for `Tracing` (Jungku Lee) #51180 util: * (SEMVER-MAJOR) runtime deprecate util.log (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isUndefined (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isSymbol (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isString (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isRegExp (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isPrimitive (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isObject (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isNumber (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isNullOrUndefined (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isNull (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isFunction (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isError (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isDate (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecation util.isBuffer (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecation util.isBoolean (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isArray (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecation util._extend (Marco Ippolito) #50488 v8: * (SEMVER-MAJOR) enable maglev on supported architectures (Keyhan Vakil) #51360 PR-URL: #52505 Co-Authored-By: Marco Ippolito <marcoippolito54@gmail.com>

Semver-Major Commits: build: * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #52293 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #51362 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #50115 console: * (SEMVER-MAJOR) treat non-strings as separate argument in console.assert() (Jacob Hummer) #49722 crypto: * (SEMVER-MAJOR) runtime deprecate hmac constructor (Marco Ippolito) #52071 * (SEMVER-MAJOR) runtime deprecate Hash constructor (Marco Ippolito) #51880 * (SEMVER-MAJOR) move createCipher and createDecipher to eol (Marco Ippolito) #50973 deps: * (SEMVER-MAJOR) V8: backport c4be0a97f981 (Richard Lau) #51362 * (SEMVER-MAJOR) V8: backport c4be0a97f981 (Richard Lau) #52293 * (SEMVER-MAJOR) V8: cherry-pick f8d5e576b814 (Richard Lau) #51362 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #51362 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (Stefan Stojanovic) #52293 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #51362 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #51362 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #51362 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #51362 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #51362 * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) #52293 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 to 12.2.281.27 (Michaël Zasso) #51362 * (SEMVER-MAJOR) V8: cherry-pick de611e69ad51 (Keyhan Vakil) #50115 * (SEMVER-MAJOR) V8: cherry-pick 0fd478bcdabd (Joyee Cheung) #50115 * (SEMVER-MAJOR) V8: cherry-pick 0f9ebbc672c7 (Chengzhong Wu) #50115 * (SEMVER-MAJOR) V8: cherry-pick 8f0b94671ddb (Lu Yahan) #50115 * (SEMVER-MAJOR) V8: cherry-pick f7d000a7ae7b (Luke Albao) #50115 * (SEMVER-MAJOR) V8: cherry-pick 25902244ad1a (Joyee Cheung) #50115 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #50115 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #52293 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #50115 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #52293 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #50115 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #52293 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #50115 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #52293 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #50115 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #52293 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #50115 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #52293 * (SEMVER-MAJOR) update V8 to 11.9.169.7 (Michaël Zasso) #50115 * (SEMVER-MAJOR) update V8 to 12.3.219.16 (Michaël Zasso) #52293 doc: * (SEMVER-MAJOR) runtime deprecate flag --trace-atomics-wait (marco-ippolito) #51179 * (SEMVER-MAJOR) bump FreeBSD experimental support to 13.2 (Michaël Zasso) #51231 * (SEMVER-MAJOR) add migration paths for deprecated utils (Marco Ippolito) #50488 fs: * (SEMVER-MAJOR) runtime deprecate fs.Stats constructor (Marco Ippolito) #52067 * (SEMVER-MAJOR) use private fields instead of symbols for `Dir` (Jungku Lee) #51037 * (SEMVER-MAJOR) make stats date fields lazy (Yagiz Nizipli) #50908 http: * (SEMVER-MAJOR) preserve raw header duplicates in writeHead after setHeader calls (Tim Perry) #50394 lib: * (SEMVER-MAJOR) enable WebSocket by default (Aras Abbasi) #51594 lib,test: * (SEMVER-MAJOR) handle new Iterator global (Michaël Zasso) #51362 process: * (SEMVER-MAJOR) wait for `'exit'` before printing result (Antoine du Hamel) #52172 src: * (SEMVER-MAJOR) use supported API to get stalled TLA messages (Michaël Zasso) #51362 * (SEMVER-MAJOR) update default V8 platform to override functions with location (Etienne Pierre-Doray) #51362 * (SEMVER-MAJOR) add missing TryCatch (Michaël Zasso) #51362 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 124 (Michaël Zasso) #51362 * (SEMVER-MAJOR) use non-deprecated v8::Uint8Array::kMaxLength (Michaël Zasso) #50115 * (SEMVER-MAJOR) adapt to v8::Exception API change (Michaël Zasso) #50115 * (SEMVER-MAJOR) use non-deprecated version of CreateSyntheticModule (Michaël Zasso) #50115 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 122 (Michaël Zasso) #50115 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 126 (Michaël Zasso) #52293 stream: * (SEMVER-MAJOR) bump default highWaterMark (Robert Nagy) #52037 test: * (SEMVER-MAJOR) mark test-worker-arraybuffer-zerofill as flaky (Michaël Zasso) #51362 * (SEMVER-MAJOR) mark some GC-related tests as flaky (Michaël Zasso) #51362 * (SEMVER-MAJOR) allow slightly more diff in memory leak test (Michaël Zasso) #51362 * (SEMVER-MAJOR) replace always-opt flag with alway-turbofan (Michaël Zasso) #50115 * (SEMVER-MAJOR) remove tests that create very large buffers (Michaël Zasso) #50115 * (SEMVER-MAJOR) adapt to new V8 trusted memory spaces (Michaël Zasso) #50115 test_runner: * (SEMVER-MAJOR) omit filtered test from output (Colin Ihrig) #52221 * (SEMVER-MAJOR) improve `--test-name-pattern` to allow matching single test (Michał Drobniak) #51577 tools: * (SEMVER-MAJOR) roughly port v8_abseil to gyp (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.2 (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.1 (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.0 (Michaël Zasso) #51362 trace_events: * (SEMVER-MAJOR) use private fields instead of symbols for `Tracing` (Jungku Lee) #51180 util: * (SEMVER-MAJOR) runtime deprecate util.log (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isUndefined (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isSymbol (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isString (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isRegExp (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isPrimitive (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isObject (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isNumber (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isNullOrUndefined (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isNull (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isFunction (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isError (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isDate (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecation util.isBuffer (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecation util.isBoolean (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isArray (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecation util._extend (Marco Ippolito) #50488 v8: * (SEMVER-MAJOR) enable maglev on supported architectures (Keyhan Vakil) #51360 PR-URL: #52505 Co-Authored-By: Marco Ippolito <marcoippolito54@gmail.com>

Semver-Major Commits: build: * (SEMVER-MAJOR) compile with C++20 support on Windows (StefanStojanovic) #52465 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #52465 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #52293 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #51362 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #50115 console: * (SEMVER-MAJOR) treat non-strings as separate argument in console.assert() (Jacob Hummer) #49722 crypto: * (SEMVER-MAJOR) runtime deprecate hmac constructor (Marco Ippolito) #52071 * (SEMVER-MAJOR) runtime deprecate Hash constructor (Marco Ippolito) #51880 * (SEMVER-MAJOR) move createCipher and createDecipher to eol (Marco Ippolito) #50973 deps: * (SEMVER-MAJOR) V8: cherry-pick cd10ad7cdbe5 (Joyee Cheung) #52465 * (SEMVER-MAJOR) V8: revert CL 5331688 (Michaël Zasso) #52465 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #52465 * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) #52465 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #52465 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #52465 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #52465 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #52465 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #52465 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #52465 * (SEMVER-MAJOR) update V8 to 12.4.254.14 (Michaël Zasso) #52465 * (SEMVER-MAJOR) V8: cherry-pick cd10ad7cdbe5 (Joyee Cheung) #52293 * (SEMVER-MAJOR) V8: backport c4be0a97f981 (Richard Lau) #52293 * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) #52293 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (Stefan Stojanovic) #52293 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #52293 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #52293 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #52293 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #52293 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #52293 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #52293 * (SEMVER-MAJOR) update V8 to 12.3.219.16 (Michaël Zasso) #52293 * (SEMVER-MAJOR) V8: backport c4be0a97f981 (Richard Lau) #51362 * (SEMVER-MAJOR) V8: cherry-pick f8d5e576b814 (Richard Lau) #51362 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #51362 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #51362 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #51362 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #51362 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #51362 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #51362 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 to 12.2.281.27 (Michaël Zasso) #51362 * (SEMVER-MAJOR) V8: cherry-pick de611e69ad51 (Keyhan Vakil) #50115 * (SEMVER-MAJOR) V8: cherry-pick 0fd478bcdabd (Joyee Cheung) #50115 * (SEMVER-MAJOR) V8: cherry-pick 0f9ebbc672c7 (Chengzhong Wu) #50115 * (SEMVER-MAJOR) V8: cherry-pick 8f0b94671ddb (Lu Yahan) #50115 * (SEMVER-MAJOR) V8: cherry-pick f7d000a7ae7b (Luke Albao) #50115 * (SEMVER-MAJOR) V8: cherry-pick 25902244ad1a (Joyee Cheung) #50115 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #50115 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #50115 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #50115 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #50115 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #50115 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #50115 * (SEMVER-MAJOR) update V8 to 11.9.169.7 (Michaël Zasso) #50115 doc: * (SEMVER-MAJOR) runtime deprecate flag --trace-atomics-wait (marco-ippolito) #51179 * (SEMVER-MAJOR) bump FreeBSD experimental support to 13.2 (Michaël Zasso) #51231 * (SEMVER-MAJOR) add migration paths for deprecated utils (Marco Ippolito) #50488 fs: * (SEMVER-MAJOR) runtime deprecate fs.Stats constructor (Marco Ippolito) #52067 * (SEMVER-MAJOR) use private fields instead of symbols for `Dir` (Jungku Lee) #51037 * (SEMVER-MAJOR) make stats date fields lazy (Yagiz Nizipli) #50908 http: * (SEMVER-MAJOR) preserve raw header duplicates in writeHead after setHeader calls (Tim Perry) #50394 lib: * (SEMVER-MAJOR) enable WebSocket by default (Aras Abbasi) #51594 lib,test: * (SEMVER-MAJOR) handle new Iterator global (Michaël Zasso) #51362 process: * (SEMVER-MAJOR) wait for `'exit'` before printing result (Antoine du Hamel) #52172 src: * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 127 (Michaël Zasso) #52465 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 126 (Michaël Zasso) #52293 * (SEMVER-MAJOR) use supported API to get stalled TLA messages (Michaël Zasso) #51362 * (SEMVER-MAJOR) update default V8 platform to override functions with location (Etienne Pierre-Doray) #51362 * (SEMVER-MAJOR) add missing TryCatch (Michaël Zasso) #51362 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 124 (Michaël Zasso) #51362 * (SEMVER-MAJOR) use non-deprecated v8::Uint8Array::kMaxLength (Michaël Zasso) #50115 * (SEMVER-MAJOR) adapt to v8::Exception API change (Michaël Zasso) #50115 * (SEMVER-MAJOR) use non-deprecated version of CreateSyntheticModule (Michaël Zasso) #50115 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 122 (Michaël Zasso) #50115 stream: * (SEMVER-MAJOR) bump default highWaterMark (Robert Nagy) #52037 test: * (SEMVER-MAJOR) mark test-worker-arraybuffer-zerofill as flaky (Michaël Zasso) #51362 * (SEMVER-MAJOR) mark some GC-related tests as flaky (Michaël Zasso) #51362 * (SEMVER-MAJOR) allow slightly more diff in memory leak test (Michaël Zasso) #51362 * (SEMVER-MAJOR) replace always-opt flag with alway-turbofan (Michaël Zasso) #50115 * (SEMVER-MAJOR) remove tests that create very large buffers (Michaël Zasso) #50115 * (SEMVER-MAJOR) adapt to new V8 trusted memory spaces (Michaël Zasso) #50115 test_runner: * (SEMVER-MAJOR) omit filtered test from output (Colin Ihrig) #52221 * (SEMVER-MAJOR) improve `--test-name-pattern` to allow matching single test (Michał Drobniak) #51577 tools: * (SEMVER-MAJOR) update V8 gypfiles for 12.4 (Michaël Zasso) #52465 * (SEMVER-MAJOR) roughly port v8_abseil to gyp (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.2 (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.1 (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.0 (Michaël Zasso) #51362 trace_events: * (SEMVER-MAJOR) use private fields instead of symbols for `Tracing` (Jungku Lee) #51180 util: * (SEMVER-MAJOR) runtime deprecate util.log (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isUndefined (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isSymbol (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isString (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isRegExp (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isPrimitive (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isObject (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isNumber (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isNullOrUndefined (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isNull (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isFunction (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isError (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isDate (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecation util.isBuffer (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecation util.isBoolean (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isArray (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecation util._extend (Marco Ippolito) #50488 v8: * (SEMVER-MAJOR) enable maglev on supported architectures (Keyhan Vakil) #51360 PR-URL: #52505 Co-Authored-By: Marco Ippolito <marcoippolito54@gmail.com>

console: treat non-strings as separate argument in console.assert()
9ac6528
fixesnodejs#49680

nodejs-github-bot added console Issues and PRs related to the console subsystem. needs-ci PRs that need a full CI run. labels Sep 19, 2023

BridgeAR reviewed Sep 19, 2023
View reviewed changes

jcbhmr added 5 commits September 20, 2023 20:56

add console.assert(false, Symbol()) test
4f4db4d

fix formatting
b6e5492

formatting
8240194

LF
cc93b2a

single quotes
4c905fc

anonrig added the semver-major PRs that contain breaking changes and should be released in the next major version. label Sep 21, 2023

aduh95 approved these changes Sep 29, 2023
View reviewed changes

aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 29, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 29, 2023

mcollina approved these changes Nov 1, 2023
View reviewed changes

mcollina added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Nov 1, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 1, 2023

nodejs-github-bot merged commit 60e8364 into nodejs:mainNov 1, 2023

RafaelGSS mentioned this pull request Apr 12, 2024
2024-04-24, Version 22.0.0 (Current) #52505
Merged

Navigation Menu

Uh oh!

Uh oh!

console: treat non-strings as separate argument in console.assert() - #49722

console: treat non-strings as separate argument in console.assert()#49722
nodejs-github-bot merged 6 commits into
nodejs:mainfrom
jcbhmr:console-assert-symbol

jcbhmr commented Sep 19, 2023

Uh oh!

BridgeAR left a comment

Uh oh!

BridgeARSep 19, 2023

Uh oh!

aduh95 commented Sep 29, 2023

Uh oh!

nodejs-github-bot commented Sep 29, 2023

Uh oh!

jcbhmr commented Nov 1, 2023

Uh oh!

mcollina left a comment

Uh oh!

nodejs-github-bot commented Nov 1, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

-// https://console.spec.whatwg.org/#assert step 4.2:
-if(typeofargs[0]==="string"){
-args[0]=`Assertion failed: ${args[0]}`
-}else{
-ArrayPrototypeUnshift(args,"Assertion failed")
-}
+letbaseMessage='Assertion failed';
+if(args.length>0){
+baseMessage+=':';
+}
+ArrayPrototypeUnshift(args,"Assertion failed");

Uh oh!

Uh oh!

Conversation

jcbhmr commented Sep 19, 2023

Uh oh!

BridgeAR left a comment

Choose a reason for hiding this comment

Uh oh!

BridgeARSep 19, 2023

Choose a reason for hiding this comment

Uh oh!

aduh95 commented Sep 29, 2023

Uh oh!

nodejs-github-bot commented Sep 29, 2023

Uh oh!

jcbhmr commented Nov 1, 2023

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Nov 1, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants