deps: update V8 to 12.2 by targos · Pull Request #51362 · nodejs/node

targos · 2024-01-04T09:18:52Z

Main change that affects us: v8/v8@12203e0

Some flaky tests.
I would really appreciate help to investigate these. Node.js 22 is coming close!

12:33:52 not ok 3759 parallel/test-worker-arraybuffer-zerofill
12:33:52 ---
12:33:52 duration_ms: 120024.23700
12:33:52 severity: fail
12:33:52 exitcode: -15
12:33:52 stack: |-
12:33:52 timeout
12:33:52 ...

12:40:34 not ok 3756 parallel/test-net-write-fully-async-hex-string
12:40:34 ---
12:40:34 duration_ms: 120066.81500
12:40:34 severity: fail
12:40:34 exitcode: -15
12:40:34 stack: |-
12:40:34 timeout
12:40:34 ...

18:25:43 not ok 2444 parallel/test-shadow-realm-gc-module
18:25:43 ---
18:25:43 duration_ms: 6465.44100
18:25:43 severity: crashed
18:25:43 exitcode: -6
18:25:43 stack: |-
18:25:43 18:25:43 <--- Last few GCs --->
18:25:43 .6[1674180:0x7f32cac7f000] 5861 ms: Mark-Compact 18.1 (48.4) -> 15.5 (49.2) MB, pooled: 0 MB, 5.89 / 0.01 ms (+ 16.5 ms in 0 steps since start of marking, biggest step 0.0 ms, walltime since start of marking 26 ms) (average mu = 0.722, current mu = 0.7[1674180:0x7f32cac7f000] 6033 ms: Mark-Compact 22.4 (50.2) -> 18.8 (52.7) MB, pooled: 0 MB, 33.08 / 0.01 ms (+ 29.2 ms in 0 steps since start of marking, biggest step 0.0 ms, walltime since start of marking 134 ms) (average mu = 0.666, current mu = 0
18:25:43 18:25:43 <--- JS stacktrace --->
18:25:43 18:25:43 FATAL ERROR: Reached heap limit Allocation failed - JavaScript heap out of memory
18:25:43 ----- Native stack trace -----
18:25:43 18:25:43 ...

18:46:01 not ok 2691 parallel/test-shadow-realm-gc
18:46:01 ---
18:46:01 duration_ms: 3138.09900
18:46:01 severity: crashed
18:46:01 exitcode: -11
18:46:01 stack: |-

nodejs-github-bot · 2024-01-04T09:18:57Z

Review requested:

@nodejs/gyp
@nodejs/v8-update

targos · 2024-01-07T14:32:58Z

/cc @nodejs/platform-windows @StefanStojanovic We're hitting nodejs/node-v8#271

targos · 2024-01-07T14:56:57Z

Looks like the build is broken on AIX @nodejs/platform-aix

https://ci.nodejs.org/job/node-test-commit-aix/49875/nodes=aix72-ppc64/console

targos · 2024-01-07T15:37:36Z

Many failing test on s390: https://ci.nodejs.org/job/node-test-commit-linuxone/41750/#showFailuresLink

@nodejs/platform-s390

targos · 2024-01-08T09:33:13Z

@nodejs/platform-smartos The SmartOS build is broken (related to d1ccf72): https://ci.nodejs.org/job/node-test-commit-smartos/52823/nodes=smartos20-64/console

targos · 2024-01-08T09:35:18Z

@nodejs/platform-ppc @nodejs/platform-s390 The V8 CI build errors:

16:08:40 g++: fatal error: Killed signal terminated program cc1plus

https://ci.nodejs.org/job/node-test-commit-v8-linux/5757/nodes=rhel8-ppc64le,v8test=v8test/console
https://ci.nodejs.org/job/node-test-commit-v8-linux/5757/nodes=rhel8-s390x,v8test=v8test/console

targos · 2024-01-08T09:38:07Z

It looks like 9570832 is not enough. There's a flaky test in debug mode:

./node_g test/sequential/test-worker-fshandles-error-on-termination.js

$ ./node_g test/sequential/test-worker-fshandles-error-on-termination.js
#
# Fatal error in ../../deps/v8/src/execution/isolate-inl.h, line 105
# Debug check failed: has_exception() == result == ReadOnlyRoots(this).exception() (1 vs. 0).
#
#
#
#FailureMessage Object: 0x16f6ed148
----- Native stack trace -----
1: 0x1048b5400 node::DumpNativeBacktrace(__sFILE*) [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
2: 0x104afddd4 node::NodePlatform::GetStackTracePrinter()::$_3::operator()() const [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
3: 0x104afdd90 node::NodePlatform::GetStackTracePrinter()::$_3::__invoke() [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
4: 0x106c702f0 V8_Fatal(char const*, int, char const*, ...) [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
5: 0x106c6fe8c std::__1::enable_if<!std::is_function<std::__1::remove_pointer<char>::type>::value && !std::is_enum<char>::value && has_output_operator<char, v8::base::CheckMessageStream>::value, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>::type v8::base::PrintCheckOperand<char>(char) [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
6: 0x104ebb208 v8::internal::Isolate::VerifyBuiltinsResult(v8::internal::Tagged<v8::internal::Object>) [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
7: 0x105a4943c v8::internal::Runtime_PromiseRejectEventFromStack(int, unsigned long*, v8::internal::Isolate*) [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
8: 0x10615e7b4 Builtins_CEntry_Return1_ArgvOnStack_NoBuiltinExit [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
9: 0x1061edabc Builtins_PromiseReject [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
10: 0x1060bc370 Builtins_InterpreterEntryTrampoline [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
11: 0x1061f9420 Builtins_PromiseRejectReactionJob [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
12: 0x1060eb2ec Builtins_RunMicrotasks [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
13: 0x1060b96f4 Builtins_JSRunMicrotasksEntry [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
14: 0x105131e9c v8::internal::(anonymous namespace)::Invoke(v8::internal::Isolate*, v8::internal::(anonymous namespace)::InvokeParams const&) [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
15: 0x105133870 v8::internal::(anonymous namespace)::InvokeWithTryCatch(v8::internal::Isolate*, v8::internal::(anonymous namespace)::InvokeParams const&) [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
16: 0x105133f20 v8::internal::Execution::TryRunMicrotasks(v8::internal::Isolate*, v8::internal::MicrotaskQueue*) [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
17: 0x105186dec v8::internal::MicrotaskQueue::RunMicrotasks(v8::internal::Isolate*) [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
18: 0x105186b0c v8::internal::MicrotaskQueue::PerformCheckpointInternal(v8::Isolate*) [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
19: 0x1047f7110 node::InternalCallbackScope::Close() [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
20: 0x1047f6f2c node::InternalCallbackScope::~InternalCallbackScope() [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
21: 0x1047f6a3c node::InternalCallbackScope::~InternalCallbackScope() [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
22: 0x1049ec984 node::fs::FSReqPromise<node::AliasedBufferBase<double, v8::Float64Array>>::Reject(v8::Local<v8::Value>) [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
23: 0x104a061fc node::fs::FSReqAfterScope::Reject(uv_fs_s*) [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
24: 0x104a06324 node::fs::FSReqAfterScope::Proceed() [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
25: 0x104a06be0 node::fs::AfterOpenFileHandle(uv_fs_s*) [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
26: 0x1049ee5bc node::MakeLibuvRequestCallback<uv_fs_s, void (*)(uv_fs_s*)>::Wrapper(uv_fs_s*) [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
27: 0x10608c3c4 uv__fs_done [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
28: 0x10607e4ec uv__work_done [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
29: 0x1060874d0 uv__async_io [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
30: 0x1060aaea0 uv__io_poll [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
31: 0x106087ed0 uv_run [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
32: 0x1047fa37c node::SpinEventLoopInternal(node::Environment*) [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
33: 0x104ba3c34 node::worker::Worker::Run() [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
34: 0x104ba7cb8 node::worker::Worker::StartThread(v8::FunctionCallbackInfo<v8::Value> const&)::$_3::operator()(void*) const [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
35: 0x104ba7c64 node::worker::Worker::StartThread(v8::FunctionCallbackInfo<v8::Value> const&)::$_3::__invoke(void*) [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
36: 0x1843de034 _pthread_start [/usr/lib/system/libsystem_pthread.dylib]
37: 0x1843d8e3c thread_start [/usr/lib/system/libsystem_pthread.dylib]
[1] 34458 trace trap ./node_g test/sequential/test-worker-fshandles-error-on-termination.js

StefanStojanovic · 2024-01-08T11:15:23Z

/cc @nodejs/platform-windows @StefanStojanovic We're hitting nodejs/node-v8#271

Thanks for letting me know. I just got back to work today, so will look into it in the following days.

sumitradawn · 2024-01-08T14:30:59Z

Looks like the build is broken on AIX @nodejs/platform-aix
https://ci.nodejs.org/job/node-test-commit-aix/49875/nodes=aix72-ppc64/console

I have checked and the v8 build is fine for AIX wrt current commit id- ff9dc695ffc0412baf644e4cddfa92b93cd2b978 (HEAD, origin/main, origin/HEAD)

targos · 2024-01-08T14:48:27Z

@sumitradawn This is not with V8 HEAD. It's with 12.1-lkgr

sumitradawn · 2024-01-09T13:57:05Z

@sumitradawn This is not with V8 HEAD. It's with 12.1-lkgr

@targos I have tried to build Node from the source code on AIX and it is quite fine for me. There might be some memory issue, Can you please try to run the job with -j4 option.

targos · 2024-01-09T14:24:03Z

Run with -j 4: https://ci.nodejs.org/view/All/job/node-test-commit-aix-targos/1/nodes=aix72-ppc64/

Otherwise re-entering V8 doesn't work as expected after exceptions were thrown. Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5050065 Co-Authored-By: Toon Verwaest <verwaest@chromium.org> Co-Authored-By: deepak1556 <hop2deep@gmail.com>

Co-authored-by: Etienne Pierre-Doray <etiennep@chromium.org>

Refs: v8/v8@23e3b6f

Previous limit was too low for debug builds.

Refs: v8/v8@80fb767

Refs: nodejs#52273

Refs: nodejs#52274

targos · 2024-03-30T09:04:24Z

Rebased and added flaky designations to the tests.

nodejs-github-bot · 2024-03-30T09:05:06Z

CI: https://ci.nodejs.org/job/node-test-pull-request/58004/

nodejs-github-bot · 2024-03-30T12:52:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/58005/

aduh95

LGTM, thanks for the hard work! Non-blocking comment: I wonder if d5ac47e and 59e4518 should be backported

nodejs-github-bot · 2024-03-30T18:51:45Z

CI: https://ci.nodejs.org/job/node-test-pull-request/58007/

nodejs-github-bot · 2024-03-31T06:14:38Z

CI: https://ci.nodejs.org/job/node-test-pull-request/58011/

nodejs-github-bot · 2024-03-31T08:14:56Z

CI: https://ci.nodejs.org/job/node-test-pull-request/58012/

PR-URL: #51362 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 12.2. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md PR-URL: #51362 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

dllexport introduces issues when compiling with MSVC. PR-URL: #47251 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> PR-URL: #51362 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: #45579 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: #51362 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

targos · 2024-03-31T13:38:09Z

Thanks for the reviews, and everyone who helped!

Landed in d9aa33f...9efc84a

targos added help wanted Issues that need assistance from volunteers or PRs that need help to proceed. semver-major PRs that contain breaking changes and should be released in the next major version. v8 engine Issues and PRs related to the V8 dependency. labels Jan 4, 2024

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Jan 4, 2024

This comment was marked as outdated.
Sign in to view

targos mentioned this pull request Jan 4, 2024
Build fails on Windows/MSVC nodejs/node-v8#271
Closed

This comment was marked as outdated.
Sign in to view

This comment was marked as resolved.
Sign in to view

targos force-pushed the v8-121 branch from 0d05f47 to bc765d0Compare January 7, 2024 14:05

This was referenced Jan 7, 2024
Build error on macOS 11 nodejs/node-v8#276
Closed
test-inspector-vm-global-accessors-getter-sideeffect fails with debug build nodejs/node-v8#274
Closed

targos added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 7, 2024

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 7, 2024

This comment was marked as outdated.
Sign in to view

targosand others added 5 commits March 30, 2024 09:55

src: add missing TryCatch
59e4518
Otherwise re-entering V8 doesn't work as expected after exceptions were thrown. Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5050065 Co-Authored-By: Toon Verwaest <verwaest@chromium.org> Co-Authored-By: deepak1556 <hop2deep@gmail.com>

src: update default V8 platform to override functions with location
6696855
Co-authored-by: Etienne Pierre-Doray <etiennep@chromium.org>

src: use supported API to get stalled TLA messages
1827161
Refs: v8/v8@23e3b6f

test: allow slightly more diff in memory leak test
d5ac47e
Previous limit was too low for debug builds.

lib,test: handle new Iterator global
c131f74
Refs: v8/v8@80fb767

targos mentioned this pull request Mar 30, 2024
Flaky GC-related tests with V8 12.2 #52273
Closed

test: mark some GC-related tests as flaky
d8b04a9
Refs: nodejs#52273

targos mentioned this pull request Mar 30, 2024
Flaky test-worker-arraybuffer-zerofill with V8 12.2 #52274
Closed

test: mark test-worker-arraybuffer-zerofill as flaky
f188183
Refs: nodejs#52274

targos force-pushed the v8-121 branch from e7f0082 to f188183Compare March 30, 2024 09:04

aduh95 approved these changes Mar 30, 2024
View reviewed changes

RafaelGSS approved these changes Mar 30, 2024
View reviewed changes

targos self-assigned this Mar 31, 2024

targos removed the help wanted Issues that need assistance from volunteers or PRs that need help to proceed. label Mar 31, 2024

targos added a commit that referenced this pull request Mar 31, 2024
deps: update V8 to 12.2.281.27
09a8440
PR-URL: #51362 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

RafaelGSS mentioned this pull request Apr 12, 2024
2024-04-24, Version 22.0.0 (Current) #52505
Merged

aduh95 mentioned this pull request May 11, 2024
v8: update default platform to override functions with location #50289
Closed

legendecas mentioned this pull request Jun 13, 2024
node_mksnapshot debug build segfault #53446
Closed

jazelly mentioned this pull request May 13, 2025
[v22.x backport] src: initialize privateSymbols for per_context #58217
Closed

Uh oh!

Uh oh!

Conversation

targos commented Jan 4, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Jan 4, 2024

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as resolved.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

targos commented Jan 7, 2024

Uh oh!

targos commented Jan 7, 2024

Uh oh!

targos commented Jan 7, 2024

Uh oh!

targos commented Jan 8, 2024

Uh oh!

targos commented Jan 8, 2024

Uh oh!

targos commented Jan 8, 2024

Uh oh!

StefanStojanovic commented Jan 8, 2024

Uh oh!

sumitradawn commented Jan 8, 2024

Uh oh!

targos commented Jan 8, 2024

Uh oh!

sumitradawn commented Jan 9, 2024

Uh oh!

targos commented Jan 9, 2024

Uh oh!

targos commented Mar 30, 2024

Uh oh!

nodejs-github-bot commented Mar 30, 2024

Uh oh!

nodejs-github-bot commented Mar 30, 2024

Uh oh!

aduh95 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Mar 30, 2024

Uh oh!

nodejs-github-bot commented Mar 31, 2024

Uh oh!

nodejs-github-bot commented Mar 31, 2024

Uh oh!

targos commented Mar 31, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

targos commented Jan 4, 2024•
edited
Loading

aduh95 left a comment •
edited
Loading

targos commented Mar 31, 2024•
edited
Loading