Uh oh!
There was an error while loading. Please reload this page.
v8: update default platform to override functions with location - #50289
Closed
eti-p-doray wants to merge 10 commits into
Closed
v8: update default platform to override functions with location#50289eti-p-doray wants to merge 10 commits into
eti-p-doray wants to merge 10 commits into
Conversation
v8 platform is migrating to PostTask functions with location. https://chromium-review.googlesource.com/c/v8/v8/+/4336198
eti-p-doray
marked this pull request as draft
October 19, 2023 14:54
eti-p-doray
marked this pull request as ready for review
October 19, 2023 14:56
targos
commented
Oct 19, 2023
Member
@nodejs/cpp-reviewers |
eti-p-doray
commented
Oct 24, 2023
ContributorAuthor
I fix the linting issues (I think) |
joyeecheung
approved these changes
Oct 24, 2023
nodejs-github-bot
commented
Oct 24, 2023
Collaborator
16 tasks
Qard
approved these changes
Oct 25, 2023
nodejs-github-bot
commented
Oct 25, 2023
Collaborator
This was referenced Oct 26, 2023
eti-p-doray
commented
Nov 10, 2023
ContributorAuthor
I'm not sure what to do with the CI failure. e.g. macOs shows Is this failure related to this PR? |
RafaelGSS
commented
Nov 10, 2023
Member
Can you rebase on |
eti-p-doray
commented
Nov 17, 2023
ContributorAuthor
I rebased to latest commit on main |
nodejs-github-bot
commented
Nov 17, 2023
Collaborator
jasnell
approved these changes
Nov 19, 2023
eti-p-doray
commented
Nov 23, 2023
ContributorAuthor
All checks have passed but merging is restricted. |
eti-p-doray
commented
Nov 29, 2023
ContributorAuthor
I think I need an authorized user to merge it, @targos? |
lpinca
commented
Dec 29, 2023
Member
@eti-p-doray please remove the merge commits. |
aduh95
commented
May 11, 2024
Contributor
This landed as part of #51362. Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v8 platform is migrating to PostTask functions with location.
https://chromium-review.googlesource.com/c/v8/v8/+/4336198
This PR updates default platform to overrides the new versions of functions.