Skip to content

streams: use Array for Readable buffer - #50341

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
nxtedition:readable-array-buffer
Oct 25, 2023
Merged

streams: use Array for Readable buffer#50341
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
nxtedition:readable-array-buffer

Conversation

@ronag

@ronagronag commented Oct 23, 2023•
edited
Loading

Copy link
Copy Markdown
Member

This replaces the Readable stream linked list BufferList buffer with an Array and index.

23:49:48 streams/pipe-object-mode.js n=5000000 *** 23.56 % ±4.03% ±5.36% ±6.98%
23:49:48 streams/pipe.js n=5000000 *** 18.77 % ±2.88% ±3.84% ±5.00%
23:49:48 streams/readable-async-iterator.js sync='no' n=100000 0.86 % ±3.80% ±5.06% ±6.59%
23:49:48 streams/readable-async-iterator.js sync='yes' n=100000 *** 7.33 % ±3.76% ±5.01% ±6.52%
23:49:48 streams/readable-bigread.js n=1000 *** 8.48 % ±4.51% ±6.01% ±7.82%
23:49:48 streams/readable-bigunevenread.js n=1000 *** 13.56 % ±1.78% ±2.37% ±3.08%
23:49:48 streams/readable-boundaryread.js type='buffer' n=2000 *** 11.92 % ±1.39% ±1.85% ±2.41%
23:49:48 streams/readable-boundaryread.js type='string' n=2000 *** 1.99 % ±0.99% ±1.32% ±1.72%
23:49:48 streams/readable-from.js n=10000000 *** 17.22 % ±5.10% ±6.80% ±8.87%
23:49:48 streams/readable-readall.js n=5000 *** 9.66 % ±5.47% ±7.28% ±9.49%
23:49:48 streams/readable-unevenread.js n=1000 *** 4.80 % ±0.40% ±0.54% ±0.70%

@nodejs-github-bot

nodejs-github-bot commented Oct 23, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/streams

@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 23, 2023
@ronag
ronagforce-pushed the readable-array-buffer branch 2 times, most recently from 38a496c to 19d2341CompareOctober 23, 2023 15:06
anonrig
anonrig reviewed Oct 23, 2023
View reviewed changes
Comment threadlib/internal/streams/readable.js Outdated
Comment threadlib/internal/streams/readable.js Outdated
@ronag
ronagforce-pushed the readable-array-buffer branch 4 times, most recently from ca3438d to b31ef38CompareOctober 23, 2023 18:58
@ronag

This comment was marked as outdated.

Sign in to view
@ronag
ronagforce-pushed the readable-array-buffer branch 2 times, most recently from 2944cda to 03d9416CompareOctober 23, 2023 19:15
@ronag

This comment was marked as outdated.

Sign in to view
@ronag
ronagforce-pushed the readable-array-buffer branch 3 times, most recently from 492bb00 to 1bffeceCompareOctober 23, 2023 19:30
@ronag

This comment was marked as outdated.

Sign in to view
@ronag
ronagforce-pushed the readable-array-buffer branch 2 times, most recently from 30deb62 to beb5c0eCompareOctober 23, 2023 19:55
@ronag
ronag requested a review from mcollinaOctober 23, 2023 20:05
@ronag
ronagforce-pushed the readable-array-buffer branch from beb5c0e to d302834CompareOctober 23, 2023 20:05
@ronag
ronag requested a review from benjamingrOctober 23, 2023 20:05
@ronag
ronag marked this pull request as ready for review October 23, 2023 20:05
@ronag
ronagforce-pushed the readable-array-buffer branch from d302834 to b4577b0CompareOctober 23, 2023 20:06
@ronag
ronagforce-pushed the readable-array-buffer branch from b4577b0 to 442787bCompareOctober 23, 2023 20:07
@ronag
ronagforce-pushed the readable-array-buffer branch from 442787b to 59f941eCompareOctober 23, 2023 20:16
@github-actionsgithub-actionsBot mentioned this pull request Oct 29, 2023
Open
21 tasks
targos pushed a commit that referenced this pull request Nov 11, 2023
@ronag@targos
stream: use Array for Readable buffer
65850a6
PR-URL: #50341
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos added a commit that referenced this pull request Nov 12, 2023
@targos
2023-11-14, Version 21.2.0 (Current)
9183a07
Notable changes:
doc:
* add MrJithil to collaborators (Jithil P Ponnan) #50666
* add Ethan-Arrowood as a collaborator (Ethan Arrowood) #50393
esm:
* (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) #48740
fs:
* add stacktrace to fs/promises (翠 / green) #49849
lib:
* (SEMVER-MINOR) add navigator.platform (Aras Abbasi) #50385
stream:
* (SEMVER-MINOR) add support for `deflate-raw` format to webstreams compression (Damian Krzeminski) #50097
* use Array for Readable buffer (Robert Nagy) #50341
* optimize creation (Robert Nagy) #50337
test_runner:
* adds built in lcov reporter (Phil Nash) #50018
* (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) #48638
test_runner, cli:
* (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) #50443
PR-URL: #50681
@targostargos mentioned this pull request Nov 12, 2023
Merged
targos added a commit that referenced this pull request Nov 13, 2023
@targos
2023-11-14, Version 21.2.0 (Current)
0f82899
Notable changes:
doc:
* add MrJithil to collaborators (Jithil P Ponnan) #50666
* add Ethan-Arrowood as a collaborator (Ethan Arrowood) #50393
esm:
* (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) #48740
fs:
* add stacktrace to fs/promises (翠 / green) #49849
lib:
* (SEMVER-MINOR) add `--no-experimental-global-navigator` CLI flag (Antoine du Hamel) #50562
* (SEMVER-MINOR) add navigator.language & navigator.languages (Aras Abbasi) #50303
* (SEMVER-MINOR) add navigator.platform (Aras Abbasi) #50385
stream:
* (SEMVER-MINOR) add support for `deflate-raw` format to webstreams compression (Damian Krzeminski) #50097
* use Array for Readable buffer (Robert Nagy) #50341
* optimize creation (Robert Nagy) #50337
test_runner:
* (SEMVER-MINOR) adds built in lcov reporter (Phil Nash) #50018
* (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) #48638
test_runner, cli:
* (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) #50443
PR-URL: #50681
targos added a commit that referenced this pull request Nov 14, 2023
@targos
2023-11-14, Version 21.2.0 (Current)
13b266f
Notable changes:
doc:
* add MrJithil to collaborators (Jithil P Ponnan) #50666
* add Ethan-Arrowood as a collaborator (Ethan Arrowood) #50393
esm:
* (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) #48740
fs:
* add stacktrace to fs/promises (翠 / green) #49849
lib:
* (SEMVER-MINOR) add `--no-experimental-global-navigator` CLI flag (Antoine du Hamel) #50562
* (SEMVER-MINOR) add navigator.language & navigator.languages (Aras Abbasi) #50303
* (SEMVER-MINOR) add navigator.platform (Aras Abbasi) #50385
stream:
* (SEMVER-MINOR) add support for `deflate-raw` format to webstreams compression (Damian Krzeminski) #50097
* use Array for Readable buffer (Robert Nagy) #50341
* optimize creation (Robert Nagy) #50337
test_runner:
* (SEMVER-MINOR) adds built in lcov reporter (Phil Nash) #50018
* (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) #48638
test_runner, cli:
* (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) #50443
PR-URL: #50681
targos added a commit that referenced this pull request Nov 14, 2023
@targos
2023-11-14, Version 21.2.0 (Current)
02db7fc
Notable changes:
doc:
* add MrJithil to collaborators (Jithil P Ponnan) #50666
* add Ethan-Arrowood as a collaborator (Ethan Arrowood) #50393
esm:
* (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) #48740
fs:
* add stacktrace to fs/promises (翠 / green) #49849
lib:
* (SEMVER-MINOR) add `--no-experimental-global-navigator` CLI flag (Antoine du Hamel) #50562
* (SEMVER-MINOR) add navigator.language & navigator.languages (Aras Abbasi) #50303
* (SEMVER-MINOR) add navigator.platform (Aras Abbasi) #50385
stream:
* (SEMVER-MINOR) add support for `deflate-raw` format to webstreams compression (Damian Krzeminski) #50097
* use Array for Readable buffer (Robert Nagy) #50341
* optimize creation (Robert Nagy) #50337
test_runner:
* (SEMVER-MINOR) adds built in lcov reporter (Phil Nash) #50018
* (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) #48638
test_runner, cli:
* (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) #50443
PR-URL: #50681
@jamie-phlojamie-phlo mentioned this pull request Nov 20, 2023
Closed
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@ronag@UlisesGascon
stream: use Array for Readable buffer
139d6c8
PR-URL: #50341
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
UlisesGascon added a commit that referenced this pull request Dec 12, 2023
@UlisesGascon
2023-12-14, Version 20.11.0 'Iron' (LTS)
f02ed77
Notable changes:
crypto:
* update root certificates to NSS 3.95 (Node.js GitHub Bot) #50805
doc:
* add MrJithil to collaborators (Jithil P Ponnan) #50666
* add Ethan-Arrowood as a collaborator (Ethan Arrowood) #50393
esm:
* (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) #48740
fs:
* add c++ fast path for writeFileSync utf8 (CanadaHonk) #49884
module:
* (SEMVER-MINOR) remove useCustomLoadersIfPresent flag (Chengzhong Wu) #48655
src:
* (SEMVER-MINOR) add `--disable-warning` option (Ethan Arrowood) #50661
* (SEMVER-MINOR) create per isolate proxy env template (Chengzhong Wu) #48655
* (SEMVER-MINOR) make process binding data weak (Chengzhong Wu) #48655
stream:
* use Array for Readable buffer (Robert Nagy) #50341
* optimize creation (Robert Nagy) #50337
test_runner:
* (SEMVER-MINOR) adds built in lcov reporter (Phil Nash) #50018
* (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) #48638
test_runner, cli:
* (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) #50443
PR-URL: TODO
@UlisesGasconUlisesGascon mentioned this pull request Dec 12, 2023
Merged
UlisesGascon added a commit that referenced this pull request Dec 12, 2023
@UlisesGascon
2023-12-14, Version 20.11.0 'Iron' (LTS)
ee7e999
Notable changes:
crypto:
* update root certificates to NSS 3.95 (Node.js GitHub Bot) #50805
doc:
* add MrJithil to collaborators (Jithil P Ponnan) #50666
* add Ethan-Arrowood as a collaborator (Ethan Arrowood) #50393
esm:
* (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) #48740
fs:
* add c++ fast path for writeFileSync utf8 (CanadaHonk) #49884
module:
* (SEMVER-MINOR) remove useCustomLoadersIfPresent flag (Chengzhong Wu) #48655
src:
* (SEMVER-MINOR) add `--disable-warning` option (Ethan Arrowood) #50661
* (SEMVER-MINOR) create per isolate proxy env template (Chengzhong Wu) #48655
* (SEMVER-MINOR) make process binding data weak (Chengzhong Wu) #48655
stream:
* use Array for Readable buffer (Robert Nagy) #50341
* optimize creation (Robert Nagy) #50337
test_runner:
* (SEMVER-MINOR) adds built in lcov reporter (Phil Nash) #50018
* (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) #48638
test_runner, cli:
* (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) #50443
PR-URL: #51124
UlisesGascon added a commit that referenced this pull request Dec 13, 2023
@UlisesGascon
2023-12-14, Version 20.11.0 'Iron' (LTS)
86c2275
Notable changes:
crypto:
* update root certificates to NSS 3.95 (Node.js GitHub Bot) #50805
doc:
* add MrJithil to collaborators (Jithil P Ponnan) #50666
* add Ethan-Arrowood as a collaborator (Ethan Arrowood) #50393
esm:
* (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) #48740
fs:
* add c++ fast path for writeFileSync utf8 (CanadaHonk) #49884
module:
* (SEMVER-MINOR) remove useCustomLoadersIfPresent flag (Chengzhong Wu) #48655
src:
* (SEMVER-MINOR) add `--disable-warning` option (Ethan Arrowood) #50661
* (SEMVER-MINOR) create per isolate proxy env template (Chengzhong Wu) #48655
* (SEMVER-MINOR) make process binding data weak (Chengzhong Wu) #48655
stream:
* use Array for Readable buffer (Robert Nagy) #50341
* optimize creation (Robert Nagy) #50337
test_runner:
* (SEMVER-MINOR) adds built in lcov reporter (Phil Nash) #50018
* (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) #48638
test_runner, cli:
* (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) #50443
PR-URL: #51124
UlisesGascon added a commit that referenced this pull request Dec 15, 2023
@UlisesGascon
2023-12-18, Version 20.11.0 'Iron' (LTS)
c966327
Notable changes:
crypto:
* update root certificates to NSS 3.95 (Node.js GitHub Bot) #50805
doc:
* add MrJithil to collaborators (Jithil P Ponnan) #50666
* add Ethan-Arrowood as a collaborator (Ethan Arrowood) #50393
esm:
* (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) #48740
fs:
* add c++ fast path for writeFileSync utf8 (CanadaHonk) #49884
module:
* (SEMVER-MINOR) remove useCustomLoadersIfPresent flag (Chengzhong Wu) #48655
* (SEMVER-MINOR) bootstrap module loaders in shadow realm (Chengzhong Wu) #48655
src:
* (SEMVER-MINOR) add `--disable-warning` option (Ethan Arrowood) #50661
* (SEMVER-MINOR) create per isolate proxy env template (Chengzhong Wu) #48655
* (SEMVER-MINOR) make process binding data weak (Chengzhong Wu) #48655
stream:
* use Array for Readable buffer (Robert Nagy) #50341
* optimize creation (Robert Nagy) #50337
test_runner:
* (SEMVER-MINOR) adds built in lcov reporter (Phil Nash) #50018
* (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) #48638
test_runner, cli:
* (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) #50443
PR-URL: #51124
UlisesGascon added a commit that referenced this pull request Dec 15, 2023
@UlisesGascon
2023-12-18, Version 20.11.0 'Iron' (LTS)
30081c1
Notable changes:
crypto:
* update root certificates to NSS 3.95 (Node.js GitHub Bot) #50805
doc:
* add MrJithil to collaborators (Jithil P Ponnan) #50666
* add Ethan-Arrowood as a collaborator (Ethan Arrowood) #50393
esm:
* (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) #48740
fs:
* add c++ fast path for writeFileSync utf8 (CanadaHonk) #49884
module:
* (SEMVER-MINOR) remove useCustomLoadersIfPresent flag (Chengzhong Wu) #48655
* (SEMVER-MINOR) bootstrap module loaders in shadow realm (Chengzhong Wu) #48655
src:
* (SEMVER-MINOR) add `--disable-warning` option (Ethan Arrowood) #50661
* (SEMVER-MINOR) create per isolate proxy env template (Chengzhong Wu) #48655
* (SEMVER-MINOR) make process binding data weak (Chengzhong Wu) #48655
stream:
* use Array for Readable buffer (Robert Nagy) #50341
* optimize creation (Robert Nagy) #50337
test_runner:
* (SEMVER-MINOR) adds built in lcov reporter (Phil Nash) #50018
* (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) #48638
test_runner, cli:
* (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) #50443
PR-URL: #51124
UlisesGascon added a commit that referenced this pull request Dec 20, 2023
@UlisesGascon
2023-12-21, Version 20.11.0 'Iron' (LTS)
1a0be53
Notable changes:
crypto:
* update root certificates to NSS 3.95 (Node.js GitHub Bot) #50805
doc:
* add MrJithil to collaborators (Jithil P Ponnan) #50666
* add Ethan-Arrowood as a collaborator (Ethan Arrowood) #50393
esm:
* (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) #48740
fs:
* add c++ fast path for writeFileSync utf8 (CanadaHonk) #49884
module:
* (SEMVER-MINOR) remove useCustomLoadersIfPresent flag (Chengzhong Wu) #48655
* (SEMVER-MINOR) bootstrap module loaders in shadow realm (Chengzhong Wu) #48655
src:
* (SEMVER-MINOR) add `--disable-warning` option (Ethan Arrowood) #50661
* (SEMVER-MINOR) create per isolate proxy env template (Chengzhong Wu) #48655
* (SEMVER-MINOR) make process binding data weak (Chengzhong Wu) #48655
stream:
* use Array for Readable buffer (Robert Nagy) #50341
* optimize creation (Robert Nagy) #50337
test_runner:
* (SEMVER-MINOR) adds built in lcov reporter (Phil Nash) #50018
* (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) #48638
test_runner, cli:
* (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) #50443
PR-URL: #51124
UlisesGascon added a commit that referenced this pull request Jan 3, 2024
@UlisesGascon
2024-01-03, Version 20.11.0 'Iron' (LTS)
fc48ba7
Notable changes:
crypto:
* update root certificates to NSS 3.95 (Node.js GitHub Bot) #50805
doc:
* add MrJithil to collaborators (Jithil P Ponnan) #50666
* add Ethan-Arrowood as a collaborator (Ethan Arrowood) #50393
esm:
* (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) #48740
fs:
* add c++ fast path for writeFileSync utf8 (CanadaHonk) #49884
module:
* (SEMVER-MINOR) remove useCustomLoadersIfPresent flag (Chengzhong Wu) #48655
* (SEMVER-MINOR) bootstrap module loaders in shadow realm (Chengzhong Wu) #48655
src:
* (SEMVER-MINOR) add `--disable-warning` option (Ethan Arrowood) #50661
* (SEMVER-MINOR) create per isolate proxy env template (Chengzhong Wu) #48655
* (SEMVER-MINOR) make process binding data weak (Chengzhong Wu) #48655
stream:
* use Array for Readable buffer (Robert Nagy) #50341
* optimize creation (Robert Nagy) #50337
test_runner:
* (SEMVER-MINOR) adds built in lcov reporter (Phil Nash) #50018
* (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) #48638
test_runner, cli:
* (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) #50443
PR-URL: #51124
UlisesGascon added a commit that referenced this pull request Jan 4, 2024
@UlisesGascon
2024-01-08, Version 20.11.0 'Iron' (LTS)
72bf8da
Notable changes:
crypto:
* update root certificates to NSS 3.95 (Node.js GitHub Bot) #50805
doc:
* add MrJithil to collaborators (Jithil P Ponnan) #50666
* add Ethan-Arrowood as a collaborator (Ethan Arrowood) #50393
esm:
* (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) #48740
fs:
* add c++ fast path for writeFileSync utf8 (CanadaHonk) #49884
module:
* (SEMVER-MINOR) remove useCustomLoadersIfPresent flag (Chengzhong Wu) #48655
* (SEMVER-MINOR) bootstrap module loaders in shadow realm (Chengzhong Wu) #48655
src:
* (SEMVER-MINOR) add `--disable-warning` option (Ethan Arrowood) #50661
* (SEMVER-MINOR) create per isolate proxy env template (Chengzhong Wu) #48655
* (SEMVER-MINOR) make process binding data weak (Chengzhong Wu) #48655
stream:
* use Array for Readable buffer (Robert Nagy) #50341
* optimize creation (Robert Nagy) #50337
test_runner:
* (SEMVER-MINOR) adds built in lcov reporter (Phil Nash) #50018
* (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) #48638
test_runner, cli:
* (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) #50443
PR-URL: #51124
UlisesGascon added a commit that referenced this pull request Jan 9, 2024
@UlisesGascon
2024-01-09, Version 20.11.0 'Iron' (LTS)
8d4fbd7
Notable changes:
crypto:
* update root certificates to NSS 3.95 (Node.js GitHub Bot) #50805
doc:
* add MrJithil to collaborators (Jithil P Ponnan) #50666
* add Ethan-Arrowood as a collaborator (Ethan Arrowood) #50393
esm:
* (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) #48740
fs:
* add c++ fast path for writeFileSync utf8 (CanadaHonk) #49884
module:
* (SEMVER-MINOR) remove useCustomLoadersIfPresent flag (Chengzhong Wu) #48655
* (SEMVER-MINOR) bootstrap module loaders in shadow realm (Chengzhong Wu) #48655
src:
* (SEMVER-MINOR) add `--disable-warning` option (Ethan Arrowood) #50661
* (SEMVER-MINOR) create per isolate proxy env template (Chengzhong Wu) #48655
* (SEMVER-MINOR) make process binding data weak (Chengzhong Wu) #48655
stream:
* use Array for Readable buffer (Robert Nagy) #50341
* optimize creation (Robert Nagy) #50337
test_runner:
* (SEMVER-MINOR) adds built in lcov reporter (Phil Nash) #50018
* (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) #48638
test_runner, cli:
* (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) #50443
PR-URL: #51124
UlisesGascon added a commit that referenced this pull request Jan 9, 2024
@UlisesGascon
2024-01-09, Version 20.11.0 'Iron' (LTS)
2d74e77
Notable changes:
crypto:
* update root certificates to NSS 3.95 (Node.js GitHub Bot) #50805
doc:
* add MrJithil to collaborators (Jithil P Ponnan) #50666
* add Ethan-Arrowood as a collaborator (Ethan Arrowood) #50393
esm:
* (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) #48740
fs:
* add c++ fast path for writeFileSync utf8 (CanadaHonk) #49884
module:
* (SEMVER-MINOR) remove useCustomLoadersIfPresent flag (Chengzhong Wu) #48655
* (SEMVER-MINOR) bootstrap module loaders in shadow realm (Chengzhong Wu) #48655
src:
* (SEMVER-MINOR) add `--disable-warning` option (Ethan Arrowood) #50661
* (SEMVER-MINOR) create per isolate proxy env template (Chengzhong Wu) #48655
* (SEMVER-MINOR) make process binding data weak (Chengzhong Wu) #48655
stream:
* use Array for Readable buffer (Robert Nagy) #50341
* optimize creation (Robert Nagy) #50337
test_runner:
* (SEMVER-MINOR) adds built in lcov reporter (Phil Nash) #50018
* (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) #48638
test_runner, cli:
* (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) #50443
PR-URL: #51124
@nadavziponadavzipo mentioned this pull request Jan 14, 2024
Closed
@nadavzipo

nadavzipo commented Jan 14, 2024

Copy link
Copy Markdown

@ronag I think this change caused breaking changes in the streams api.
Please see the following related issue - googleapis/nodejs-storage#2391

@ronag

ronag commented Jan 14, 2024

Copy link
Copy Markdown
MemberAuthor

@ronag I think this change caused breaking changes in the streams api.

Please see the following related issue - googleapis/nodejs-storage#2391

The stream-shift module is using private properties. So while this change does break it, it's using stuff it shouldn't be using.

I'll give it some thought whether we can add some compat.

I would recommend either fixing g stream-shift or stop using it.

@ronag

ronag commented Jan 14, 2024•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Even better, stop using duplexify package. We have correspond functionality in node core.

@nadavzipo

nadavzipo commented Jan 14, 2024

Copy link
Copy Markdown

@ronag thanks for taking a look.
I will need to revert to node 20.10.0 to solve this until googleapis/nodejs-storage will address this.

@fbeaudoincoveofbeaudoincoveo mentioned this pull request Jan 15, 2024
Merged
1 task
@ChocobozzzChocobozzz mentioned this pull request Jan 19, 2024
Merged
@HeverFarberHeverFarber mentioned this pull request Mar 12, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QardQardQard left review comments
@benjamingrbenjamingrbenjamingr approved these changes
@anonriganonriganonrig approved these changes
@H4adH4adH4ad approved these changes
@mcollinamcollinaAwaiting requested review from mcollina

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.notable-changePRs with changes that should be highlighted in changelogs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ronag@nodejs-github-bot@Qard@benjamingr@nadavzipo@anonrig@H4ad