lib: add `--no-experimental-global-navigator` CLI flag by aduh95 · Pull Request #50562 · nodejs/node

aduh95 · 2023-11-05T10:59:20Z

Alternative to #50554 and #50412, in the hope we can get consensus on something.

nodejs-github-bot · 2023-11-05T10:59:25Z

Review requested:

@nodejs/startup
@nodejs/web-standards

mcollina

lgtm

nodejs-github-bot · 2023-11-07T08:38:25Z

CI: https://ci.nodejs.org/job/node-test-pull-request/55469/

anonrig · 2023-11-07T09:16:24Z

 kAllowedInEnvvar,
 true);
+ AddOption("--experimental-global-navigator",
+ "expose experimental Navigator API on the global scope",


What's the reason for adding this noop? It doesn't seem to be used, or mentioned in anywhere.

It's not a no-op, it's the flag being added; see the above one for an another example of such flag:
node/src/node_options.cc
Lines 389 to 393 in 3860002
AddOption("--experimental-global-customevent",
"expose experimental CustomEvent on the global scope",
&EnvironmentOptions::experimental_global_customevent,
kAllowedInEnvvar,
true);
That being said, it looks like I forgot to switch the default value to true

nodejs-github-bot · 2023-11-07T09:57:53Z

CI: https://ci.nodejs.org/job/node-test-pull-request/55472/

nodejs-github-bot · 2023-11-08T13:51:56Z

CI: https://ci.nodejs.org/job/node-test-pull-request/55497/

nodejs-github-bot · 2023-11-08T16:46:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/55502/

nodejs-github-bot · 2023-11-08T17:24:53Z

Landed in 309c71a

PR-URL: #50562 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>

targos · 2023-11-13T07:25:05Z

This is semver-minor. Collaborators, please think about adding the label in future pull requests. It will make the work of releasers easier.

Notable changes: doc: * add MrJithil to collaborators (Jithil P Ponnan) #50666 * add Ethan-Arrowood as a collaborator (Ethan Arrowood) #50393 esm: * (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) #48740 fs: * add stacktrace to fs/promises (翠 / green) #49849 lib: * (SEMVER-MINOR) add `--no-experimental-global-navigator` CLI flag (Antoine du Hamel) #50562 * (SEMVER-MINOR) add navigator.language & navigator.languages (Aras Abbasi) #50303 * (SEMVER-MINOR) add navigator.platform (Aras Abbasi) #50385 stream: * (SEMVER-MINOR) add support for `deflate-raw` format to webstreams compression (Damian Krzeminski) #50097 * use Array for Readable buffer (Robert Nagy) #50341 * optimize creation (Robert Nagy) #50337 test_runner: * (SEMVER-MINOR) adds built in lcov reporter (Phil Nash) #50018 * (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) #48638 test_runner, cli: * (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) #50443 PR-URL: #50681

PR-URL: #50562 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>

Notable changes: doc: * add MrJithil to collaborators (Jithil P Ponnan) #50666 * add Ethan-Arrowood as a collaborator (Ethan Arrowood) #50393 esm: * (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) #48740 fs: * add stacktrace to fs/promises (翠 / green) #49849 lib: * (SEMVER-MINOR) add `--no-experimental-global-navigator` CLI flag (Antoine du Hamel) #50562 * (SEMVER-MINOR) add navigator.language & navigator.languages (Aras Abbasi) #50303 * (SEMVER-MINOR) add navigator.platform (Aras Abbasi) #50385 stream: * (SEMVER-MINOR) add support for `deflate-raw` format to webstreams compression (Damian Krzeminski) #50097 * use Array for Readable buffer (Robert Nagy) #50341 * optimize creation (Robert Nagy) #50337 test_runner: * (SEMVER-MINOR) adds built in lcov reporter (Phil Nash) #50018 * (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) #48638 test_runner, cli: * (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) #50443 PR-URL: #50681

lib: add --no-experimental-global-navigator CLI flag
3860002

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. labels Nov 5, 2023

GeoffreyBooth reviewed Nov 5, 2023
View reviewed changes

Comment threaddoc/api/cli.md

mcollina approved these changes Nov 5, 2023
View reviewed changes

aduh95 mentioned this pull request Nov 5, 2023
lib: hide navigator behind a flag #50412
Closed

GeoffreyBooth mentioned this pull request Nov 5, 2023
cli: add flag for disabling globals #50554
Closed

GeoffreyBooth approved these changes Nov 6, 2023
View reviewed changes

legendecas approved these changes Nov 7, 2023
View reviewed changes

aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 7, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 7, 2023

anonrig reviewed Nov 7, 2023
View reviewed changes

fixup! lib: add --no-experimental-global-navigator CLI flag
7207059

aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 7, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 7, 2023

github-actionsBot mentioned this pull request Nov 8, 2023
CI Reliability 2023-11-08 nodejs/reliability#711
Open
16 tasks

richardlau approved these changes Nov 8, 2023
View reviewed changes

Ethan-Arrowood approved these changes Nov 8, 2023
View reviewed changes

GeoffreyBooth approved these changes Nov 8, 2023
View reviewed changes

GeoffreyBooth added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Nov 8, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 8, 2023

nodejs-github-bot merged commit 309c71a into nodejs:mainNov 8, 2023

aduh95 deleted the flag-no-navigator branch November 8, 2023 18:57

github-actionsBot mentioned this pull request Nov 9, 2023
CI Reliability 2023-11-09 nodejs/reliability#712
Open
20 tasks

richardlau added dont-land-on-v18.x labels Nov 9, 2023

This was referenced Nov 10, 2023
CI Reliability 2023-11-10 nodejs/reliability#713
Open
CI Reliability 2023-11-11 nodejs/reliability#714
Open

github-actionsBot mentioned this pull request Nov 12, 2023
CI Reliability 2023-11-12 nodejs/reliability#715
Open
18 tasks

targos mentioned this pull request Nov 12, 2023
v21.2.0 release proposal #50681
Merged

targos added the semver-minor PRs that contain new features and should be released in the next minor version. label Nov 13, 2023

Navigation Menu

Uh oh!

Uh oh!

lib: add `--no-experimental-global-navigator` CLI flag - #50562

lib: add `--no-experimental-global-navigator` CLI flag#50562
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
aduh95:flag-no-navigator

aduh95 commented Nov 5, 2023

Uh oh!

nodejs-github-bot commented Nov 5, 2023

Uh oh!

Uh oh!

mcollina left a comment

Uh oh!

nodejs-github-bot commented Nov 7, 2023

Uh oh!

anonrigNov 7, 2023

Uh oh!

aduh95Nov 7, 2023

Uh oh!

nodejs-github-bot commented Nov 7, 2023

Uh oh!

nodejs-github-bot commented Nov 8, 2023

Uh oh!

nodejs-github-bot commented Nov 8, 2023

Uh oh!

nodejs-github-bot commented Nov 8, 2023

Uh oh!

targos commented Nov 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

	AddOption("--experimental-global-customevent",
	"expose experimental CustomEvent on the global scope",
	&EnvironmentOptions::experimental_global_customevent,
	kAllowedInEnvvar,
	true);

Uh oh!

Uh oh!

Conversation

aduh95 commented Nov 5, 2023

Uh oh!

nodejs-github-bot commented Nov 5, 2023

Uh oh!

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Nov 7, 2023

Uh oh!

anonrigNov 7, 2023

Choose a reason for hiding this comment

Uh oh!

aduh95Nov 7, 2023

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Nov 7, 2023

Uh oh!

nodejs-github-bot commented Nov 8, 2023

Uh oh!

nodejs-github-bot commented Nov 8, 2023

Uh oh!

nodejs-github-bot commented Nov 8, 2023

Uh oh!

targos commented Nov 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants