Skip to content

fs: improve error performance for writeSync - #50354

Closed
pluris wants to merge 2 commits into
nodejs:mainfrom
pluris:feat/write_sync
Closed

fs: improve error performance for writeSync#50354
pluris wants to merge 2 commits into
nodejs:mainfrom
pluris:feat/write_sync

Conversation

@pluris

@plurispluris commented Oct 24, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

I worked on it because it seemed like there was still work left to do in nodejs/performance#106.

 confidence improvement accuracy (*) (**) (***)
fs/bench-writeSync.js n=100000 type='invalid'*** 116.41 % ±9.35% ±12.49% ±16.36%
fs/bench-writeSync.js n=100000 type='valid' 0.46 % ±6.13% ±8.16% ±10.62%
Be aware that when doing many comparisons the risk of a false-positive result increases.
In this case, there are 2 comparisons, you can thus expect the following amount of false-positive results:
0.10 false positives, when considering a 5% risk acceptance (*, **, ***),
0.02 false positives, when considering a 1% risk acceptance (**, ***),
0.00 false positives, when considering a 0.1% risk acceptance (***)

Refs: nodejs/performance#106

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. typings labels Oct 24, 2023
@anonriganonrig added request-ci Add this label to start a Jenkins CI on a PR. performance Issues and PRs related to the performance of Node.js. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Oct 24, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 24, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 24, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55187/

@anonrig

anonrig commented Oct 24, 2023

Copy link
Copy Markdown
Member

@pluris the tests are failing

@pluris

pluris commented Oct 24, 2023

Copy link
Copy Markdown
ContributorAuthor

@anonrig After rebasing and checking, there seems to be a problem. I will fix it and let you know. thank you

@pluris

pluris commented Oct 24, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Something is weird. It seems like a fail occurs in parallel.test-release-changelog.
It seems to be happening in other PR as well. (#50361)
Could it be related to the recent commit that changed the CHANGELOG file?

@richardlau

richardlau commented Oct 24, 2023

Copy link
Copy Markdown
Member

Something is weird. It seems like a fail occurs in parallel.test-release-changelog. It seems to be happening in other PR as well. (#50361) Could it be related to the recent commit that changed the CHANGELOG file?

#50373. Being fixed by #50375. Will need a fresh (not resumed) CI run to pick up the change when it lands on main.

@richardlaurichardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 24, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 24, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 24, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55210/

@github-actionsgithub-actionsBot mentioned this pull request Oct 25, 2023
Open
16 tasks
@H4adH4ad added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Oct 25, 2023
@anonriganonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 25, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 25, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 25, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55241/

This was referenced Oct 26, 2023
Open
Open
Open
Open
Open
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 5, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 5, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56109/

@pluris
plurisforce-pushed the feat/write_sync branch 4 times, most recently from 748fe57 to 8fb1d3eCompareDecember 5, 2023 22:57
@deokjinkimdeokjinkim added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 6, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 6, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 6, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56131/

@pluris
plurisforce-pushed the feat/write_sync branch 6 times, most recently from 2d09c90 to 918060cCompareDecember 6, 2023 16:25
@anonriganonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 6, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 6, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 6, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56137/

@deokjinkimdeokjinkim added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 9, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 9, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56174/

@nodejs-github-bot

nodejs-github-bot commented Dec 9, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56175/

@nodejs-github-bot

nodejs-github-bot commented Dec 25, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56521/

@nodejs-github-bot

nodejs-github-bot commented Dec 27, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56550/

@aduh95

aduh95 commented Dec 30, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1490/

@nodejs-github-bot

nodejs-github-bot commented Dec 30, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56597/

@PodaruDragos

PodaruDragos commented Apr 11, 2024

Copy link
Copy Markdown

hey guys, is there anything that's blocking this one out ?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fhinkelfhinkelfhinkel approved these changes
@anonriganonriganonrig approved these changes
@jasnelljasnellAwaiting requested review from jasnell

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.fsIssues and PRs related to the fs subsystem / file system.needs-ciPRs that need a full CI run.performanceIssues and PRs related to the performance of Node.js.typings

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@pluris@nodejs-github-bot@anonrig@richardlau@deokjinkim@aduh95@PodaruDragos@fhinkel@jasnell@lpinca@H4ad