Skip to content

src: fix node_version.h - #50375

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
joyeecheung:fix-version
Oct 24, 2023
Merged

src: fix node_version.h#50375
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
joyeecheung:fix-version

Conversation

@joyeecheung

@joyeecheungjoyeecheung commented Oct 24, 2023•
edited
Loading

Copy link
Copy Markdown
Member
  • Fix the version for main branch as 22.0.0
  • Fix the NODE_VERSION_IS_RELEASE flag for the main branch

This would allow test/parallel/test-release-changelog.js
to pass again on the main branch.

Fixes: #50373

@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 24, 2023
@joyeecheungjoyeecheung added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 24, 2023
@github-actions

github-actionsBot commented Oct 24, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @joyeecheung. Please 👍 to approve.

targos
targos requested changes Oct 24, 2023
View reviewed changes

@targostargos left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the version actually be 22.0.0?

@richardlau

richardlau commented Oct 24, 2023

Copy link
Copy Markdown
Member

Shouldn't the version actually be 22.0.0?

Yes, I think we're missing a step for semver major releases in the release process to bump the major version on main.

@targos

targos commented Oct 24, 2023

Copy link
Copy Markdown
Member

Yeah, there are two bugs introduced in the file during the release of v21.0.0:

  • major should be set to 22
  • is_release should be set to 0

image

@joyeecheung

joyeecheung commented Oct 24, 2023

Copy link
Copy Markdown
MemberAuthor

Something is wrong with the test, if I change it to 22.0.0:

❯ out/Release/node test/parallel/test-release-changelog.js
node:fs:453
return binding.readFileUtf8(path, stringToFlags(options.flag));
^
Error: ENOENT: no such file or directory, open '/Users/joyee/projects/node/doc/changelogs/CHANGELOG_V22.md'
at Object.readFileSync (node:fs:453:20)
at Object.<anonymous> (/Users/joyee/projects/node/test/parallel/test-release-changelog.js:42:24)
at Module._compile (node:internal/modules/cjs/loader:1376:14)
at Module._extensions..js (node:internal/modules/cjs/loader:1435:10)
at Module.load (node:internal/modules/cjs/loader:1207:32)
at Module._load (node:internal/modules/cjs/loader:1023:12)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:135:12)
at node:internal/main/run_main_module:28:49 {
errno: -2,
code: 'ENOENT',
syscall: 'open',
path: '/Users/joyee/projects/node/doc/changelogs/CHANGELOG_V22.md'
}

@targos

targos commented Oct 24, 2023

Copy link
Copy Markdown
Member

@joyeecheung you probably need to fix the IS_RELEASE macro at the same time. I think the bug slipped through because both mistakes happened.

@joyeecheung

joyeecheung commented Oct 24, 2023

Copy link
Copy Markdown
MemberAuthor

Maybe we should just skip the test when it's not run on a release?

@joyeecheung

joyeecheung commented Oct 24, 2023

Copy link
Copy Markdown
MemberAuthor

Oh, I see, it was supposed to skip, but NODE_VERSION_IS_RELEASE wasn't updated either.

@joyeecheung
src: fix node_version.h
c770105
- Fix the version for main branch as 22.0.0
- Fix the NODE_VERSION_IS_RELEASE flag for the main branch
This would allow test/parallel/test-release-changelog.js
to pass again on the main branch.
@richardlaurichardlau mentioned this pull request Oct 24, 2023
Closed
@joyeecheungjoyeecheung removed the fast-track PRs that do not need to wait for 48 hours to land. label Oct 24, 2023
@joyeecheungjoyeecheung added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 24, 2023
@github-actions

github-actionsBot commented Oct 24, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @joyeecheung. Please 👍 to approve.

@joyeecheungjoyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 24, 2023
@richardlaurichardlau changed the title src: fix NODE_MINOR_VERSION for v21.1.0src: fix node_version.hOct 24, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 24, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 24, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55203/

This was referenced Oct 24, 2023
Closed
Merged
@nodejs-github-bot

nodejs-github-bot commented Oct 24, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55207/

@richardlaurichardlau mentioned this pull request Oct 24, 2023
Closed
@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 24, 2023
@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 24, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 24, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 89a26b4 into nodejs:mainOct 24, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 24, 2023

Copy link
Copy Markdown
Collaborator

Landed in 89a26b4

@RafaelGSS

RafaelGSS commented Oct 25, 2023

Copy link
Copy Markdown
Member

Sorry about that. As I've mentioned in the release slack channel, something might be missing in our major release guide. I've followed these strictly and something went wrong. I'll triple-check next time :)

image

@github-actionsgithub-actionsBot mentioned this pull request Oct 28, 2023
Open
22 tasks
@RafaelGSSRafaelGSS mentioned this pull request Apr 15, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@targostargostargos approved these changes
@richardlaurichardlaurichardlau approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fast-trackPRs that do not need to wait for 48 hours to land.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test/parallel/test-release-changelog.js is failing on the main branch

7 participants

@joyeecheung@richardlau@targos@nodejs-github-bot@RafaelGSS@lpinca@aduh95