vm: allow dynamic import with a referrer realm by legendecas · Pull Request #50360 · nodejs/node

legendecas · 2023-10-24T08:57:44Z

A referrer can be a Script Record, a Cyclic Module Record, or a Realm
Record as defined in https://tc39.es/ecma262/#sec-HostLoadImportedModule.

Add support for dynamic import calls with a realm as the referrer and
allow specifying an importModuleDynamically callback in
vm.createContext.

Dynamic import with a realm as the referrer in a principal realm is not
supported in this PR.

Refs: #49726
Refs: #48655 (comment)

nodejs-github-bot · 2023-10-24T08:57:50Z

Review requested:

@nodejs/loaders
@nodejs/vm

A referrer can be a Script Record, a Cyclic Module Record, or a Realm Record as defined in https://tc39.es/ecma262/#sec-HostLoadImportedModule. Add support for dynamic import calls with a realm as the referrer and allow specifying an `importModuleDynamically` callback in `vm.createContext`.

joyeecheung

LGTM, thanks

nodejs-github-bot · 2023-10-31T10:55:31Z

CI: https://ci.nodejs.org/job/node-test-pull-request/55349/

nodejs-github-bot · 2023-10-31T13:08:36Z

CI: https://ci.nodejs.org/job/node-test-pull-request/55353/

nodejs-github-bot · 2023-10-31T17:48:23Z

CI: https://ci.nodejs.org/job/node-test-pull-request/55359/

nodejs-github-bot · 2023-11-01T03:12:28Z

CI: https://ci.nodejs.org/job/node-test-pull-request/55376/

nodejs-github-bot · 2023-11-01T06:05:15Z

Landed in 86afefa

A referrer can be a Script Record, a Cyclic Module Record, or a Realm Record as defined in https://tc39.es/ecma262/#sec-HostLoadImportedModule. Add support for dynamic import calls with a realm as the referrer and allow specifying an `importModuleDynamically` callback in `vm.createContext`. PR-URL: #50360 Refs: #49726 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

nodejs/node#50360

* chore: bump node in DEPS to v20.11.0 * module: bootstrap module loaders in shadow realm nodejs/node#48655 * src: add commit hash shorthand in zlib version nodejs/node#50158 * v8,tools: expose necessary V8 defines nodejs/node#50820 * esm: do not call getSource when format is commonjs nodejs/node#50465 * esm: fallback to readFileSync when source is nullish nodejs/node#50825 * vm: allow dynamic import with a referrer realm nodejs/node#50360 * test: skip test-diagnostics-channel-memory-leak.js nodejs/node#50327 * esm: do not call getSource when format is commonjs nodejs/node#50465 * lib: fix assert throwing different error messages in ESM and CJS nodejs/node#50634 * src: fix compatility with upcoming V8 12.1 APIs nodejs/node#50709 * deps: update base64 to 0.5.1 nodejs/node#50629 * src: avoid silent coercion to signed/unsigned int nodejs/node#50663 * src: fix compatility with upcoming V8 12.1 APIs nodejs/node#50709 * chore: fix patch indices * chore: update patches * test: disable TLS cipher test This can't be enabled owing to BoringSSL incompatibilities. nodejs/node#50186 * fix: check for Buffer and global definition in shadow realm nodejs/node#51239 * test: disable parallel/test-shadow-realm-custom-loader Incompatible with our asar logic, resulting in the following failure: > Failed to CompileAndCall electron script: electron/js2c/asar_bundle * chore: remove deleted parallel/test-crypto-modp1-error test * test: make test-node-output-v8-warning generic nodejs/node#50421 * chore: fixup ModuleWrap patch * test: match wpt/streams/transferable/transform-stream-members.any.js to upstream * fix: sandbox is not enabled on arm * chore: disable v8 sandbox on ia32/arm --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: Cheng Zhao <zcbenz@gmail.com>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Oct 24, 2023

legendecas force-pushed the vm/realm-import branch 3 times, most recently from eb2985c to ee58562Compare October 24, 2023 09:18

aduh95 reviewed Oct 24, 2023
View reviewed changes

Comment threadtest/parallel/test-vm-module-referrer-realm.js Outdated

aduh95 reviewed Oct 24, 2023
View reviewed changes

Comment threadtest/parallel/test-vm-module-referrer-realm.js Outdated

aduh95 reviewed Oct 24, 2023
View reviewed changes

Comment threadtest/parallel/test-vm-module-referrer-realm.js Outdated

aduh95 reviewed Oct 24, 2023
View reviewed changes

Comment threadtest/parallel/test-vm-module-referrer-realm.js Outdated

legendecas mentioned this pull request Oct 24, 2023
test: fix vm assertion actual and expected order #50371
Merged

legendecas force-pushed the vm/realm-import branch from 2a21901 to a05ed70Compare October 24, 2023 16:13

joyeecheung reviewed Oct 24, 2023
View reviewed changes

Comment threadsrc/node_contextify.cc Outdated

joyeecheung reviewed Oct 25, 2023
View reviewed changes

Comment threadsrc/module_wrap.cc Outdated
Comment threadsrc/node_contextify.cc Outdated

legendecas force-pushed the vm/realm-import branch from a05ed70 to f382139Compare October 25, 2023 14:14

fixup! vm: allow dynamic import with a referrer realm
5d6cada

joyeecheung approved these changes Oct 31, 2023
View reviewed changes

legendecas added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 31, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 31, 2023

aduh95 approved these changes Oct 31, 2023
View reviewed changes

aduh95 added experimental Issues and PRs related to experimental features. commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 31, 2023

github-actionsBot mentioned this pull request Nov 1, 2023
CI Reliability 2023-11-01 nodejs/reliability#704
Open
24 tasks

legendecas added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Nov 1, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 1, 2023

nodejs-github-bot merged commit 86afefa into nodejs:mainNov 1, 2023

legendecas deleted the vm/realm-import branch November 1, 2023 06:20

targos mentioned this pull request Nov 12, 2023
v21.2.0 release proposal #50681
Merged

UlisesGascon mentioned this pull request Dec 12, 2023
v20.11.0 proposal #51124
Merged

codebytere added a commit to electron/electron that referenced this pull request Jan 10, 2024
vm: allow dynamic import with a referrer realm
a9146ec
nodejs/node#50360

zcbenz pushed a commit to electron/electron that referenced this pull request Jan 12, 2024
vm: allow dynamic import with a referrer realm
fb5a54e
nodejs/node#50360

zcbenz pushed a commit to electron/electron that referenced this pull request Jan 12, 2024
vm: allow dynamic import with a referrer realm
629bae2
nodejs/node#50360

codebytere added a commit to electron/electron that referenced this pull request Jan 15, 2024
vm: allow dynamic import with a referrer realm
29cbef8
nodejs/node#50360

codebytere added a commit to electron/electron that referenced this pull request Jan 15, 2024
vm: allow dynamic import with a referrer realm
6b5acd5
nodejs/node#50360

codebytere added a commit to electron/electron that referenced this pull request Jan 16, 2024
vm: allow dynamic import with a referrer realm
4b83672
nodejs/node#50360

codebytere added a commit to electron/electron that referenced this pull request Jan 18, 2024
vm: allow dynamic import with a referrer realm
48124c4
nodejs/node#50360

jkleinsc pushed a commit to electron/electron that referenced this pull request Jan 18, 2024
vm: allow dynamic import with a referrer realm
33a9cf6
nodejs/node#50360

codebytere added a commit to electron/electron that referenced this pull request Jan 18, 2024
vm: allow dynamic import with a referrer realm
cc66ea6
nodejs/node#50360

Navigation Menu

Uh oh!

Uh oh!

vm: allow dynamic import with a referrer realm - #50360

vm: allow dynamic import with a referrer realm#50360
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
legendecas:vm/realm-import

legendecas commented Oct 24, 2023

Uh oh!

nodejs-github-bot commented Oct 24, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joyeecheung left a comment

Uh oh!

nodejs-github-bot commented Oct 31, 2023

Uh oh!

nodejs-github-bot commented Oct 31, 2023

Uh oh!

nodejs-github-bot commented Oct 31, 2023

Uh oh!

nodejs-github-bot commented Nov 1, 2023

Uh oh!

nodejs-github-bot commented Nov 1, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Uh oh!

Conversation

legendecas commented Oct 24, 2023

Uh oh!

nodejs-github-bot commented Oct 24, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joyeecheung left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Oct 31, 2023

Uh oh!

nodejs-github-bot commented Oct 31, 2023

Uh oh!

nodejs-github-bot commented Oct 31, 2023

Uh oh!

nodejs-github-bot commented Nov 1, 2023

Uh oh!

nodejs-github-bot commented Nov 1, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants