esm: fallback to `readFileSync` when `source` is nullish by aduh95 · Pull Request #50825 · nodejs/node

aduh95 · 2023-11-20T16:35:33Z

When using the Modules Customization Hooks API to load CommonJS modules, we want to support the returned value of defaultLoad which must be nullish to preserve backward compatibility. This can be achieved by fetching the source from the translator.

Fixes: #50435

nodejs-github-bot · 2023-11-20T16:35:38Z

Review requested:

@nodejs/loaders

When using the Modules Customization Hooks API to load CommonJS modules, we want to support the returned value of `defaultLoad` which must be nullish to preserve backward compatibility. This can be achieved by fetching the source from the translator.

GeoffreyBooth

I think this avoids the source being read from disk twice?

aduh95 · 2023-11-20T18:58:24Z

I think this avoids the source being read from disk twice?

Nope, this is a different issue. It only avoids the source being read 0 times from disk 😅

nodejs-github-bot · 2023-11-20T19:01:05Z

CI: https://ci.nodejs.org/job/node-test-pull-request/55794/

targos · 2023-11-21T14:28:49Z

Small CITGM run to see if nodejs/citgm#1029 is fixed: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3347/

Edit: result will be in https://ci.nodejs.org/job/citgm-smoker/nodes=fedora-latest-x64/3347/

merceyz · 2023-11-21T20:01:46Z

Edit: result will be in https://ci.nodejs.org/job/citgm-smoker/nodes=fedora-latest-x64/3347/

@targos could you run another CITGM test with nodejs/citgm#1022 included?
nodejs/citgm#1022 enables testing the Yarn ESM loader which might be affected by this change.

nodejs-github-bot · 2023-11-23T18:21:33Z

CI: https://ci.nodejs.org/job/node-test-pull-request/55882/

nodejs-github-bot · 2023-11-25T19:03:06Z

CI: https://ci.nodejs.org/job/node-test-pull-request/55919/

JakobJingleheimer

🙌

nodejs-github-bot · 2023-11-27T22:07:43Z

CI: https://ci.nodejs.org/job/node-test-pull-request/55961/

nodejs-github-bot · 2023-11-28T13:50:09Z

CI: https://ci.nodejs.org/job/node-test-pull-request/55976/

nodejs-github-bot · 2023-11-28T22:34:06Z

CI: https://ci.nodejs.org/job/node-test-pull-request/55986/

aduh95 · 2023-11-29T09:12:19Z

Landed in 4eafcf8

When using the Modules Customization Hooks API to load CommonJS modules, we want to support the returned value of `defaultLoad` which must be nullish to preserve backward compatibility. This can be achieved by fetching the source from the translator. PR-URL: #50825Fixes: #50435 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Jacob Smith <jacob@frende.me>

lizthegrey · 2023-12-08T00:16:28Z

Can we get this tagged as to backport to 20.x release series? Thanks.

When using the Modules Customization Hooks API to load CommonJS modules, we want to support the returned value of `defaultLoad` which must be nullish to preserve backward compatibility. This can be achieved by fetching the source from the translator. PR-URL: #50825Fixes: #50435 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Jacob Smith <jacob@frende.me>

lizthegrey · 2023-12-14T07:00:02Z

Thanks for the backport.

When using the Modules Customization Hooks API to load CommonJS modules, we want to support the returned value of `defaultLoad` which must be nullish to preserve backward compatibility. This can be achieved by fetching the source from the translator. PR-URL: #50825Fixes: #50435 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Jacob Smith <jacob@frende.me>

nodejs/node#50825

* chore: bump node in DEPS to v20.11.0 * module: bootstrap module loaders in shadow realm nodejs/node#48655 * src: add commit hash shorthand in zlib version nodejs/node#50158 * v8,tools: expose necessary V8 defines nodejs/node#50820 * esm: do not call getSource when format is commonjs nodejs/node#50465 * esm: fallback to readFileSync when source is nullish nodejs/node#50825 * vm: allow dynamic import with a referrer realm nodejs/node#50360 * test: skip test-diagnostics-channel-memory-leak.js nodejs/node#50327 * esm: do not call getSource when format is commonjs nodejs/node#50465 * lib: fix assert throwing different error messages in ESM and CJS nodejs/node#50634 * src: fix compatility with upcoming V8 12.1 APIs nodejs/node#50709 * deps: update base64 to 0.5.1 nodejs/node#50629 * src: avoid silent coercion to signed/unsigned int nodejs/node#50663 * src: fix compatility with upcoming V8 12.1 APIs nodejs/node#50709 * chore: fix patch indices * chore: update patches * test: disable TLS cipher test This can't be enabled owing to BoringSSL incompatibilities. nodejs/node#50186 * fix: check for Buffer and global definition in shadow realm nodejs/node#51239 * test: disable parallel/test-shadow-realm-custom-loader Incompatible with our asar logic, resulting in the following failure: > Failed to CompileAndCall electron script: electron/js2c/asar_bundle * chore: remove deleted parallel/test-crypto-modp1-error test * test: make test-node-output-v8-warning generic nodejs/node#50421 * chore: fixup ModuleWrap patch * test: match wpt/streams/transferable/transform-stream-members.any.js to upstream * fix: sandbox is not enabled on arm * chore: disable v8 sandbox on ia32/arm --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: Cheng Zhao <zcbenz@gmail.com>

nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Nov 20, 2023

aduh95 force-pushed the cjs-nullish-source branch from 594830d to e1f1a80Compare November 20, 2023 16:48

GeoffreyBooth approved these changes Nov 20, 2023
View reviewed changes

aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 20, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 20, 2023

aduh95 mentioned this pull request Nov 21, 2023
esmocha broken by ESM hook changes? nodejs/citgm#1029
Closed

anonrig reviewed Nov 21, 2023
View reviewed changes

Comment threadlib/internal/modules/esm/translators.js

anonrig reviewed Nov 21, 2023
View reviewed changes

Comment threadlib/internal/modules/esm/translators.js Outdated

fixup! esm: fallback to getSource when load returns nullish source
11c610a

aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 23, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 23, 2023

aduh95 commented Nov 25, 2023
View reviewed changes

Comment threadtest/es-module/test-esm-loader-hooks.mjs Outdated

aduh95 commented Nov 25, 2023
View reviewed changes

Comment threadtest/es-module/test-esm-loader-hooks.mjs Outdated

Apply suggestions from code review
b58772c

JakobJingleheimer approved these changes Nov 27, 2023
View reviewed changes

remove weird condition
a359b02

fixup! remove weird condition
3cde424

aduh95 merged commit 4eafcf8 into nodejs:mainNov 29, 2023

aduh95 deleted the cjs-nullish-source branch November 29, 2023 09:12

RafaelGSS mentioned this pull request Nov 29, 2023
v21.3.0 proposal #50954
Merged

UlisesGascon mentioned this pull request Dec 12, 2023
v20.11.0 proposal #51124
Merged

aduh95 added the lts-watch-v18.x label Dec 24, 2023

codebytere added a commit to electron/electron that referenced this pull request Jan 10, 2024
esm: fallback to readFileSync when source is nullish
d21d3d0
nodejs/node#50825

zcbenz pushed a commit to electron/electron that referenced this pull request Jan 12, 2024
esm: fallback to readFileSync when source is nullish
acb8b30
nodejs/node#50825

zcbenz pushed a commit to electron/electron that referenced this pull request Jan 12, 2024
esm: fallback to readFileSync when source is nullish
3b334f8
nodejs/node#50825

codebytere added a commit to electron/electron that referenced this pull request Jan 15, 2024
esm: fallback to readFileSync when source is nullish
38c94c5
nodejs/node#50825

codebytere added a commit to electron/electron that referenced this pull request Jan 15, 2024
esm: fallback to readFileSync when source is nullish
7928388
nodejs/node#50825

codebytere added a commit to electron/electron that referenced this pull request Jan 16, 2024
esm: fallback to readFileSync when source is nullish
0c5dbcb
nodejs/node#50825

codebytere added a commit to electron/electron that referenced this pull request Jan 18, 2024
esm: fallback to readFileSync when source is nullish
67152ba
nodejs/node#50825

jkleinsc pushed a commit to electron/electron that referenced this pull request Jan 18, 2024
esm: fallback to readFileSync when source is nullish
1f2d223
nodejs/node#50825

codebytere added a commit to electron/electron that referenced this pull request Jan 18, 2024
esm: fallback to readFileSync when source is nullish
e604a2d
nodejs/node#50825

aduh95 removed the lts-watch-v18.x label Nov 2, 2024

Uh oh!

Uh oh!

Conversation

aduh95 commented Nov 20, 2023

Uh oh!

nodejs-github-bot commented Nov 20, 2023

Uh oh!

GeoffreyBooth left a comment

Choose a reason for hiding this comment

Uh oh!

aduh95 commented Nov 20, 2023

Uh oh!

nodejs-github-bot commented Nov 20, 2023

Uh oh!

targos commented Nov 21, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

merceyz commented Nov 21, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Nov 23, 2023

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Nov 25, 2023

Uh oh!

JakobJingleheimer left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Nov 27, 2023

Uh oh!

nodejs-github-bot commented Nov 28, 2023

Uh oh!

nodejs-github-bot commented Nov 28, 2023

Uh oh!

aduh95 commented Nov 29, 2023

Uh oh!

lizthegrey commented Dec 8, 2023

Uh oh!

lizthegrey commented Dec 14, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

targos commented Nov 21, 2023•
edited
Loading

merceyz commented Nov 21, 2023•
edited
Loading