Skip to content

src: revert IS_RELEASE to 0 - #50378

Closed
rluvaton wants to merge 1 commit into
nodejs:mainfrom
rluvaton:fix-test-release-test
Closed

src: revert IS_RELEASE to 0#50378
rluvaton wants to merge 1 commit into
nodejs:mainfrom
rluvaton:fix-test-release-test

Conversation

@rluvaton

Copy link
Copy Markdown
Member

the test-release-changelog.js test failed and I believe we should revert the is release back to 0

@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 24, 2023
@rluvaton
rluvaton requested a review from targosOctober 24, 2023 22:34
@rluvatonrluvaton added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 24, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 24, 2023
@richardlau

Copy link
Copy Markdown
Member

Being fixed in #50375.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@richardlaurichardlau added needs-ci PRs that need a full CI run. and removed needs-ci PRs that need a full CI run. labels Oct 24, 2023
@rluvaton

Copy link
Copy Markdown
MemberAuthor

Thanks

@rluvaton
rluvaton deleted the fix-test-release-test branch October 24, 2023 22:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ciPRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@rluvaton@richardlau@nodejs-github-bot