Skip to content

doc: Crypto.markdown 'RSA-SHA256' should be uppercase - #5044

Closed
raineroviir wants to merge 3 commits into
nodejs:masterfrom
raineroviir:patch-1
Closed

doc: Crypto.markdown 'RSA-SHA256' should be uppercase#5044
raineroviir wants to merge 3 commits into
nodejs:masterfrom
raineroviir:patch-1

Conversation

@raineroviir

Copy link
Copy Markdown
Contributor

doc: Crypto.markdown 'RSA-SHA256' should be uppercase

The RSA-SHA256 string should be uppercase
@r-52r-52 added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. lts-watch-v4.x labels Feb 2, 2016
@mscdex

Copy link
Copy Markdown
Contributor

LGTM

1 similar comment
@jasnell

Copy link
Copy Markdown
Member

LGTM

@bnoordhuis

Copy link
Copy Markdown
Member

LGTM but the commit log should follow the style guide from CONTRIBUTING.md.

@cjihrig

Copy link
Copy Markdown
Contributor

LGTM

@raineroviirraineroviir changed the title Update crypto.markdowncrypto, doc: Crypto.markdown 'RSA-SHA256' should be uppercaseFeb 2, 2016
@raineroviirraineroviir changed the title crypto, doc: Crypto.markdown 'RSA-SHA256' should be uppercasedoc: Crypto.markdown 'RSA-SHA256' should be uppercaseFeb 2, 2016
@stevemao

Copy link
Copy Markdown
Contributor

@raineroviir you need to change the commit message and force push to your branch.

@raineroviir

Copy link
Copy Markdown
ContributorAuthor

@stevemao I was able to amend the commit message and create a detached head but when I try to force push to my branch it says nothing was changed

@stevemao

Copy link
Copy Markdown
Contributor

Don't checkout the previous commit.
The easiest way to do this is git commit --amend fix the commit message then git push -f

@raineroviirhttps://help.github.com/articles/changing-a-commit-message/

doc: Crypto.markdown 'RSA-SHA256' should be uppercase
doc: Crypto.markdown 'RSA-SHA256' should be uppercase
@raineroviir

Copy link
Copy Markdown
ContributorAuthor

@stevemao thanks! decc2e1 commit message hasn't changed but I believe I made the changes

@stevemao

Copy link
Copy Markdown
Contributor

Well, I guess you probably need to squash now... But I think someone can do it on merge so don't worry!

bnoordhuis pushed a commit that referenced this pull request Feb 3, 2016
Fixes: #5031
PR-URL: #5044
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@bnoordhuis

Copy link
Copy Markdown
Member

@raineroviir Here is what I would do:

  1. git reflog and find the hash of your original commit.
  2. git reset --hard <commit>
  3. git commit --amend
  4. git push your-remote +HEAD:patch-1

I landed your patch with a slightly amended commit log (< 50 characters) in commit 977159f. Thanks!

@raineroviir

Copy link
Copy Markdown
ContributorAuthor

Thank you!

rvagg pushed a commit that referenced this pull request Feb 8, 2016
Fixes: #5031
PR-URL: #5044
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 22, 2016
Fixes: #5031
PR-URL: #5044
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 22, 2016
Fixes: #5031
PR-URL: #5044
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
Fixes: #5031
PR-URL: #5044
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
Fixes: nodejs#5031
PR-URL: nodejs#5044
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cryptoIssues and PRs related to the crypto subsystem.docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@raineroviir@mscdex@jasnell@bnoordhuis@cjihrig@stevemao@MylesBorins@r-52