Uh oh!
There was an error while loading. Please reload this page.
doc: Crypto.markdown 'RSA-SHA256' should be uppercase - #5044
Conversation
The RSA-SHA256 string should be uppercase
mscdex
commented
Feb 2, 2016
LGTM |
1 similar comment
jasnell
commented
Feb 2, 2016
LGTM |
bnoordhuis
commented
Feb 2, 2016
LGTM but the commit log should follow the style guide from CONTRIBUTING.md. |
cjihrig
commented
Feb 2, 2016
LGTM |
stevemao
commented
Feb 2, 2016
@raineroviir you need to change the commit message and force push to your branch. |
raineroviir
commented
Feb 2, 2016
@stevemao I was able to amend the commit message and create a detached head but when I try to force push to my branch it says nothing was changed |
stevemao
commented
Feb 2, 2016
Don't checkout the previous commit. @raineroviirhttps://help.github.com/articles/changing-a-commit-message/ |
doc: Crypto.markdown 'RSA-SHA256' should be uppercase
doc: Crypto.markdown 'RSA-SHA256' should be uppercase
raineroviir
commented
Feb 3, 2016
stevemao
commented
Feb 3, 2016
Well, I guess you probably need to squash now... But I think someone can do it on merge so don't worry! |
bnoordhuis
commented
Feb 3, 2016
@raineroviir Here is what I would do:
I landed your patch with a slightly amended commit log (< 50 characters) in commit 977159f. Thanks! |
raineroviir
commented
Feb 3, 2016
Thank you! |
Fixes: nodejs#5031 PR-URL: nodejs#5044 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
doc: Crypto.markdown 'RSA-SHA256' should be uppercase