Skip to content

test: replace forEach with for-of in test-webcrypto-export-import-ec - #50793

Closed
cricciardi wants to merge 1 commit into
nodejs:mainfrom
cricciardi:main
Closed

test: replace forEach with for-of in test-webcrypto-export-import-ec#50793
cricciardi wants to merge 1 commit into
nodejs:mainfrom
cricciardi:main

Conversation

@cricciardi

@cricciardicricciardi commented Nov 18, 2023

Copy link
Copy Markdown
Contributor

test: replace forEach with for-of in test-webcrypto-export-import-ec

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 18, 2023
jasnell
jasnell reviewed Nov 19, 2023
View reviewed changes
Comment threadtest/parallel/test-webcrypto-export-import-ec.js Outdated
jasnell
jasnell reviewed Nov 19, 2023
View reviewed changes
Comment threadtest/parallel/test-webcrypto-export-import-ec.js Outdated
jasnell
jasnell reviewed Nov 19, 2023
View reviewed changes
Comment threadtest/parallel/test-webcrypto-export-import-ec.js Outdated
jasnell
jasnell approved these changes Nov 19, 2023
View reviewed changes

@jasnelljasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a new linting nits

@panvapanva added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 20, 2023
@lpincalpinca added request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Nov 22, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 22, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 22, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55860/

@RafaelGSSRafaelGSS added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 24, 2023
RafaelGSS
RafaelGSS reviewed Nov 24, 2023
View reviewed changes

@RafaelGSSRafaelGSS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cricciardi apparently, your commit don't include email and username. Can you --resetAuthor after configuring your git? (git config user.name ...)

@cricciardi

cricciardi commented Nov 24, 2023

Copy link
Copy Markdown
ContributorAuthor

@RafaelGSS I updated my commit with username and password

@RafaelGSSRafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 27, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 27, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 27, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55954/

@nodejs-github-bot

nodejs-github-bot commented Dec 10, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56200/

@nodejs-github-bot

nodejs-github-bot commented Dec 15, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56307/

@RafaelGSS

RafaelGSS commented Dec 15, 2023

Copy link
Copy Markdown
Member

@cricciardi If you see the commit list you will notice the first commit doesn't belong to your github account, can you fix it, please? Basically, just squash all the commits into one and make sure to run git commit --amend --resetAuthor

@cricciardi

cricciardi commented Dec 20, 2023

Copy link
Copy Markdown
ContributorAuthor

Hi @RafaelGSS,
I try to squash commits and set author with this commands:

git rebase --interactive HEAD~20 (set squash on my commit, pick in other commits, and edit on my first commit)
git commit --amend --author="Chiara Ricciardi <chiara.ricciardi66.cr@gmail.com>" (this command for set author)

But it seems not works. Can you tell me what I do wrong?

@RafaelGSS

RafaelGSS commented Dec 21, 2023

Copy link
Copy Markdown
Member

Hi @RafaelGSS, I try to squash commits and set author with this commands:

git rebase --interactive HEAD~20 (set squash on my commit, pick in other commits, and edit on my first commit)
git commit --amend --author="Chiara Ricciardi <chiara.ricciardi66.cr@gmail.com>" (this command for set author)

But it seems not works. Can you tell me what I do wrong?

You need to set squash in all other commits but the first commit

@marco-ippolito

marco-ippolito commented Dec 21, 2023

Copy link
Copy Markdown
Member

User @cricciardi reached out and asked me to fix the commit

@nodejs-github-bot@cricciardi
deps: update simdutf to 4.0.4
23ea6c8
PR-URL: nodejs#50772
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@cricciardi

cricciardi commented Dec 21, 2023

Copy link
Copy Markdown
ContributorAuthor

Hi @marco-ippolito and @RafaelGSS, I open a new PR #51249

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RafaelGSSRafaelGSSRafaelGSS left review comments
@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes

Assignees

No one assigned

Labels

code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@cricciardi@nodejs-github-bot@RafaelGSS@marco-ippolito@jasnell@lpinca@panva