Skip to content

test: replace forEach with for-of in test-webcrypto-export-import-ec - #51249

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
cricciardi:squash-commit-test
Dec 22, 2023
Merged

test: replace forEach with for-of in test-webcrypto-export-import-ec#51249
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
cricciardi:squash-commit-test

Conversation

@cricciardi

@cricciardicricciardi commented Dec 21, 2023

Copy link
Copy Markdown
Contributor

test: replace forEach with for-of in test-webcrypto-export-import-ec

@marco-ippolito

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Dec 21, 2023
@cricciardicricciardi mentioned this pull request Dec 21, 2023
Closed
@marco-ippolitomarco-ippolito added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 21, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 21, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 21, 2023•
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56444/ 💛

@lpincalpinca added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 21, 2023
@github-actions

github-actionsBot commented Dec 21, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @lpinca. Please 👍 to approve.

@jasnelljasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 22, 2023
@lpincalpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 22, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 22, 2023
@nodejs-github-bot
nodejs-github-bot merged commit ba957a6 into nodejs:mainDec 22, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 22, 2023

Copy link
Copy Markdown
Collaborator

Landed in ba957a6

RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
@cricciardi@RafaelGSS
test: replace forEach with for-of in test-webcrypto-export-import-ec
57c6455
PR-URL: #51249
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Jan 2, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@cricciardi@richardlau
test: replace forEach with for-of in test-webcrypto-export-import-ec
9cedaa6
PR-URL: #51249
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@richardlaurichardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@RafaelGSSRafaelGSSRafaelGSS approved these changes
@marco-ippolitomarco-ippolitomarco-ippolito approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.fast-trackPRs that do not need to wait for 48 hours to land.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@cricciardi@nodejs-github-bot@jasnell@lpinca@RafaelGSS@marco-ippolito