Skip to content

deps: update ngtcp2 and nghttp3, update quic impls - #51291

Closed
jasnell wants to merge 2 commits into
nodejs:mainfrom
jasnell:quic-part-9
Closed

deps: update ngtcp2 and nghttp3, update quic impls#51291
jasnell wants to merge 2 commits into
nodejs:mainfrom
jasnell:quic-part-9

Conversation

@jasnell

@jasnelljasnell commented Dec 26, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Updates the ngtcp2 and nghttp3 dependencies and various bits of code that rely on it.

@nodejs-github-bot

nodejs-github-bot commented Dec 26, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Dec 26, 2023
@jasnell
jasnell marked this pull request as ready for review December 27, 2023 00:53
@jasnell
jasnell requested a review from QardDecember 27, 2023 00:56
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@anonrig

anonrig commented Dec 27, 2023

Copy link
Copy Markdown
Member

I'll review this tomorrow 👍

gengjiawen
gengjiawen reviewed Dec 27, 2023
View reviewed changes
Comment threaddeps/ngtcp2/ngtcp2.gyp Outdated
This was referenced Dec 27, 2023
Closed
Closed
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
anonrig
anonrig reviewed Dec 27, 2023
View reviewed changes
Comment threadsrc/quic/session.cc Outdated
Comment threadsrc/quic/session.cc Outdated
Comment threadsrc/quic/session.cc Outdated
Comment threadsrc/quic/session.cc Outdated
Comment threadsrc/quic/session.cc Outdated
Comment threadsrc/quic/session.cc Outdated
Comment threadsrc/quic/session.h Outdated
Comment threadsrc/quic/tlscontext.cc Outdated
Comment threadsrc/quic/tlscontext.h Outdated
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Dec 27, 2023•
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56565/ 💚

@jasnelljasnell added lib / src Issues and PRs related to general changes in the lib or src directory. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. dependencies Pull requests that update a dependency file. commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Dec 27, 2023
@nodejs-github-botnodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 28, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 28, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/51291
✔ Done loading data for nodejs/node/pull/51291
----------------------------------- PR info ------------------------------------
Title deps: update ngtcp2 and nghttp3, update quic impls (#51291)
Author James M Snell (@jasnell)
Branch jasnell:quic-part-9 -> nodejs:main
Labels lib / src, author ready, needs-ci, quic, dependencies
Commits 2
- deps: update ngtcp2 and nghttp3
- quic: update quic impl to use latest ngtcp2/nghttp3
Committers 1
- James M Snell PR-URL: https://github.com/nodejs/node/pull/51291
Reviewed-By: Stephen Belanger ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/51291
Reviewed-By: Stephen Belanger --------------------------------------------------------------------------------
⚠ Commits were pushed since the last approving review:
⚠ - deps: update ngtcp2 and nghttp3
⚠ - quic: update quic impl to use latest ngtcp2/nghttp3
ℹ This PR was created on Tue, 26 Dec 2023 23:30:04 GMT
✔ Approvals: 1
✔ - Stephen Belanger (@Qard): https://github.com/nodejs/node/pull/51291#pullrequestreview-1796691870
✘ This PR needs to wait 119 more hours to land (or 0 hours if there is one more approval)
✘ Last GitHub CI failed
ℹ Last Full PR CI on 2023-12-27T19:28:53Z: https://ci.nodejs.org/job/node-test-pull-request/56565/
- Querying data for job/node-test-pull-request/56565/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/7352086887

@gengjiawengengjiawen added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Dec 29, 2023
@nodejs-github-botnodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 29, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 29, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/51291
✔ Done loading data for nodejs/node/pull/51291
----------------------------------- PR info ------------------------------------
Title deps: update ngtcp2 and nghttp3, update quic impls (#51291)
Author James M Snell (@jasnell)
Branch jasnell:quic-part-9 -> nodejs:main
Labels lib / src, author ready, needs-ci, quic, dependencies
Commits 2
- deps: update ngtcp2 and nghttp3
- quic: update quic impl to use latest ngtcp2/nghttp3
Committers 1
- James M Snell PR-URL: https://github.com/nodejs/node/pull/51291
Reviewed-By: Stephen Belanger Reviewed-By: Jiawen Geng ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/51291
Reviewed-By: Stephen Belanger Reviewed-By: Jiawen Geng --------------------------------------------------------------------------------
ℹ This PR was created on Tue, 26 Dec 2023 23:30:04 GMT
✔ Approvals: 2
✔ - Stephen Belanger (@Qard): https://github.com/nodejs/node/pull/51291#pullrequestreview-1796691870
✔ - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/51291#pullrequestreview-1798809500
✘ Last GitHub CI failed
ℹ Last Full PR CI on 2023-12-28T23:37:07Z: https://ci.nodejs.org/job/node-test-pull-request/56565/
- Querying data for job/node-test-pull-request/56565/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/7355913366

@jasnell

jasnell commented Dec 29, 2023

Copy link
Copy Markdown
MemberAuthor

Landed in 07f3df4...0bf1548

jasnell added a commit that referenced this pull request Dec 29, 2023
@jasnell
deps: update ngtcp2 and nghttp3
86ca72a
PR-URL: #51291
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
jasnell added a commit that referenced this pull request Dec 29, 2023
@jasnell
quic: update quic impl to use latest ngtcp2/nghttp3
0bf1548
PR-URL: #51291
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@jasnelljasnell closed this Dec 29, 2023
@zcbenzzcbenz mentioned this pull request Dec 30, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
@jasnell@RafaelGSS
deps: update ngtcp2 and nghttp3
e53cbb2
PR-URL: #51291
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
@jasnell@RafaelGSS
quic: update quic impl to use latest ngtcp2/nghttp3
7ecf994
PR-URL: #51291
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Jan 2, 2024
Merged
@targostargos mentioned this pull request Jan 30, 2024
Closed
richardlau pushed a commit that referenced this pull request May 10, 2024
@jasnell@richardlau
deps: update ngtcp2 and nghttp3
28c0c78
PR-URL: #51291
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@richardlaurichardlau mentioned this pull request May 16, 2024
Merged
@targostargos mentioned this pull request May 23, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonriganonriganonrig left review comments
@QardQardQard approved these changes
@gengjiawengengjiawengengjiawen approved these changes
@targostargosAwaiting requested review from targos
@tniessentniessenAwaiting requested review from tniessen

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-failedAn error occurred while landing this pull request using GitHub Actions.dependenciesPull requests that update a dependency file.lib / srcIssues and PRs related to general changes in the lib or src directory.needs-ciPRs that need a full CI run.quicIssues and PRs related to the QUIC implementation / HTTP/3.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jasnell@nodejs-github-bot@anonrig@Qard@gengjiawen@richardlau