Uh oh!
There was an error while loading. Please reload this page.
build: update GN build files for ngtcp2 - #51313
Merged
Merged
Conversation
lpinca
approved these changes
Dec 31, 2023
nodejs-github-bot
commented
Dec 31, 2023
Collaborator
nodejs-github-bot
commented
Dec 31, 2023
Collaborator
nodejs-github-bot
commented
Jan 2, 2024
Collaborator
zcbenz
commented
Jan 3, 2024
ContributorAuthor
An early merge would be appreciated so we can bring CI of GN build to green to continue monitoring the health of GN build . |
nodejs-github-bot
commented
Jan 3, 2024
Collaborator
jasnell
approved these changes
Jan 3, 2024
gengjiawen
approved these changes
Jan 5, 2024
nodejs-github-bot
commented
Jan 5, 2024
Collaborator
Landed in 68c8472 |
27 tasks
marco-ippolito pushed a commit
to marco-ippolito/node
that referenced
this pull request
Jan 12, 2024
PR-URL: nodejs#51313 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Medhansh404 pushed a commit
to Medhansh404/node
that referenced
this pull request
Jan 19, 2024
PR-URL: nodejs#51313 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
targos pushed a commit
that referenced
this pull request
Feb 15, 2024
PR-URL: #51313 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Merged
richardlau pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #51313 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A followup to #51291 for the GN side changes.