Uh oh!
There was an error while loading. Please reload this page.
src: remove comments from env file - #52120
Closed
IlyasShabi wants to merge 1 commit into
Closed
Conversation
IlyasShabiforce-pushed
the
dotenv-remove-comments
branch
from
March 16, 2024 23:28
4d101fc to
1f40a6eCompareMoLow
reviewed
Mar 17, 2024
Uh oh!
There was an error while loading. Please reload this page.
IlyasShabiforce-pushed
the
dotenv-remove-comments
branch
from
March 17, 2024 15:40
1f40a6e to
d3d4f4aCompareIlyasShabi
commented
Mar 20, 2024
MemberAuthor
Could you please review this PR @lemire@anonrig@RafaelGSS@MoLow ? |
anonrig
reviewed
Mar 21, 2024
Uh oh!
There was an error while loading. Please reload this page.
IlyasShabiforce-pushed
the
dotenv-remove-comments
branch
2 times, most recently
from
March 22, 2024 20:05
0c013f6 to
2362451CompareIlyasShabiforce-pushed
the
dotenv-remove-comments
branch
from
March 25, 2024 10:22
2362451 to
be59832Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing this issue
The regex wasn't dealing with multiple comment lines properly. I added a function to remove all comments first, then apply the regex to the cleaned-up content.