src: remove regex usage for env file parsing

[IlyasShabi]

This PR aims to remove regex usage for env file parsing, this will close:

• Loading long env value from a file is crashing Node on Windows #52248
• --env-file parser overrides variables with commented out values #52084
• Comment lines which are environment variable assignments in .env file are not ignored when using --env-file #52466
• src: node crashes due to multiline environment value #52266
• src: fix dotenv parsing commented env #52363
• src: remove comments from env file #52120

[climba03003]

Can you add multiple continues comments in valid.env to ensure it works?

[IlyasShabi]

Can you add multiple continues comments in valid.env to ensure it works?

@climba03003 Could you provide me with an example and the expected result?

[climba03003]

// .valid.env
#COMMENTED_ENV=shouldnotshown
#COMMENTED_ENV_FOLLOW_COMMENTED_ENV=shouldnotshown
#COMMENTED_ENV_FOLLOW_COMMENTED_ENV_2=shouldnotshown// test// Commented environment should be undefinedassert.strictEqual(process.env.COMMENTED_ENV,undefined);assert.strictEqual(process.env.COMMENTED_ENV_FOLLOW_COMMENTED_ENV,undefined);assert.strictEqual(process.env.COMMENTED_ENV_FOLLOW_COMMENTED_ENV_2,undefined);

[VoltrexKeyva]

You should use the snake_case naming convention for local variables and parameters as stated here in the C++ style guide.

[anonrig]

Small changes but overall I think this is ready to land. Thank you.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/58291/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/58299/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/58301/

[IlyasShabi]

Flaky tests

[targos]

No. Some dotenv tests are broken on Windows.

See https://ci.nodejs.org/job/node-test-binary-windows-js-suites/27085/RUN_SUBSET=1,nodes=win2016-COMPILED_BY-vs2022-x86/console

(Search for "not ok" in the output)

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/52406
✔ Done loading data for nodejs/node/pull/52406
----------------------------------- PR info ------------------------------------
Title src: remove regex usage for env file parsing (#52406)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch IlyasShabi:dotenv-refacto -> nodejs:main
Labels c++, author ready, needs-ci, commit-queue-squash
Commits 2
- src: remove regex usage for env file parsing
- src: handle empty value without newline at EOF
Committers 1
- Ilyas Shabi PR-URL: https://github.com/nodejs/node/pull/52406
Fixes: https://github.com/nodejs/node/issues/52248
Reviewed-By: Yagiz Nizipli ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/52406
Fixes: https://github.com/nodejs/node/issues/52248
Reviewed-By: Yagiz Nizipli --------------------------------------------------------------------------------
⚠ Commits were pushed since the last approving review:
⚠ - src: handle empty value without newline at EOF
ℹ This PR was created on Sun, 07 Apr 2024 15:34:18 GMT
✔ Approvals: 1
✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/52406#pullrequestreview-1995581300
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2024-04-16T01:40:19Z: https://ci.nodejs.org/job/node-test-pull-request/58417/
- Querying data for job/node-test-pull-request/58417/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/8699372234

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/58425/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/58431/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/58448/

[nodejs-github-bot]

Landed in 3f88e14

[kibertoad]

@IlyasShabi thank you so much! do you plan to backport to 20.x too?

[kibertoad]

@RafaelGSS I don't see this PR in the changelog for 22.0.0, was it somehow excluded for whatever reason? It doesn't seem to be fixed in current V22 either.

[anonrig]

cc @nodejs/releasers

[atilkan]

Is it possible that with this change inline comments are gone?